Re: [PATCH v3 2/2] dt-bindings: leds: Document LTC3208 Multidisplay LED Driver

[Krzysztof Kozlowski <krzk@kernel.org>]

On 13/04/2026 01:37, Roleda, Jan carlo wrote:
> Hello Krzysztof,
> 
> Thank you again for the review. 
> 
> For clarification,
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk@kernel.org>
>> Sent: Tuesday, April 7, 2026 2:58 PM
>> To: Roleda, Jan carlo <Jancarlo.Roleda@analog.com>
>> Cc: Lee Jones <lee@kernel.org>; Pavel Machek <pavel@kernel.org>; Rob
>> Herring <robh@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor
>> Dooley <conor+dt@kernel.org>; linux-kernel@vger.kernel.org; linux-
>> leds@vger.kernel.org; devicetree@vger.kernel.org
>> Subject: Re: [PATCH v3 2/2] dt-bindings: leds: Document LTC3208 Multidisplay
>> LED Driver
>>
>> [External]
>>
>> On Mon, Apr 06, 2026 at 03:17:06PM +0800, Jan Carlo Roleda wrote:
>>> Add Documentation for LTC3208 Multidisplay LED Driver.
>>>
>>> Signed-off-by: Jan Carlo Roleda <jancarlo.roleda@analog.com>
>>> ---
>>
>> Still incorrect order.

You still did not correct the order of patches. I already asked you at v2.

>>
>> ...
>>
>>> +
>>> +      led-controller@1b {
>>> +        compatible = "adi,ltc3208";
>>> +        reg = <0x1b>;
>>> +        #address-cells = <1>;
>>> +        #size-cells = <0>;
>>> +        adi,disable-camhl-pin;
>>> +        adi,cfg-enrgbs-pin;
>>> +        adi,disable-rgb-aux4-dropout;
>>> +
>>> +        led@0 {
>>> +          reg = <0>;
>>
>> I still expect this to be complete, so at least function and color.
>>
>> Best regards,
>> Krzysztof
> 
> Are you referring here to keep the led@0-6,
> but instead of only the reg I should include other LED properties (i.e. function and color)?
> If so, I will add them as such in the next patch.
> 
> Do let me know if this is correct.

Make the example complete.

Best regards,
Krzysztof