Re: [PATCH 1/1] leds: blinkm: Remove unused variable

["Jan-Simon Möller" <dl9pf@gmx.de>]

Nighttime here. I'll look tomorrow.
-- 

Dipl.-Ing.
Jan-Simon Möller

jansimon.moeller@gmx.de
Am Dienstag, 1. Juli 2014, 08:54:27 schrieb Bryan Wu:
> On Tue, Jul 1, 2014 at 5:07 AM, Sachin Kamat <sachin.kamat@samsung.com> 
wrote:
> > 'ret' is not used in the function. Remove it.
> 
> Removing it is easy but I guess we should check the return error status
> here. Jan-Simon, what's your opinion then?
> 
> Thanks,
> -Bryan
> 
> > Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com>
> > ---
> > 
> >  drivers/leds/leds-blinkm.c |    8 +++-----
> >  1 file changed, 3 insertions(+), 5 deletions(-)
> > 
> > diff --git a/drivers/leds/leds-blinkm.c b/drivers/leds/leds-blinkm.c
> > index d0452b099aee..f07f920ac0ac 100644
> > --- a/drivers/leds/leds-blinkm.c
> > +++ b/drivers/leds/leds-blinkm.c
> > @@ -441,14 +441,13 @@ static int blinkm_transfer_hw(struct i2c_client
> > *client, int cmd)> 
> >  static void led_work(struct work_struct *work)
> >  {
> > 
> > -       int ret;
> > 
> >         struct blinkm_led *led;
> >         struct blinkm_data *data;
> >         struct blinkm_work *blm_work = work_to_blmwork(work);
> >         
> >         led = blm_work->blinkm_led;
> >         data = i2c_get_clientdata(led->i2c_client);
> > 
> > -       ret = blinkm_transfer_hw(led->i2c_client, BLM_GO_RGB);
> > +       blinkm_transfer_hw(led->i2c_client, BLM_GO_RGB);
> > 
> >         atomic_dec(&led->active);
> >         dev_dbg(&led->i2c_client->dev,
> >         
> >                         "# DONE # next_red = %d, next_green = %d,"
> > 
> > @@ -546,9 +545,8 @@ static void blinkm_led_blue_set(struct led_classdev
> > *led_cdev,> 
> >  static void blinkm_init_hw(struct i2c_client *client)
> >  {
> > 
> > -       int ret;
> > -       ret = blinkm_transfer_hw(client, BLM_STOP_SCRIPT);
> > -       ret = blinkm_transfer_hw(client, BLM_GO_RGB);
> > +       blinkm_transfer_hw(client, BLM_STOP_SCRIPT);
> > +       blinkm_transfer_hw(client, BLM_GO_RGB);
> > 
> >  }
> >  
> >  static int blinkm_test_run(struct i2c_client *client)
> > 
> > --
> > 1.7.9.5