From: William Zhang <william.zhang@broadcom.com>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>,
Pavel Machek <pavel@ucw.cz>,
Florian Fainelli <f.fainelli@gmail.com>,
linux-leds@vger.kernel.org
Cc: "Rafał Miłecki" <rafal@milecki.pl>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds: bcm63138: refer to ARCH_BCMBCA instead of ARCH_BCM4908
Date: Tue, 7 Mar 2023 16:49:04 -0800 [thread overview]
Message-ID: <326dd0c4-06a1-7dfb-db6e-05e87d37dabc@broadcom.com> (raw)
In-Reply-To: <20230307082936.16631-1-lukas.bulwahn@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1644 bytes --]
On 03/07/2023 12:29 AM, Lukas Bulwahn wrote:
> Commit dd5c672d7ca9 ("arm64: bcmbca: Merge ARCH_BCM4908 to ARCH_BCMBCA")
> removes config ARCH_BCM4908 as config ARCH_BCMBCA has the same intent.
>
> Probably due to concurrent development, commit a0ba692072d8 ("leds:
> bcm63138: add support for BCM63138 controller") introduces 'LED Support
> for Broadcom BCM63138 SoC' that depends on ARCH_BCM4908, but this use was
> not visible during the config refactoring from the commit above. Hence,
> these two changes create a reference to a non-existing config symbol.
>
> Adjust the LEDS_BCM63138 definition to refer to ARCH_BCMBCA instead of
> ARCH_BCM4908 to remove the reference to the non-existing config symbol
> ARCH_BCM4908.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> drivers/leds/blink/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/leds/blink/Kconfig b/drivers/leds/blink/Kconfig
> index 945c84286a4e..bdcb7377cd4e 100644
> --- a/drivers/leds/blink/Kconfig
> +++ b/drivers/leds/blink/Kconfig
> @@ -1,10 +1,10 @@
> config LEDS_BCM63138
> tristate "LED Support for Broadcom BCM63138 SoC"
> depends on LEDS_CLASS
> - depends on ARCH_BCM4908 || ARCH_BCM_5301X || BCM63XX || COMPILE_TEST
> + depends on ARCH_BCMBCA || ARCH_BCM_5301X || BCM63XX || COMPILE_TEST
> depends on HAS_IOMEM
> depends on OF
> - default ARCH_BCM4908
> + default ARCH_BCMBCA
> help
> This option enables support for LED controller that is part of
> BCM63138 SoC. The same hardware block is known to be also used
>
Acked-by: William Zhang <william.zhang@broadcom.com>
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4212 bytes --]
next prev parent reply other threads:[~2023-03-08 0:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 8:29 [PATCH] leds: bcm63138: refer to ARCH_BCMBCA instead of ARCH_BCM4908 Lukas Bulwahn
2023-03-07 9:41 ` Rafał Miłecki
2023-03-08 0:45 ` William Zhang
2023-03-08 0:49 ` William Zhang [this message]
2023-03-08 6:21 ` Rafał Miłecki
2023-03-25 16:19 ` Pavel Machek
2023-03-25 16:34 ` Florian Fainelli
-- strict thread matches above, loose matches on Subject: below --
2022-09-07 7:00 Lukas Bulwahn
2022-09-07 21:38 ` William Zhang
2022-09-07 21:43 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=326dd0c4-06a1-7dfb-db6e-05e87d37dabc@broadcom.com \
--to=william.zhang@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=pavel@ucw.cz \
--cc=rafal@milecki.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).