* [PATCH] leds: bcm63138: refer to ARCH_BCMBCA instead of ARCH_BCM4908
@ 2023-03-07 8:29 Lukas Bulwahn
2023-03-07 9:41 ` Rafał Miłecki
` (4 more replies)
0 siblings, 5 replies; 10+ messages in thread
From: Lukas Bulwahn @ 2023-03-07 8:29 UTC (permalink / raw)
To: Pavel Machek, Florian Fainelli, linux-leds
Cc: William Zhang, Rafał Miłecki, kernel-janitors,
linux-kernel, Lukas Bulwahn
Commit dd5c672d7ca9 ("arm64: bcmbca: Merge ARCH_BCM4908 to ARCH_BCMBCA")
removes config ARCH_BCM4908 as config ARCH_BCMBCA has the same intent.
Probably due to concurrent development, commit a0ba692072d8 ("leds:
bcm63138: add support for BCM63138 controller") introduces 'LED Support
for Broadcom BCM63138 SoC' that depends on ARCH_BCM4908, but this use was
not visible during the config refactoring from the commit above. Hence,
these two changes create a reference to a non-existing config symbol.
Adjust the LEDS_BCM63138 definition to refer to ARCH_BCMBCA instead of
ARCH_BCM4908 to remove the reference to the non-existing config symbol
ARCH_BCM4908.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
drivers/leds/blink/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/leds/blink/Kconfig b/drivers/leds/blink/Kconfig
index 945c84286a4e..bdcb7377cd4e 100644
--- a/drivers/leds/blink/Kconfig
+++ b/drivers/leds/blink/Kconfig
@@ -1,10 +1,10 @@
config LEDS_BCM63138
tristate "LED Support for Broadcom BCM63138 SoC"
depends on LEDS_CLASS
- depends on ARCH_BCM4908 || ARCH_BCM_5301X || BCM63XX || COMPILE_TEST
+ depends on ARCH_BCMBCA || ARCH_BCM_5301X || BCM63XX || COMPILE_TEST
depends on HAS_IOMEM
depends on OF
- default ARCH_BCM4908
+ default ARCH_BCMBCA
help
This option enables support for LED controller that is part of
BCM63138 SoC. The same hardware block is known to be also used
--
2.17.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH] leds: bcm63138: refer to ARCH_BCMBCA instead of ARCH_BCM4908
2023-03-07 8:29 [PATCH] leds: bcm63138: refer to ARCH_BCMBCA instead of ARCH_BCM4908 Lukas Bulwahn
@ 2023-03-07 9:41 ` Rafał Miłecki
2023-03-08 0:45 ` William Zhang
2023-03-08 0:49 ` William Zhang
` (3 subsequent siblings)
4 siblings, 1 reply; 10+ messages in thread
From: Rafał Miłecki @ 2023-03-07 9:41 UTC (permalink / raw)
To: Lukas Bulwahn
Cc: Pavel Machek, Florian Fainelli, linux-leds, William Zhang,
kernel-janitors, linux-kernel
On 2023-03-07 09:29, Lukas Bulwahn wrote:
> diff --git a/drivers/leds/blink/Kconfig b/drivers/leds/blink/Kconfig
> index 945c84286a4e..bdcb7377cd4e 100644
> --- a/drivers/leds/blink/Kconfig
> +++ b/drivers/leds/blink/Kconfig
> @@ -1,10 +1,10 @@
> config LEDS_BCM63138
> tristate "LED Support for Broadcom BCM63138 SoC"
> depends on LEDS_CLASS
> - depends on ARCH_BCM4908 || ARCH_BCM_5301X || BCM63XX || COMPILE_TEST
> + depends on ARCH_BCMBCA || ARCH_BCM_5301X || BCM63XX || COMPILE_TEST
> depends on HAS_IOMEM
> depends on OF
> - default ARCH_BCM4908
> + default ARCH_BCMBCA
> help
> This option enables support for LED controller that is part of
> BCM63138 SoC. The same hardware block is known to be also used
William: do we want LEDS_BCM63138 default on all BCMBCA devices?
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] leds: bcm63138: refer to ARCH_BCMBCA instead of ARCH_BCM4908
2023-03-07 9:41 ` Rafał Miłecki
@ 2023-03-08 0:45 ` William Zhang
0 siblings, 0 replies; 10+ messages in thread
From: William Zhang @ 2023-03-08 0:45 UTC (permalink / raw)
To: Rafał Miłecki, Lukas Bulwahn
Cc: Pavel Machek, Florian Fainelli, linux-leds, kernel-janitors,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1085 bytes --]
Hi Rafal,
On 03/07/2023 01:41 AM, Rafał Miłecki wrote:
> On 2023-03-07 09:29, Lukas Bulwahn wrote:
>> diff --git a/drivers/leds/blink/Kconfig b/drivers/leds/blink/Kconfig
>> index 945c84286a4e..bdcb7377cd4e 100644
>> --- a/drivers/leds/blink/Kconfig
>> +++ b/drivers/leds/blink/Kconfig
>> @@ -1,10 +1,10 @@
>> config LEDS_BCM63138
>> tristate "LED Support for Broadcom BCM63138 SoC"
>> depends on LEDS_CLASS
>> - depends on ARCH_BCM4908 || ARCH_BCM_5301X || BCM63XX || COMPILE_TEST
>> + depends on ARCH_BCMBCA || ARCH_BCM_5301X || BCM63XX || COMPILE_TEST
>> depends on HAS_IOMEM
>> depends on OF
>> - default ARCH_BCM4908
>> + default ARCH_BCMBCA
>> help
>> This option enables support for LED controller that is part of
>> BCM63138 SoC. The same hardware block is known to be also used
>
> William: do we want LEDS_BCM63138 default on all BCMBCA devices?
Yes that is fine. We can always build this driver for BCMBCA but it will
be only probed and running if dts enable such device.
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4212 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] leds: bcm63138: refer to ARCH_BCMBCA instead of ARCH_BCM4908
2023-03-07 8:29 [PATCH] leds: bcm63138: refer to ARCH_BCMBCA instead of ARCH_BCM4908 Lukas Bulwahn
2023-03-07 9:41 ` Rafał Miłecki
@ 2023-03-08 0:49 ` William Zhang
2023-03-08 6:21 ` Rafał Miłecki
` (2 subsequent siblings)
4 siblings, 0 replies; 10+ messages in thread
From: William Zhang @ 2023-03-08 0:49 UTC (permalink / raw)
To: Lukas Bulwahn, Pavel Machek, Florian Fainelli, linux-leds
Cc: Rafał Miłecki, kernel-janitors, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1644 bytes --]
On 03/07/2023 12:29 AM, Lukas Bulwahn wrote:
> Commit dd5c672d7ca9 ("arm64: bcmbca: Merge ARCH_BCM4908 to ARCH_BCMBCA")
> removes config ARCH_BCM4908 as config ARCH_BCMBCA has the same intent.
>
> Probably due to concurrent development, commit a0ba692072d8 ("leds:
> bcm63138: add support for BCM63138 controller") introduces 'LED Support
> for Broadcom BCM63138 SoC' that depends on ARCH_BCM4908, but this use was
> not visible during the config refactoring from the commit above. Hence,
> these two changes create a reference to a non-existing config symbol.
>
> Adjust the LEDS_BCM63138 definition to refer to ARCH_BCMBCA instead of
> ARCH_BCM4908 to remove the reference to the non-existing config symbol
> ARCH_BCM4908.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> drivers/leds/blink/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/leds/blink/Kconfig b/drivers/leds/blink/Kconfig
> index 945c84286a4e..bdcb7377cd4e 100644
> --- a/drivers/leds/blink/Kconfig
> +++ b/drivers/leds/blink/Kconfig
> @@ -1,10 +1,10 @@
> config LEDS_BCM63138
> tristate "LED Support for Broadcom BCM63138 SoC"
> depends on LEDS_CLASS
> - depends on ARCH_BCM4908 || ARCH_BCM_5301X || BCM63XX || COMPILE_TEST
> + depends on ARCH_BCMBCA || ARCH_BCM_5301X || BCM63XX || COMPILE_TEST
> depends on HAS_IOMEM
> depends on OF
> - default ARCH_BCM4908
> + default ARCH_BCMBCA
> help
> This option enables support for LED controller that is part of
> BCM63138 SoC. The same hardware block is known to be also used
>
Acked-by: William Zhang <william.zhang@broadcom.com>
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4212 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] leds: bcm63138: refer to ARCH_BCMBCA instead of ARCH_BCM4908
2023-03-07 8:29 [PATCH] leds: bcm63138: refer to ARCH_BCMBCA instead of ARCH_BCM4908 Lukas Bulwahn
2023-03-07 9:41 ` Rafał Miłecki
2023-03-08 0:49 ` William Zhang
@ 2023-03-08 6:21 ` Rafał Miłecki
2023-03-25 16:19 ` Pavel Machek
2023-03-25 16:34 ` Florian Fainelli
4 siblings, 0 replies; 10+ messages in thread
From: Rafał Miłecki @ 2023-03-08 6:21 UTC (permalink / raw)
To: Lukas Bulwahn
Cc: Pavel Machek, Florian Fainelli, linux-leds, William Zhang,
kernel-janitors, linux-kernel
On 2023-03-07 09:29, Lukas Bulwahn wrote:
> Commit dd5c672d7ca9 ("arm64: bcmbca: Merge ARCH_BCM4908 to
> ARCH_BCMBCA")
> removes config ARCH_BCM4908 as config ARCH_BCMBCA has the same intent.
>
> Probably due to concurrent development, commit a0ba692072d8 ("leds:
> bcm63138: add support for BCM63138 controller") introduces 'LED Support
> for Broadcom BCM63138 SoC' that depends on ARCH_BCM4908, but this use
> was
> not visible during the config refactoring from the commit above. Hence,
> these two changes create a reference to a non-existing config symbol.
>
> Adjust the LEDS_BCM63138 definition to refer to ARCH_BCMBCA instead of
> ARCH_BCM4908 to remove the reference to the non-existing config symbol
> ARCH_BCM4908.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Acked-by: Rafał Miłecki <rafal@milecki.pl>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] leds: bcm63138: refer to ARCH_BCMBCA instead of ARCH_BCM4908
2023-03-07 8:29 [PATCH] leds: bcm63138: refer to ARCH_BCMBCA instead of ARCH_BCM4908 Lukas Bulwahn
` (2 preceding siblings ...)
2023-03-08 6:21 ` Rafał Miłecki
@ 2023-03-25 16:19 ` Pavel Machek
2023-03-25 16:34 ` Florian Fainelli
4 siblings, 0 replies; 10+ messages in thread
From: Pavel Machek @ 2023-03-25 16:19 UTC (permalink / raw)
To: Lukas Bulwahn
Cc: Florian Fainelli, linux-leds, William Zhang, Rafa?? Mi??ecki,
kernel-janitors, linux-kernel
On Tue 2023-03-07 09:29:36, Lukas Bulwahn wrote:
> Commit dd5c672d7ca9 ("arm64: bcmbca: Merge ARCH_BCM4908 to ARCH_BCMBCA")
> removes config ARCH_BCM4908 as config ARCH_BCMBCA has the same intent.
>
> Probably due to concurrent development, commit a0ba692072d8 ("leds:
> bcm63138: add support for BCM63138 controller") introduces 'LED Support
> for Broadcom BCM63138 SoC' that depends on ARCH_BCM4908, but this use was
> not visible during the config refactoring from the commit above. Hence,
> these two changes create a reference to a non-existing config symbol.
>
> Adjust the LEDS_BCM63138 definition to refer to ARCH_BCMBCA instead of
> ARCH_BCM4908 to remove the reference to the non-existing config symbol
> ARCH_BCM4908.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Do we really want this "default Y" on those architectures? I'd understand
it for something critical but LED is not, and if it is not even present on
all such machines...
BR,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] leds: bcm63138: refer to ARCH_BCMBCA instead of ARCH_BCM4908
2023-03-07 8:29 [PATCH] leds: bcm63138: refer to ARCH_BCMBCA instead of ARCH_BCM4908 Lukas Bulwahn
` (3 preceding siblings ...)
2023-03-25 16:19 ` Pavel Machek
@ 2023-03-25 16:34 ` Florian Fainelli
4 siblings, 0 replies; 10+ messages in thread
From: Florian Fainelli @ 2023-03-25 16:34 UTC (permalink / raw)
To: Lukas Bulwahn, Pavel Machek, linux-leds
Cc: William Zhang, Rafał Miłecki, kernel-janitors,
linux-kernel
On 3/7/2023 12:29 AM, Lukas Bulwahn wrote:
> Commit dd5c672d7ca9 ("arm64: bcmbca: Merge ARCH_BCM4908 to ARCH_BCMBCA")
> removes config ARCH_BCM4908 as config ARCH_BCMBCA has the same intent.
>
> Probably due to concurrent development, commit a0ba692072d8 ("leds:
> bcm63138: add support for BCM63138 controller") introduces 'LED Support
> for Broadcom BCM63138 SoC' that depends on ARCH_BCM4908, but this use was
> not visible during the config refactoring from the commit above. Hence,
> these two changes create a reference to a non-existing config symbol.
>
> Adjust the LEDS_BCM63138 definition to refer to ARCH_BCMBCA instead of
> ARCH_BCM4908 to remove the reference to the non-existing config symbol
> ARCH_BCM4908.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] leds: bcm63138: refer to ARCH_BCMBCA instead of ARCH_BCM4908
@ 2022-09-07 7:00 Lukas Bulwahn
2022-09-07 21:38 ` William Zhang
2022-09-07 21:43 ` Florian Fainelli
0 siblings, 2 replies; 10+ messages in thread
From: Lukas Bulwahn @ 2022-09-07 7:00 UTC (permalink / raw)
To: Pavel Machek, Florian Fainelli, linux-leds
Cc: William Zhang, Rafał Miłecki, kernel-janitors,
linux-kernel, Lukas Bulwahn
Commit dd5c672d7ca9 ("arm64: bcmbca: Merge ARCH_BCM4908 to ARCH_BCMBCA")
removes config ARCH_BCM4908 as config ARCH_BCMBCA has the same intent.
Probably due to concurrent development, commit a0ba692072d8 ("leds:
bcm63138: add support for BCM63138 controller") introduces 'LED Support
for Broadcom BCM63138 SoC' that depends on ARCH_BCM4908, but this use was
not visible during the config refactoring from the commit above. Hence,
these two changes create a reference to a non-existing config symbol.
Adjust the LEDS_BCM63138 definition to refer to ARCH_BCMBCA instead of
ARCH_BCM4908 to remove the reference to the non-existing config symbol
ARCH_BCM4908.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
drivers/leds/blink/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/leds/blink/Kconfig b/drivers/leds/blink/Kconfig
index 945c84286a4e..bdcb7377cd4e 100644
--- a/drivers/leds/blink/Kconfig
+++ b/drivers/leds/blink/Kconfig
@@ -1,10 +1,10 @@
config LEDS_BCM63138
tristate "LED Support for Broadcom BCM63138 SoC"
depends on LEDS_CLASS
- depends on ARCH_BCM4908 || ARCH_BCM_5301X || BCM63XX || COMPILE_TEST
+ depends on ARCH_BCMBCA || ARCH_BCM_5301X || BCM63XX || COMPILE_TEST
depends on HAS_IOMEM
depends on OF
- default ARCH_BCM4908
+ default ARCH_BCMBCA
help
This option enables support for LED controller that is part of
BCM63138 SoC. The same hardware block is known to be also used
--
2.17.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH] leds: bcm63138: refer to ARCH_BCMBCA instead of ARCH_BCM4908
2022-09-07 7:00 Lukas Bulwahn
@ 2022-09-07 21:38 ` William Zhang
2022-09-07 21:43 ` Florian Fainelli
1 sibling, 0 replies; 10+ messages in thread
From: William Zhang @ 2022-09-07 21:38 UTC (permalink / raw)
To: Lukas Bulwahn, Pavel Machek, Florian Fainelli, linux-leds
Cc: Rafał Miłecki, kernel-janitors, linux-kernel
On 09/07/2022 12:00 AM, Lukas Bulwahn wrote:
> Commit dd5c672d7ca9 ("arm64: bcmbca: Merge ARCH_BCM4908 to ARCH_BCMBCA")
> removes config ARCH_BCM4908 as config ARCH_BCMBCA has the same intent.
>
> Probably due to concurrent development, commit a0ba692072d8 ("leds:
> bcm63138: add support for BCM63138 controller") introduces 'LED Support
> for Broadcom BCM63138 SoC' that depends on ARCH_BCM4908, but this use was
> not visible during the config refactoring from the commit above. Hence,
> these two changes create a reference to a non-existing config symbol.
>
> Adjust the LEDS_BCM63138 definition to refer to ARCH_BCMBCA instead of
> ARCH_BCM4908 to remove the reference to the non-existing config symbol
> ARCH_BCM4908.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> drivers/leds/blink/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/leds/blink/Kconfig b/drivers/leds/blink/Kconfig
> index 945c84286a4e..bdcb7377cd4e 100644
> --- a/drivers/leds/blink/Kconfig
> +++ b/drivers/leds/blink/Kconfig
> @@ -1,10 +1,10 @@
> config LEDS_BCM63138
> tristate "LED Support for Broadcom BCM63138 SoC"
> depends on LEDS_CLASS
> - depends on ARCH_BCM4908 || ARCH_BCM_5301X || BCM63XX || COMPILE_TEST
> + depends on ARCH_BCMBCA || ARCH_BCM_5301X || BCM63XX || COMPILE_TEST
> depends on HAS_IOMEM
> depends on OF
> - default ARCH_BCM4908
> + default ARCH_BCMBCA
> help
> This option enables support for LED controller that is part of
> BCM63138 SoC. The same hardware block is known to be also used
>
Acked-by: William Zhang <william.zhang@broadcom.com>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] leds: bcm63138: refer to ARCH_BCMBCA instead of ARCH_BCM4908
2022-09-07 7:00 Lukas Bulwahn
2022-09-07 21:38 ` William Zhang
@ 2022-09-07 21:43 ` Florian Fainelli
1 sibling, 0 replies; 10+ messages in thread
From: Florian Fainelli @ 2022-09-07 21:43 UTC (permalink / raw)
To: Lukas Bulwahn, Pavel Machek, linux-leds
Cc: William Zhang, Rafał Miłecki, kernel-janitors,
linux-kernel
On 9/7/2022 12:00 AM, Lukas Bulwahn wrote:
> Commit dd5c672d7ca9 ("arm64: bcmbca: Merge ARCH_BCM4908 to ARCH_BCMBCA")
> removes config ARCH_BCM4908 as config ARCH_BCMBCA has the same intent.
>
> Probably due to concurrent development, commit a0ba692072d8 ("leds:
> bcm63138: add support for BCM63138 controller") introduces 'LED Support
> for Broadcom BCM63138 SoC' that depends on ARCH_BCM4908, but this use was
> not visible during the config refactoring from the commit above. Hence,
> these two changes create a reference to a non-existing config symbol.
>
> Adjust the LEDS_BCM63138 definition to refer to ARCH_BCMBCA instead of
> ARCH_BCM4908 to remove the reference to the non-existing config symbol
> ARCH_BCM4908.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2023-03-25 16:34 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-07 8:29 [PATCH] leds: bcm63138: refer to ARCH_BCMBCA instead of ARCH_BCM4908 Lukas Bulwahn
2023-03-07 9:41 ` Rafał Miłecki
2023-03-08 0:45 ` William Zhang
2023-03-08 0:49 ` William Zhang
2023-03-08 6:21 ` Rafał Miłecki
2023-03-25 16:19 ` Pavel Machek
2023-03-25 16:34 ` Florian Fainelli
-- strict thread matches above, loose matches on Subject: below --
2022-09-07 7:00 Lukas Bulwahn
2022-09-07 21:38 ` William Zhang
2022-09-07 21:43 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).