From: Heiner Kallweit <hkallweit1@gmail.com>
To: Jacek Anaszewski <j.anaszewski@samsung.com>,
"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>
Subject: [PATCH 2/8] leds: gpio: set max_brightness to 1
Date: Tue, 13 Sep 2016 08:03:14 +0200 [thread overview]
Message-ID: <34a66492-d95f-0616-9eb1-84e283cf3f1d@gmail.com> (raw)
In-Reply-To: <5432fb03-ea18-a949-ce53-10fedc15f5d9@gmail.com>
GPIO-controlled LED's just have the status on or off.
Set max_brightness to 1 to reflect this.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/leds/leds-gpio.c | 13 ++++---------
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c
index 3599b2e..3f64544 100644
--- a/drivers/leds/leds-gpio.c
+++ b/drivers/leds/leds-gpio.c
@@ -34,22 +34,16 @@ static void gpio_led_set(struct led_classdev *led_cdev,
{
struct gpio_led_data *led_dat =
container_of(led_cdev, struct gpio_led_data, cdev);
- int level;
-
- if (value == LED_OFF)
- level = 0;
- else
- level = 1;
if (led_dat->blinking) {
- led_dat->platform_gpio_blink_set(led_dat->gpiod, level,
+ led_dat->platform_gpio_blink_set(led_dat->gpiod, value,
NULL, NULL);
led_dat->blinking = 0;
} else {
if (led_dat->can_sleep)
- gpiod_set_value_cansleep(led_dat->gpiod, level);
+ gpiod_set_value_cansleep(led_dat->gpiod, value);
else
- gpiod_set_value(led_dat->gpiod, level);
+ gpiod_set_value(led_dat->gpiod, value);
}
}
@@ -106,6 +100,7 @@ static int create_gpio_led(const struct gpio_led *template,
return -EINVAL;
}
+ led_dat->cdev.max_brightness = 1;
led_dat->cdev.name = template->name;
led_dat->cdev.default_trigger = template->default_trigger;
led_dat->can_sleep = gpiod_cansleep(led_dat->gpiod);
--
2.9.2
next parent reply other threads:[~2016-09-13 6:04 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5432fb03-ea18-a949-ce53-10fedc15f5d9@gmail.com>
2016-09-13 6:03 ` Heiner Kallweit [this message]
2016-09-13 13:35 ` [PATCH 2/8] leds: gpio: set max_brightness to 1 Jacek Anaszewski
2016-09-13 18:42 ` Heiner Kallweit
2016-09-13 6:03 ` [PATCH 3/8] leds: gpio: fix an unhandled error case in create_gpio_led Heiner Kallweit
2016-09-13 6:03 ` [PATCH 4/8] leds: gpio: add helper cdev_to_gpio_led_data Heiner Kallweit
2016-09-13 6:03 ` [PATCH 5/8] leds: gpio: simplify gpio_leds_create Heiner Kallweit
2016-09-13 6:03 ` [PATCH 6/8] leds: gpio: fix and simplify reading property "label" Heiner Kallweit
2016-09-13 6:03 ` [PATCH 7/8] leds: gpio: switch to managed version of led_classdev_register Heiner Kallweit
2016-09-13 6:03 ` [PATCH 8/8] leds: gpio: fix and simplify error handling in gpio_leds_create Heiner Kallweit
2016-09-13 18:53 ` [PATCH 1/6] leds: gpio: fix an unhandled error case in create_gpio_led Heiner Kallweit
2016-09-14 7:13 ` Jacek Anaszewski
2016-09-15 11:48 ` Jacek Anaszewski
2016-09-13 18:54 ` [PATCH 2/6] leds: gpio: add helper cdev_to_gpio_led_data Heiner Kallweit
2016-09-13 18:55 ` [PATCH 3/6] leds: gpio: simplify gpio_leds_create Heiner Kallweit
2016-09-13 18:56 ` [PATCH 4/6] leds: gpio: fix and simplify reading property "label" Heiner Kallweit
2016-09-13 18:57 ` [PATCH 5/6] leds: gpio: switch to managed version of led_classdev_register Heiner Kallweit
2016-09-13 18:57 ` [PATCH 6/6] leds: gpio: fix and simplify error handling in gpio_leds_create Heiner Kallweit
2016-09-14 18:54 ` [PATCH v2 2/7] leds: gpio: fix an unhandled error case in create_gpio_led Heiner Kallweit
2016-09-14 18:55 ` [PATCH v2 3/7] leds: gpio: add helper cdev_to_gpio_led_data Heiner Kallweit
2016-09-14 18:55 ` [PATCH v2 4/7] leds: gpio: simplify gpio_leds_create Heiner Kallweit
2016-09-14 18:55 ` [PATCH v2 5/7] leds: gpio: fix and simplify reading property "label" Heiner Kallweit
2016-09-14 18:55 ` [PATCH v2 6/7] leds: gpio: switch to managed version of led_classdev_register Heiner Kallweit
2016-09-14 18:55 ` [PATCH v2 7/7] leds: gpio: fix and simplify error handling in gpio_leds_create Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34a66492-d95f-0616-9eb1-84e283cf3f1d@gmail.com \
--to=hkallweit1@gmail.com \
--cc=j.anaszewski@samsung.com \
--cc=linux-leds@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).