From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74639C4332F for ; Sun, 8 Sep 2019 16:17:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3ED42214DB for ; Sun, 8 Sep 2019 16:17:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Y07CNuZz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729411AbfIHQRf (ORCPT ); Sun, 8 Sep 2019 12:17:35 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:39134 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729409AbfIHQRf (ORCPT ); Sun, 8 Sep 2019 12:17:35 -0400 Received: by mail-wr1-f65.google.com with SMTP id t16so11253453wra.6; Sun, 08 Sep 2019 09:17:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=34Gm+mqacQT9Dg5F66EbtT1u+Ti5scHvGTdVQxEaWAY=; b=Y07CNuZzY9bsIMmUCgO8/vzqf1BW2TPIbdHKcvzyPIaVgOGBsRBOscGLcejjLkmuMy iHEfeGzkVxjtHcl9DW1+awr8dZiFDwwnsSm3AponcWls+yjSRO6fnPQ+BfVpT7hVtwna 3hTEsiXHoBO5mxR+cNuEph7ODod63QftR2l+wiX7Hl2GI33rvkouuhnphkztG9aZBRuQ L58e9jgEILSJU8edSxKlHpMz+4CR7Au+e+BIVIdTn3j/4LDtSRc8q+X44pu0Ma8CE5A9 c9SqPkggGXorNDcwKGD3sdi0T7LxL5EMBo2tORl0Yh8jlfX112g666plHIDFLLgH9In1 TXMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=34Gm+mqacQT9Dg5F66EbtT1u+Ti5scHvGTdVQxEaWAY=; b=a/j0U01HoaB3IEk3Qm6+kHbxSshRAb8ntYEbh4Xm/DbhI7568vTYixxgTu2BLhCmwL nVRGnkYRbXg3VaMFKgXOHefFRNYH5WxHSIkfjTbAFWveGQm2/+hRDUttcCoLLuXB0ARu o/Y8JeznXs5G6fZBbnezpcEycSeC/gt18xUr6/ekvkMBQhVIq60mQ1hS4IOYudvMbw5H RLh7Ln/eZCMutr9UWy9iH//IQpkr30kdZqZl3AhUhjZfIbZrSAK3KKbLt3C92UJ6tntI ubzdWoRLnnxC1VkuHr3nr17hPfl1cYrzDi1DaBuMzXP/Euk/tA6Z/7hdhf5904SRdepZ peCw== X-Gm-Message-State: APjAAAVv/HHeBMp6YLzUKU3Y6RO+aKSeqOn2njLbo3q2h+XPDcoRv9r0 LmGYnEuWD0weaFuHxUAjr6jya6v5 X-Google-Smtp-Source: APXvYqzYub7QtpY9k0T98+d/JC8P0GnCDBEfZGdNsLe02qkeBKAkLaGdIZEoqc5KaI7AgiGrbZnF9g== X-Received: by 2002:a5d:5345:: with SMTP id t5mr13193531wrv.30.1567959452082; Sun, 08 Sep 2019 09:17:32 -0700 (PDT) Received: from [192.168.1.19] (bdt94.neoplus.adsl.tpnet.pl. [83.28.5.94]) by smtp.gmail.com with ESMTPSA id m3sm10459017wmc.44.2019.09.08.09.17.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 08 Sep 2019 09:17:31 -0700 (PDT) Subject: Re: [FYI] lm3532: right registration to work with LED-backlight To: Pavel Machek Cc: Tony Lindgren , kernel list , sre@kernel.org, nekit1000@gmail.com, mpartap@gmx.net, merlijn@wizzup.org, Dan Murphy , linux-leds@vger.kernel.org References: <20190827215205.59677-1-tony@atomide.com> <20190828085339.GB2923@amd> <20190908080305.GC25459@amd> From: Jacek Anaszewski Openpgp: preference=signencrypt Autocrypt: addr=jacek.anaszewski@gmail.com; prefer-encrypt=mutual; keydata= mQINBFWjfaEBEADd66EQbd6yd8YjG0kbEDT2QIkx8C7BqMXR8AdmA1OMApbfSvEZFT1D/ECR eWFBS8XtApKQx1xAs1j5z70k3zebk2eeNs5ahxi6vM4Qh89vBM46biSKeeX5fLcv7asmGb/a FnHPAfQaKFyG/Bj9V+//ef67hpjJWR3s74C6LZCFLcbZM0z/wTH+baA5Jwcnqr4h/ygosvhP X3gkRzJLSFYekmEv+WHieeKXLrJdsUPUvPJTZtvi3ELUxHNOZwX2oRJStWpmL2QGMwPokRNQ 29GvnueQdQrIl2ylhul6TSrClMrKZqOajDFng7TLgvNfyVZE8WQwmrkTrdzBLfu3kScjE14Q Volq8OtQpTsw5570D4plVKh2ahlhrwXdneSot0STk9Dh1grEB/Jfw8dknvqkdjALUrrM45eF FM4FSMxIlNV8WxueHDss9vXRbCUxzGw37Ck9JWYo0EpcpcvwPf33yntYCbnt+RQRjv7vy3w5 osVwRR4hpbL/fWt1AnZ+RvbP4kYSptOCPQ+Pp1tCw16BOaPjtlqSTcrlD2fo2IbaB5D21SUa IsdZ/XkD+V2S9jCrN1yyK2iKgxtDoUkWiqlfRgH2Ep1tZtb4NLF/S0oCr7rNLO7WbqLZQh1q ShfZR16h7YW//1/NFwnyCVaG1CP/L/io719dPWgEd/sVSKT2TwARAQABtC1KYWNlayBBbmFz emV3c2tpIDxqYWNlay5hbmFzemV3c2tpQGdtYWlsLmNvbT6JAlgEEwEIAEICGwMHCwkIBwMC AQYVCAIJCgsDFgIBAh4BAheABQkJZgNMFiEEvx38ClaPBfeVdXCQvWpQHLeLfCYFAl05/9sC GQEACgkQvWpQHLeLfCarMQ/9FN/WqJdN2tf6xkP0RFyS4ft0sT04zkOCFfOMxs8mZ+KZoMU+ X3a+fEppDL7xgRFpHyGaEel7lSi1eqtzsqZ5JiHbDS1Ht1G8TtATb8q8id68qeSeW2mfzaLQ 98NPELGfUXFoUqUQkG5z2p92UrGF4Muj1vOIW93pwvE4uDpNsl+jriwHomLtjIUoZtIRjGfZ RCyUQI0vi5LYzXCebuzAjGD7Jh2YAp7fDGrv3qTq8sX+DUJ4H/+I8PiL+jXKkEeppqIhlBJJ l4WcgggMu3c2uljYDuqRYghte33BXyCPAocfO2/sN+yJRUTVuRFlOxUk4srz/W8SQDwOAwtK V7TzdyF1/jOGBxWwS13EjMb4u3XwPMzcPlEQNdIqz76NFmJ99xYEvgkAmFmRioxuBTRv8Fs1 c1jQ00WWJ5vezqY6lccdDroPalXWeFzfPjIhKbV3LAYTlqv0It75GW9+0TBhPqdTM15DrCVX B7Ues7UnD5FBtWwewTnwr+cu8te449VDMzN2I+a9YKJ1s6uZmzh5HnuKn6tAfGyQh8MujSOM lZrNHrRsIsLXOjeGVa84Qk/watEcOoyQ7d+YaVosU0OCZl0GldvbGp1z2u8cd2N/HJ7dAgFh Q7dtGXmdXpt2WKQvTvQXhIrCWVQErNYbDZDD2V0TZtlPBaZP4fkUDkvH+Sy5Ag0EVaN9oQEQ AMPNymBNoCWc13U6qOztXrIKBVsLGZXq/yOaR2n7gFbFACD0TU7XuH2UcnwvNR+uQFwSrRqa EczX2V6iIy2CITXKg5Yvg12yn09gTmafuoIyKoU16XvC3aZQQ2Bn3LO2sRP0j/NuMD9GlO37 pHCVRpI2DPxFE39TMm1PLbHnDG8+lZql+dpNwWw8dDaRgyXx2Le542CcTBT52VCeeWDtqd2M wOr4LioYlfGfAqmwcwucBdTEBUxklQaOR3VbJQx6ntI2oDOBlNGvjnVDzZe+iREd5l40l+Oj TaiWvBGXkv6OI+wx5TFPp+BM6ATU+6UzFRTUWbj+LqVA/JMqYHQp04Y4H5GtjbHCa8abRvBw IKEvpwTyWZlfXPtp8gRlNmxYn6gQlTyEZAWodXwE7CE+KxNnq7bPHeLvrSn8bLNK682PoTGr 0Y00bguYLfyvEwuDYek1/h9YSXtHaCR3CEj4LU1B561G1j7FVaeYbX9bKBAoy/GxAW8J5O1n mmw7FnkSHuwO/QDe0COoO0QZ620Cf9IBWYHW4m2M2yh5981lUaiMcNM2kPgsJFYloFo2XGn6 lWU9BrWjEoNDhHZtF+yaPEuwjZo6x/3E2Tu3E5Jj0VpVcE9U1Zq/fquDY79l2RJn5ENogOs5 +Pi0GjVpEYQVWfm0PTCxNPOzOzGR4QB3BNFvABEBAAGJAiUEGAEIAA8FAlWjfaECGwwFCQlm AYAACgkQvWpQHLeLfCZqGxAAlWBWVvjU6xj70GwengiqYZwmW1i8gfS4TNibQT/KRq0zkBnE wgKwXRbVoW38pYVuGa5x/JDQMJDrLAJ0wrCOS3XxbSHCWOl/k2ZD9OaxUeXq6N+OmGTzfrYv PUvWS1Hy04q9AD1dIaMNruZQmvnRfkOk2UDncDIg0166/NTHiYI09H5mpWGpHn/2aT6dmpVw uoM9/rHlF5s5qAAo95tZ0QW2BtIceG9/rbYlL57waSMPF49awvwLQX5RhWoF8mPS5LsBrXXK hmizIsn40tLbi2RtWjzDWgZYitqmmqijeCnDvISN4qJ/nCLO4DjiSGs59w5HR+l0nwePDhOC A4RYZqS1e2Clx1VSkDXFpL3egabcIsqK7CZ6a21r8lXVpo4RnMlQsmXZTnRx4SajFvX7PrRg /02C811fLfh2r5O5if8sKQ6BKKlHpuuioqfj/w9z3B0aQ71e4n1zNJBO1kcdznikPLAbr7jG gkBUXT1yJiwpTfRQr5y2Uo12IJsKxohnNFVYtK8X/R6S0deKPjrZWvAkllgIPcHjMi2Va8yw KTj/JgcpUO5KN906Pf7ywZISe7Kbcc/qnE0YjPPSqFOvoeZvHe6EZCMW9+xZsaipvlqpByQV UHnVg09K9YFvjUBsBPdC8ef6YwgfR9o6AnPmxl0oMUIXkCCC5c99fzJY/k+JAq0EGAEIACAW IQS/HfwKVo8F95V1cJC9alAct4t8JgUCWwqKhgIbAgCBCRC9alAct4t8JnYgBBkWCAAdFiEE FMMcSshOZf56bfAEYhBsURv0pdsFAlsKioYACgkQYhBsURv0pdvELgD/U+y3/hsz0bIjMQJY 0LLxM/rFY9Vz1L43+lQHXjL3MPsA/1lNm5sailsY7aFBVJxAzTa8ZAGWBdVaGo6KCvimDB8G 7joP/jx+oGOmdRogs7mG//H+w9DTnBfPpnfkeiiokGYo/+huWO5V0Ac9tTqZeFc//t/YuYJn wWvS0Rx+KL0fT3eh9BQo47uF4yDiZIiWLNh4Agpup1MUSVsz4MjD0lW6ghtnLcGlIgoVHW0v tPW1m9jATYyJSOG/MC1iDrcYcp9uVYn5tKfkEeQNspuG6iSfS0q3tajPKnT1nJxMTxVOD2RW EIGfaV9Scrou92VD/eC+/8INRsiWS93j3hOKIAV5XRNINFqtzkagPYAP8r6wksjSjh01fSTB p5zxjfsIwWDDzDrqgzwv83CvrLXRV3OlG1DNUDYA52qJr47paH5QMWmHW5TNuoBX8qb6RW/H M3DzPgT+l+r1pPjMPfvL1t7civZUoPuNzoyFpQRj6TvWi2bGGMQKryeYksXG2zi2+avMFnLe lOxGdUZ7jn1SJ6Abba5WL3VrXCP+TUE6bZLgfw8kYa8QSXP3ysyeMI0topHFntBZ8a0KXBNs qqFCBWmTHXfwsfW0VgBmRtPO7eXVBybjJ1VXKR2RZxwSq/GoNXh/yrRXQxbcpZ+QP3/Tttsb FdKciZ4u3ts+5UwYra0BRuvb51RiZR2wRNnUeBnXWagJVTlG7RHBO/2jJOE6wrcdCMjs0Iiw PNWmiVoZA930TvHA5UeGENxdGqo2MvMdRJ54YaIR Message-ID: <390760c1-de39-9328-bb23-cbf791094718@gmail.com> Date: Sun, 8 Sep 2019 18:17:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190908080305.GC25459@amd> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On 9/8/19 10:03 AM, Pavel Machek wrote: > On Wed 2019-08-28 22:32:57, Jacek Anaszewski wrote: >> On 8/28/19 10:53 AM, Pavel Machek wrote: >>> Hi! >>> >>> Eventually, these will be needed. >>> >>> Best regards, >>> Pavel >>> >>> commit 38d956977a7d6cbdc811676f9b4033da7487e045 >>> Author: Pavel >>> Date: Wed Aug 7 12:43:52 2019 +0200 >>> >>> d4: lm3532 needs to use right register function for backlight to work. >>> >>> diff --git a/drivers/leds/leds-lm3532.c b/drivers/leds/leds-lm3532.c >>> index 365a22a5..f98e657 100644 >>> --- a/drivers/leds/leds-lm3532.c >>> +++ b/drivers/leds/leds-lm3532.c >>> @@ -629,7 +629,7 @@ static int lm3532_parse_node(struct lm3532_data *priv) >>> >>> lm3532_init_registers(led); >>> >>> - ret = devm_led_classdev_register(priv->dev, &led->led_dev); >>> + ret = devm_of_led_classdev_register(priv->dev, to_of_node(child), &led->led_dev); >> >> We no longer have devm_of_led_classdev_register(). You must use >> devm_led_classdev_register_ext(). > > Something like this (untested)? > > Pavel > > diff --git a/drivers/leds/leds-lm3532.c b/drivers/leds/leds-lm3532.c > index 62ace66..6340d5b 100644 > --- a/drivers/leds/leds-lm3532.c > +++ b/drivers/leds/leds-lm3532.c > @@ -577,6 +577,11 @@ static int lm3532_parse_node(struct lm3532_data *priv) > priv->runtime_ramp_down = lm3532_get_ramp_index(ramp_time); > > device_for_each_child_node(priv->dev, child) { > + struct led_init_data idata = { > + .fwnode = child, > + .default_label = "backlight", > + }; > + If you want to properly switch to the new extended LED registration API, then you need: .default_label = ":", .devicename = led->client->name; and in addition to that you need to remove old way of composing the LED name. Something like patch [0] for leds-lm3692x.c. And also patch for DT for consistency would be needed (like [1]). However it will not change anything in LED naming in comparison to the existing code, except that it will enable the possibility of using 'function' and 'color' DT properties instead of deprecated 'label'. I suppose that you expected some extra bonus by passing DT node, but I'm not sure what exactly. Possibly you confused this with the patch set [2] that allows for instantiating backlight device on top of LED class device (it has been forgotten btw and will miss 5.4). And for lm3532 - it was just relying on the glue provided by ledtrig-backlight, as pointed out by Tony in [3]. > led = &priv->leds[i]; > > ret = fwnode_property_read_u32(child, "reg", &control_bank); > @@ -648,7 +653,7 @@ static int lm3532_parse_node(struct lm3532_data *priv) > led->led_dev.name = led->label; > led->led_dev.brightness_set_blocking = lm3532_brightness_set; > > - ret = devm_led_classdev_register(priv->dev, &led->led_dev); > + ret = devm_led_classdev_register_ext(priv->dev, &led->led_dev, &idata); > if (ret) { > dev_err(&priv->client->dev, "led register err: %d\n", > ret); > > [0] https://git.kernel.org/pub/scm/linux/kernel/git/j.anaszewski/linux-leds.git/commit/?h=for-next&id=a50ff28348934913c46feb7945571329e46c70b3 [1] https://git.kernel.org/pub/scm/linux/kernel/git/j.anaszewski/linux-leds.git/commit/?h=for-next&id=4dcbc8f8c59f4b618d651f5ba884ee5bf562c8de [2] https://lore.kernel.org/linux-leds/20190717141514.21171-1-jjhiblot@ti.com/ [3] https://lore.kernel.org/linux-leds/20190403235500.GU49658@atomide.com/ -- Best regards, Jacek Anaszewski