From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: sean.wang@mediatek.com, rpurdie@rpsys.net, lee.jones@linaro.org,
matthias.bgg@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com,
devicetree@vger.kernel.org, linux-leds@vger.kernel.org,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, keyhaede@gmail.com
Subject: Re: [PATCH v2 3/4] leds: Add LED support for MT6323 PMIC
Date: Thu, 9 Feb 2017 21:35:26 +0100 [thread overview]
Message-ID: <39b1c6ec-408c-bb92-f937-d477afa626a5@gmail.com> (raw)
In-Reply-To: <20170209142344.GA23373@xo-6d-61-c0.localdomain>
On 02/09/2017 03:23 PM, Pavel Machek wrote:
> Hi!
>
>>> +/*
>>> + * Register for MT6323_ISINK_CON0 to setup the
>>> + * duty cycle of the blink
>>> + */
>>> +#define MT6323_ISINK_CON0(i) (MT6323_ISINK0_CON0 + 0x8 * (i))
>>> +#define MT6323_ISINK_DIM_DUTY_MASK (0x1f << 8)
>>> +#define MT6323_ISINK_DIM_DUTY(i) (((i) << 8) & \
>>> + MT6323_ISINK_DIM_DUTY_MASK)
>>> +
>>> +/*
>>> + * Register to setup the period of the blink
>>> + */
>>
>> This fits in a single line, so can be wrapped with /* */ like :
>
> People do this to make blocks stand out, and to make it similar to other blocks
> above. I believe this is ok.
It generates unnecessary lines of code, but I'm not going to
argue, let's leave it to the developer's taste.
--
Best regards,
Jacek Anaszewski
next prev parent reply other threads:[~2017-02-09 20:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-08 2:19 [PATCH v2 0/4] leds: add leds-mt6323 support on MT7623 SoC sean.wang
2017-02-08 2:19 ` [PATCH v2 1/4] Documentation: devicetree: Add document bindings for leds-mt6323 sean.wang
2017-02-08 2:47 ` Andrew Lunn
[not found] ` <1486520357-13096-1-git-send-email-sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2017-02-08 2:19 ` [PATCH v2 2/4] Documentation: devicetree: Add LED subnode binding for MT6323 PMIC sean.wang-NuS5LvNUpcJWk0Htik3J/w
2017-02-08 12:22 ` Lee Jones
2017-02-08 2:19 ` [PATCH v2 3/4] leds: Add LED support " sean.wang
2017-02-08 21:00 ` Jacek Anaszewski
2017-02-09 6:09 ` Sean Wang
2017-02-09 14:23 ` Pavel Machek
2017-02-09 20:35 ` Jacek Anaszewski [this message]
2017-02-08 2:19 ` [PATCH v2 4/4] mfd: mt6397: Add MT6323 LED support into MT6397 driver sean.wang
2017-02-08 12:21 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39b1c6ec-408c-bb92-f937-d477afa626a5@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=keyhaede@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=rpurdie@rpsys.net \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).