From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.tuxedocomputers.com (mail.tuxedocomputers.com [157.90.84.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7AA471DD555; Mon, 7 Oct 2024 17:57:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=157.90.84.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728323833; cv=none; b=BYBz9VcGuXcvG7DGVEgeX2QwLWm1MTXLOak2LiKRGFVC2nObfBxaOKgZ6o8Mb7mANIeXSyCkvZXBMsE50tL96evTEHf6Xp/nEu5a5UT/rqEGqRT0cVUW70kCA0ZYeR5wo//8+u1s0sqaTahZq7azzVfqZY3ukKa+8EFzVYHjja4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728323833; c=relaxed/simple; bh=h3L8IgVFMqKnfTBdmE7EdHq6WxEkfyAoyfaD5LEtvgE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=d5zou2y/9e76f002kPhOv9qInL9m+DOLdqTzx8EG3CijsUaSFkmPGmV6W2DCaoUtGGo1lu7RhJxuaUjGzQgOJTkSo1ijH0UclUeLVPynOo9YTYDxJzy7UejTaYhG2T8I+TurHXLXS70QnTrGvxD0BXLOHpPTCdq0cWgjTbDvpN4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=tuxedocomputers.com; spf=pass smtp.mailfrom=tuxedocomputers.com; dkim=pass (1024-bit key) header.d=tuxedocomputers.com header.i=@tuxedocomputers.com header.b=QUBNoX/2; arc=none smtp.client-ip=157.90.84.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=tuxedocomputers.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxedocomputers.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=tuxedocomputers.com header.i=@tuxedocomputers.com header.b="QUBNoX/2" Received: from [192.168.42.96] (p5de457db.dip0.t-ipconnect.de [93.228.87.219]) (Authenticated sender: wse@tuxedocomputers.com) by mail.tuxedocomputers.com (Postfix) with ESMTPSA id B54F52FC004D; Mon, 7 Oct 2024 19:57:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxedocomputers.com; s=default; t=1728323826; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BdldwIyeD16eXrXCJmmOPyc0Ld6j2ynds8Z6PNLTWsE=; b=QUBNoX/2cClS6EjpLosxp8Jv29RatROr1BsQQOBVfzg81bezfTWJ/hq5mgL1SYSAAePAAz Pmgx2dISHwr74NocOwWEJ8TdgxNZz6WMiY1/YKZ46zkTm1wvo33eGZDpYXeQLqhhFwX8we BzGaH1A6DV40AemSLQ7S5m3Bvz7hAJo= Authentication-Results: mail.tuxedocomputers.com; auth=pass smtp.auth=wse@tuxedocomputers.com smtp.mailfrom=wse@tuxedocomputers.com Message-ID: <39f84cfe-bb89-4194-81a9-e178c93e5309@tuxedocomputers.com> Date: Mon, 7 Oct 2024 19:57:05 +0200 Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices To: Benjamin Tissoires Cc: Armin Wolf , Pavel Machek , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , dri-devel@lists.freedesktop.org, jelle@vdwaa.nl, jikos@kernel.org, lee@kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, miguel.ojeda.sandonis@gmail.com, ojeda@kernel.org, onitake@gmail.com, platform-driver-x86@vger.kernel.org References: <7r3zg4tcmp5ozjwyiusstgv7g4dha4wuh4kwssxpk3tkurpgo3@36laqab7lsxp> <58cf1777-222f-4156-9079-bcbba4a32c96@tuxedocomputers.com> <45qkbpaxhrv2r32hghjqoexkenktymzyjgpx2xnnxt6dmfawjt@44lrhgcnozh3> <586a1c41-bbe0-4912-b7c7-1716d886c198@tuxedocomputers.com> <5th4pisccud5s7dbia42glsnu7e5u3q7jszty6o3mjdedsd2bg@7nsvp6t2krnf> <84b629c6-5b26-4285-9b2f-66dd1afa99e5@tuxedocomputers.com> <7ce4470c-a502-416a-8472-a5b606bb8fd4@tuxedocomputers.com> Content-Language: en-US From: Werner Sembach In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, Am 02.10.24 um 10:31 schrieb Benjamin Tissoires: > On Oct 01 2024, Werner Sembach wrote: >> Hi Benjamin, >> >> Am 01.10.24 um 15:41 schrieb Benjamin Tissoires: >>> [...] >>> PPS: sorry for pushing that hard on HID-BPF, but I can see that it fits >>> all of the requirements here: >>> - need to be dynamic >>> - still unsure of the userspace implementation, meaning that userspace >>> might do something wrong, which might require kernel changes >> Well the reference implementetion for the arduiono macropad from microsoft >> ignores the intensity (brightness) channel on rgb leds contrary to the HID >> spec, soo yeah you have a point here ... > Heh :) > >>> - possibility to extend later the kernel API >>> - lots of fun :) >> You advertise it good ;). More work for me now but maybe less work for me >> later, I will look into it. > Again, I'm pushing this because I see the benefits and because I can > probably reuse the same code on my Corsair and Logitech keyboards. But > also, keep in mind that it's not mandatory because you can actually > attach the BPF code on top of your existing driver to change the way it > behaves. It'll be slightly more complex if you don't let a couple of > vendor passthrough reports that we can use to directly talk to the > device without any tampering, but that's doable. But if you want to keep > the current implementation and have a different layout, this can easily > be done in BPF on top. > > Cheers, > Benjamin > > > [0] https://lore.kernel.org/linux-input/20241001-hid-bpf-hid-generic-v3-0-2ef1019468df@kernel.org/T/#t Thinking about the minimal WMI to HID today, but found a problem: a HID feature report is either strictly input or output afaik, but the WMI interface has both in some functions. How would I map that? If I split everything in input and output the new interface wouldn't actually be much smaller. Also what would I write for the usage for the reserved padding in the report descriptor. Usage: 0x00? best regards, Werner