From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jacek Anaszewski Subject: Re: [PATCH v9 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver Date: Mon, 11 Dec 2017 22:41:11 +0100 Message-ID: <3b354b03-f19c-6c28-f6eb-5db11fb384bf@gmail.com> References: <20171211182659.21533-1-dmurphy@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20171211182659.21533-1-dmurphy-l0cyMroinI0@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dan Murphy , robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org, pavel-+ZI9xUNit7I@public.gmane.org Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-leds-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-leds@vger.kernel.org Dan, On 12/11/2017 07:26 PM, Dan Murphy wrote: > This adds the devicetree bindings for the LM3692x > I2C LED string driver. > > Acked-by: Pavel Machek > Signed-off-by: Dan Murphy > --- > > v9 - Moved 2 nodes to Optional Child and renamed node names to device type > https://patchwork.kernel.org/patch/10093757/ > > v8 - Added address-cells and size-cells as well as child node reg - https://patchwork.kernel.org/patch/10091259/ > v7 - No changes - https://patchwork.kernel.org/patch/10087475/ > v6 - No changes -https://patchwork.kernel.org/patch/10085567/ > v5 - No Changes - https://patchwork.kernel.org/patch/10081071/ > v4 - Fix example node, added trigger entry, removed ambiguous x for compatible and > added common.txt pointer for label - https://patchwork.kernel.org/patch/10060107 > v3 - No changes > v2 - No changes - https://patchwork.kernel.org/patch/10056677/ > > .../devicetree/bindings/leds/leds-lm3692x.txt | 49 ++++++++++++++++++++++ > 1 file changed, 49 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3692x.txt > > diff --git a/Documentation/devicetree/bindings/leds/leds-lm3692x.txt b/Documentation/devicetree/bindings/leds/leds-lm3692x.txt > new file mode 100644 > index 000000000000..a93e19edfb42 > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/leds-lm3692x.txt > @@ -0,0 +1,49 @@ > +* Texas Instruments - LM3692x Highly Efficient White LED Driver > + > +The LM3692x is an ultra-compact, highly efficient, > +white-LED driver designed for LCD display backlighting. > + > +The main difference between the LM36922 and LM36923 is the number of > +LED strings it supports. The LM36922 supports two strings while the LM36923 > +supports three strings. > + > +Required properties: > + - compatible: > + "ti,lm36922" > + "ti,lm36923" > + - reg : I2C slave address > + - #address-cells : 1 > + - #size-cells : 0 > + > +Optional properties: > + - enable-gpios : gpio pin to enable/disable the device. > + - vled-supply : LED supply > + > +Required child properties: > + - reg : 0 > + > +Optional child properties: > + - label : see Documentation/devicetree/bindings/leds/common.txt > + - linux,default-trigger : > + see Documentation/devicetree/bindings/leds/common.txt > + > +Example: > + > +led-controller@36 { > + compatible = "ti,lm3692x"; > + reg = <0x36>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + enable-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>; > + vled-supply = <&vbatt>; > + > + led@0 { > + reg = <0>; > + label = "backlight_cluster"; We need to consequently adhere to LED class device naming convention, so: label = "white:backlight_cluster"; > + linux,default-trigger = "backlight"; > + }; > +} > + > +For more product information please see the link below: > +http://www.ti.com/lit/ds/snvsa29/snvsa29.pdf > -- Best regards, Jacek Anaszewski -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html