From: Hans de Goede <hdegoede@redhat.com>
To: Johannes Berg <johannes@sipsolutions.net>,
Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>
Cc: Linux LED Subsystem <linux-leds@vger.kernel.org>
Subject: Re: "leds: trigger: use RCU to protect the led_cdevs list" triggers RCU error checks
Date: Wed, 12 Apr 2023 23:06:10 +0200 [thread overview]
Message-ID: <3bd58e16-53c7-0a81-45be-26fe1443b65a@redhat.com> (raw)
In-Reply-To: <0e0bf2a681db18c20eb9913b23d8ff2d5fddfe90.camel@sipsolutions.net>
Hi Johannes,
On 4/12/23 10:13, Johannes Berg wrote:
> Hi,
>
>> So I just checked and the following LED drivers all have
>> a blink_set() implementation which calls mutex_lock()
>> and/or does I2C transfers:
>
> <snip>
>
> Yay ...
<snip>
> So not sure. Clearly it's a long-standing issue, and given that many
> drivers are affected probably better to fix it in the LED core, but I
> don't really know my way around it very well either.
I think I've come up with a solution for this.
I'll Cc you on the patch-set for this when it is ready.
Regards,
Hans
prev parent reply other threads:[~2023-04-12 21:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 18:15 "leds: trigger: use RCU to protect the led_cdevs list" triggers RCU error checks Hans de Goede
2023-04-11 19:38 ` Johannes Berg
2023-04-11 21:26 ` Hans de Goede
2023-04-12 8:13 ` Johannes Berg
2023-04-12 21:06 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3bd58e16-53c7-0a81-45be-26fe1443b65a@redhat.com \
--to=hdegoede@redhat.com \
--cc=johannes@sipsolutions.net \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox