From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Jean-François Lessard" <jefflessard3@gmail.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>
Cc: "Geert Uytterhoeven" <geert@linux-m68k.org>,
devicetree@vger.kernel.org, linux-leds@vger.kernel.org,
linux-kernel@vger.kernel.org, "Andreas Färber" <afaerber@suse.de>,
"Boris Gjenero" <boris.gjenero@gmail.com>,
"Christian Hewitt" <christianshewitt@gmail.com>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Paolo Sabatino" <paolo.sabatino@gmail.com>
Subject: Re: [PATCH v2 6/8] dt-bindings: auxdisplay: add Titan Micro Electronics TM16XX
Date: Wed, 2 Jul 2025 17:07:07 +0200 [thread overview]
Message-ID: <42a3fcf1-961b-40de-a9be-e05d0cbb52ee@kernel.org> (raw)
In-Reply-To: <daa343f9-b5eb-4a46-8c3a-f5c07603a9f1@kernel.org>
On 02/07/2025 17:02, Krzysztof Kozlowski wrote:
>>
>> if:
>> properties:
>> compatible:
>> contains:
>> enum:
>> - titanmec,tm1618
>> - titanmec,tm1620
>> - titanmec,tm1628
>> - fdhisi,fd620
>> - fdhisi,fd628
>> - winrise,hbs658
>> then:
>> allOf:
>> - $ref: /schemas/spi/spi-peripheral-props.yaml#
>
> Why is this conditional? Are these devices with entirely different
> programming model? Then they usually should not be in the same binding,
> although depends on differences.
Although I looked again at driver and I think I understand - some of
these do not have SPI interface. Then fine, just put it in allOf:
allOf:
- if:
...
then:
$ref: ...
Some other example for that:
https://elixir.bootlin.com/linux/v5.19/source/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml#L152
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-07-02 15:07 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-29 12:59 [PATCH v2 0/8] auxdisplay: Add TM16xx and compatible LED display controllers driver Jean-François Lessard
2025-06-29 12:59 ` Jean-François Lessard
2025-06-29 12:59 ` [PATCH v2 1/8] dt-bindings: vendor-prefixes: Add Fuda Hisi Microelectronics Jean-François Lessard
2025-06-29 12:59 ` [PATCH v2 2/8] dt-bindings: vendor-prefixes: Add Titan Micro Electronics Jean-François Lessard
2025-06-29 12:59 ` [PATCH v2 3/8] dt-bindings: vendor-prefixes: Add Princeton Technology Corp Jean-François Lessard
2025-07-03 7:32 ` Krzysztof Kozlowski
2025-07-03 8:13 ` Geert Uytterhoeven
2025-06-29 12:59 ` [PATCH v2 4/8] dt-bindings: vendor-prefixes: Add Winrise Technology Jean-François Lessard
2025-06-30 12:25 ` Krzysztof Kozlowski
2025-06-30 13:51 ` Christian Hewitt
2025-07-02 20:14 ` Krzysztof Kozlowski
2025-07-03 0:50 ` Jean-François Lessard
2025-06-29 12:59 ` [PATCH v2 5/8] dt-bindings: vendor-prefixes: Add Wuxi i-Core Electronics Jean-François Lessard
2025-06-30 6:07 ` Krzysztof Kozlowski
2025-06-30 8:19 ` Geert Uytterhoeven
2025-06-30 8:31 ` Christian Hewitt
2025-06-30 8:38 ` Geert Uytterhoeven
2025-06-30 12:24 ` Krzysztof Kozlowski
2025-06-30 13:53 ` Christian Hewitt
2025-06-29 12:59 ` [PATCH v2 6/8] dt-bindings: auxdisplay: add Titan Micro Electronics TM16XX Jean-François Lessard
2025-06-30 6:19 ` Krzysztof Kozlowski
2025-07-01 3:22 ` Jean-François Lessard
2025-07-02 15:02 ` Krzysztof Kozlowski
2025-07-02 15:07 ` Krzysztof Kozlowski [this message]
2025-07-02 17:30 ` Jean-François Lessard
2025-07-03 0:33 ` Jean-François Lessard
2025-07-03 7:33 ` Krzysztof Kozlowski
2025-06-29 13:18 ` [PATCH v2 7/8] auxdisplay: Add Titanmec TM16xx 7-segment display controllers driver Jean-François Lessard
2025-06-30 6:12 ` Krzysztof Kozlowski
2025-06-30 7:27 ` Andy Shevchenko
2025-06-30 9:27 ` Krzysztof Kozlowski
2025-06-30 9:54 ` Andy Shevchenko
2025-06-30 11:39 ` Krzysztof Kozlowski
2025-06-30 14:17 ` Andy Shevchenko
2025-07-02 15:05 ` Krzysztof Kozlowski
2025-07-02 15:19 ` Andy Shevchenko
2025-07-03 20:49 ` Miguel Ojeda
2025-07-04 8:23 ` Krzysztof Kozlowski
2025-07-04 9:26 ` Miguel Ojeda
2025-07-01 1:02 ` Jean-François Lessard
2025-07-01 1:32 ` kernel test robot
2025-06-29 13:19 ` [PATCH v2 8/8] MAINTAINERS: Add entry for TM16xx driver Jean-François Lessard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42a3fcf1-961b-40de-a9be-e05d0cbb52ee@kernel.org \
--to=krzk@kernel.org \
--cc=afaerber@suse.de \
--cc=andy@kernel.org \
--cc=boris.gjenero@gmail.com \
--cc=christianshewitt@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=hkallweit1@gmail.com \
--cc=jefflessard3@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=paolo.sabatino@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).