From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Subject: Re: [PATCH v5 2/6] leds: triggers: Add a keyboard backlight trigger Date: Mon, 21 Nov 2016 11:16:00 +0100 Message-ID: <42d20332-8f81-47cd-dd10-6e9ed5123169@redhat.com> References: <20161117222441.31464-1-hdegoede@redhat.com> <55cdf83d-2233-151f-08e1-11d4619e8fd5@redhat.com> <7b8252c4-bb2a-01dd-2404-9b81c192fb6a@gmail.com> <201611201605.17631@pali> <2e1ddcc3-489d-bab1-ebb9-dad02db7b37c@redhat.com> <20161121101209.GC13735@pali> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Return-path: Received: from mx1.redhat.com ([209.132.183.28]:53262 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752332AbcKUKQE (ORCPT ); Mon, 21 Nov 2016 05:16:04 -0500 In-Reply-To: <20161121101209.GC13735@pali> Sender: linux-leds-owner@vger.kernel.org List-Id: linux-leds@vger.kernel.org To: =?UTF-8?Q?Pali_Roh=c3=a1r?= Cc: Jacek Anaszewski , Jacek Anaszewski , Darren Hart , Matthew Garrett , Henrique de Moraes Holschuh , Richard Purdie , ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-leds@vger.kernel.org, Pavel Machek Hi, On 21-11-16 11:12, Pali Rohár wrote: > On Monday 21 November 2016 10:31:33 Hans de Goede wrote: >> Pali, I'm sorry that you don't like the LED side design, but there >> has been a long discussion about this (which you apparently missed) >> and this really is the best way forward. > > Yea, I thought that I should have missed something as I was not able to > find all needed information about it in my mailbox. > > Is that discussion somewhere logged/available? That could help to > describe and understand all problems hidden behind. > >> Have you looked at what the new design means for the platform/x86 >> patches ? Gone is the ugly dell_laptop_notifier as the event >> forwarding between dell-wmi and dell-laptop is now handles by >> the led-trigger subsys. > > Yes, I saw that ugly dell_lpatop notifier is not there. If there is some > more information about decision and pro/coins about this approach I > would like to read it before. It is discussed in this thread: https://www.spinics.net/lists/linux-leds/msg07049.html Unfortunately the starter of the thread dropped the Cc: platform-driver-x86@vger.kernel.org the original patch that thread is about had. Regards, Hans