linux-leds.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Marek Behun <marek.behun@nic.cz>, Dan Murphy <dmurphy@ti.com>
Cc: robh+dt@kernel.org, pavel@ucw.cz, rdunlap@infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-leds@vger.kernel.org
Subject: Re: [PATCH v2 2/7] dt: bindings: Add multicolor class dt bindings documention
Date: Fri, 12 Apr 2019 20:14:42 +0200	[thread overview]
Message-ID: <4e22f95f-8658-99cd-145e-b96f9e8314f7@gmail.com> (raw)
In-Reply-To: <20190412000707.70f8319f@nic.cz>

Hi Marek,

On 4/12/19 12:07 AM, Marek Behun wrote:
> Hi Dan,
> this probaly was discussed, but I did not follow brightness model
> discussions:
> what will happen if I set yellow by writing into yellow mode
> brightness, and then orange by writing orange model brightness?
> Will the resulting color be a mix of yellow and orange, or will the
> orange overwrite the yellow setting?

Orange will overwrite yellow settings. When color name is given
it should be treated as a hue. Then changing brightness level
should affect the lightness of a hue, similarly like changing
L component of HSL color model. This will be however entirely
up to DT brightness-model designer how they will design their models.
We are not going to verify that in the LED multi color class.

It implies that it will be possible to define arbitrary range
of color levels, not necessarily adhering to any established color
model. I think it could be useful to define brightness model
that allows to go from blue color (for cold) up to red (hot)
for representing a temperature for instance.

These ideas will need however more documentation. Generally
we aim to propose only a convention.

-- 
Best regards,
Jacek Anaszewski

  parent reply	other threads:[~2019-04-12 18:14 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-11 19:38 [PATCH v2 0/7] Multicolor Framework Dan Murphy
2019-04-11 19:38 ` [PATCH v2 1/7] leds: multicolor: Add sysfs interface definition Dan Murphy
2019-04-11 19:38 ` [PATCH v2 2/7] dt: bindings: Add multicolor class dt bindings documention Dan Murphy
2019-04-11 22:07   ` Marek Behun
2019-04-12 11:50     ` Dan Murphy
2019-04-12 19:10       ` Jacek Anaszewski
2019-04-12 22:02         ` Dan Murphy
2019-04-13  9:54           ` Jacek Anaszewski
2019-04-12 18:14     ` Jacek Anaszewski [this message]
2019-04-12 18:46       ` Dan Murphy
2019-04-12 19:24         ` Jacek Anaszewski
2019-04-11 19:38 ` [PATCH v2 3/7] documention: leds: Add multicolor class documentation Dan Murphy
2019-04-11 19:38 ` [PATCH v2 4/7] dt-bindings: leds: Add multicolor ID to the color ID list Dan Murphy
2019-04-11 19:38 ` [PATCH v2 5/7] leds: multicolor: Introduce a multicolor class definition Dan Murphy
2019-04-11 19:38 ` [PATCH v2 6/7] dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers Dan Murphy
2019-04-11 20:54   ` Dan Murphy
2019-04-29 21:15   ` Rob Herring
2019-04-11 19:38 ` [PATCH v2 7/7] leds: lp50xx: Add the LP50XX family of the RGB LED driver Dan Murphy
2019-04-11 20:53   ` Dan Murphy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4e22f95f-8658-99cd-145e-b96f9e8314f7@gmail.com \
    --to=jacek.anaszewski@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmurphy@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=marek.behun@nic.cz \
    --cc=pavel@ucw.cz \
    --cc=rdunlap@infradead.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).