From: Bevan Weiss <bevan.weiss@gmail.com>
To: Lee Jones <lee@kernel.org>
Cc: Pavel Machek <pavel@kernel.org>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] leds: syscon: Add tristate option
Date: Mon, 6 Apr 2026 13:49:07 +1000 [thread overview]
Message-ID: <51b03477-8007-4d43-aa09-39b80dec931a@gmail.com> (raw)
In-Reply-To: <20260319223335.5e1913a4@openwrt-virtual-machine>
On 19/03/2026 10:33 pm, Bevan Weiss wrote:
>>> +MODULE_LICENSE("GPL");
>>
>> The MODULE_LICENSE() string should match the SPDX identifier at the
>> top of the file.
>>
>
> Sorry, I'm not quite understanding this in the context of other files.
> Most modules within the led subsystem seem to have
> 'GPL-2.0-or-later' as the SPDX identifier, and MODULE_LICENSE("GPL"),
> as I currently have here.
> Is there a different subtlety I'm missing?
> e.g. leds-adp5520.c, leds-as3668.c, leds-blinkm.c
> Perhaps MODULE_LICENSE("GPL v2+")? although I don't see similar
> anywhere in the kernel.
> I'd expect MODULE_LICENSE("GPL v2") to be for 'GPL-2.0-only' licenses.
>
I've got a v3 mostly ready to send, but was hoping for resolution of the
MODULE_LICENSE query before submitting.
Can I proceed with MODULE_LICENSE("GPL")?
If not, what value should be here?
Regards,
Bevan Weiss
next prev parent reply other threads:[~2026-04-06 3:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-08 1:58 [PATCH v2 0/1] leds: syscon: Add tristate option Bevan Weiss
2026-03-08 1:58 ` [PATCH v2 1/1] " Bevan Weiss
2026-03-19 10:13 ` Lee Jones
2026-03-19 11:33 ` Bevan Weiss
2026-04-06 3:49 ` Bevan Weiss [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-03-08 1:56 [PATCH v2 0/1] " Bevan Weiss
2026-03-08 1:56 ` [PATCH v2 1/1] " Bevan Weiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51b03477-8007-4d43-aa09-39b80dec931a@gmail.com \
--to=bevan.weiss@gmail.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox