From: Chanwoo Choi <cw00.choi@samsung.com>
To: Robert Baldyga <r.baldyga@samsung.com>
Cc: sameo@linux.intel.com, lee.jones@linaro.org,
myungjoo.ham@samsung.com, dmitry.torokhov@gmail.com,
cooloney@gmail.com, rpurdie@rpsys.net, dbaryshkov@gmail.com,
dwmw2@infradead.org, lgirdwood@gmail.com, broonie@kernel.org,
a.zummo@towertech.it, paul.gortmaker@windriver.com,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
linux-leds@vger.kernel.org, rtc-linux@googlegroups.com,
m.szyprowski@samsung.com, k.kozlowski@samsung.com
Subject: Re: [PATCH v2 2/3] mfd: max8997: handle IRQs using regmap
Date: Thu, 13 Mar 2014 17:03:50 +0900 [thread overview]
Message-ID: <53216666.4080500@samsung.com> (raw)
In-Reply-To: <53216272.7050304@samsung.com>
Hi Robert,
On 03/13/2014 04:46 PM, Robert Baldyga wrote:
> Hi,
> On 03/13/2014 03:03 AM, Chanwoo Choi wrote:
>> Hi Robert,
>>
>> On 03/12/2014 10:37 PM, Robert Baldyga wrote:
>>> This patch modifies mfd driver to use regmap for handling interrupts.
>>> It allows to simplify irq handling process. This modifications needed
>>> to make small changes in function drivers, which use interrupts.
>>>
>>> Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
>>> ---
>>> drivers/extcon/extcon-max8997.c | 35 ++--
>>> drivers/mfd/Kconfig | 2 +-
>>> drivers/mfd/Makefile | 2 +-
>>> drivers/mfd/max8997-irq.c | 373 -----------------------------------
>>> drivers/mfd/max8997.c | 113 ++++++++++-
>>> drivers/rtc/rtc-max8997.c | 2 +-
>>> include/linux/mfd/max8997-private.h | 65 +++++-
>>> 7 files changed, 183 insertions(+), 409 deletions(-)
>>> delete mode 100644 drivers/mfd/max8997-irq.c
>>>
>>> diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c
>>> index f258c08..15fc5c0 100644
>>> --- a/drivers/extcon/extcon-max8997.c
>>> +++ b/drivers/extcon/extcon-max8997.c
>>> @@ -46,15 +46,15 @@ struct max8997_muic_irq {
>>> };
>>>
>>> static struct max8997_muic_irq muic_irqs[] = {
>>> - { MAX8997_MUICIRQ_ADCError, "muic-ADCERROR" },
>>> - { MAX8997_MUICIRQ_ADCLow, "muic-ADCLOW" },
>>> - { MAX8997_MUICIRQ_ADC, "muic-ADC" },
>>> - { MAX8997_MUICIRQ_VBVolt, "muic-VBVOLT" },
>>> - { MAX8997_MUICIRQ_DBChg, "muic-DBCHG" },
>>> - { MAX8997_MUICIRQ_DCDTmr, "muic-DCDTMR" },
>>> - { MAX8997_MUICIRQ_ChgDetRun, "muic-CHGDETRUN" },
>>> - { MAX8997_MUICIRQ_ChgTyp, "muic-CHGTYP" },
>>> - { MAX8997_MUICIRQ_OVP, "muic-OVP" },
>>> + { MAX8997_MUICIRQ_ADCERROR, "MUIC-ADCERROR" },
>>> + { MAX8997_MUICIRQ_ADCLOW, "MUIC-ADCLOW" },
>>> + { MAX8997_MUICIRQ_ADC, "MUIC-ADC" },
>>> + { MAX8997_MUICIRQ_VBVOLT, "MUIC-VBVOLT" },
>>> + { MAX8997_MUICIRQ_DBCHG, "MUIC-DBCHG" },
>>> + { MAX8997_MUICIRQ_DCDTMR, "MUIC-DCDTMR" },
>>> + { MAX8997_MUICIRQ_CHGDETRUN, "MUIC-CHGDETRUN" },
>>> + { MAX8997_MUICIRQ_CHGTYP, "MUIC-CHGTYP" },
>>> + { MAX8997_MUICIRQ_OVP, "MUIC-OVP" },
>>> };
>>
>>
>> Why did you modify interrput name? Did you have some reason?
>> I think this modification don't need it.
>
> I did it to have one naming convention in max8997-private.h file. Any
> other interrupt names uses upper case, but MUIC iqr's from some reason
> uses CamelCase. I think it's much better to have consistent style in
> entire file.
If you want to modify interrupt name, I think you better separate patch for
this modification. This patch handle only regmap according to the title of this patch.
Thanks,
Chanwoo Choi
next prev parent reply other threads:[~2014-03-13 8:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 13:37 [PATCH v2 0/3] mfd: max8997: add regmap support Robert Baldyga
2014-03-12 13:37 ` [PATCH v2 1/3] mfd: max8997: use regmap to access registers Robert Baldyga
2014-03-12 14:24 ` Krzysztof Kozlowski
2014-03-12 13:37 ` [PATCH v2 2/3] mfd: max8997: handle IRQs using regmap Robert Baldyga
2014-03-12 14:26 ` Krzysztof Kozlowski
2014-03-13 2:03 ` Chanwoo Choi
2014-03-13 7:46 ` Robert Baldyga
2014-03-13 8:00 ` Lee Jones
2014-03-13 8:03 ` Chanwoo Choi [this message]
2014-03-12 13:37 ` [PATCH v2 3/3] mfd: max8997: move regmap handling to function drivers Robert Baldyga
2014-03-12 15:11 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53216666.4080500@samsung.com \
--to=cw00.choi@samsung.com \
--cc=a.zummo@towertech.it \
--cc=broonie@kernel.org \
--cc=cooloney@gmail.com \
--cc=dbaryshkov@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=k.kozlowski@samsung.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=myungjoo.ham@samsung.com \
--cc=paul.gortmaker@windriver.com \
--cc=r.baldyga@samsung.com \
--cc=rpurdie@rpsys.net \
--cc=rtc-linux@googlegroups.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).