From: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
To: Bryan Wu <cooloney@gmail.com>,
Fabio Estevam <fabio.estevam@freescale.com>
Cc: Grant Likely <grant.likely@linaro.org>,
Jean-Michel Hautbois <jean-michel.hautbois@vodalys.com>,
Fabio Estevam <festevam@gmail.com>,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] leds: leds-gpio: Fix the "default-state" property check
Date: Wed, 10 Dec 2014 02:12:40 +0100 [thread overview]
Message-ID: <54879E08.7030108@intel.com> (raw)
In-Reply-To: <CAK5ve-KHd86BxLhk=JC6vspgE7E_W3A3ArrjHsGp41_iuke7fA@mail.gmail.com>
On 12/9/2014 8:13 PM, Bryan Wu wrote:
> On Tue, Dec 9, 2014 at 8:31 AM, Fabio Estevam
> <fabio.estevam@freescale.com> wrote:
>> Commit a43f2cbbb009f9 ("leds: leds-gpio: Make use of device property API")
>> caused a regression by reading the incorrect string for the "default-state"
>> property.
>>
>> Fix the property string check to restore the original behaviour.
>>
>> Fixes: a43f2cbbb009 (leds: leds-gpio: Make use of device property API)
> Thanks, please take my Ack
> Acked-by: Bryan Wu <cooloney@gmail.com>
>
> I think Rafael will take this fix with other patches through his tree.
Yes, I will, thanks!
And sorry for the breakage ...
>
>> Reported-by: Jean-Michel Hautbois <jean-michel.hautbois@vodalys.com>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>> ---
>> drivers/leds/leds-gpio.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c
>> index 8a8ba11..7ea1ea42 100644
>> --- a/drivers/leds/leds-gpio.c
>> +++ b/drivers/leds/leds-gpio.c
>> @@ -203,7 +203,7 @@ static struct gpio_leds_priv *gpio_leds_create(struct platform_device *pdev)
>> fwnode_property_read_string(child, "linux,default-trigger",
>> &led.default_trigger);
>>
>> - if (!fwnode_property_read_string(child, "linux,default_state",
>> + if (!fwnode_property_read_string(child, "default-state",
>> &state)) {
>> if (!strcmp(state, "keep"))
>> led.default_state = LEDS_GPIO_DEFSTATE_KEEP;
>> --
>> 1.9.1
>>
prev parent reply other threads:[~2014-12-10 1:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-09 16:31 [PATCH] leds: leds-gpio: Fix the "default-state" property check Fabio Estevam
2014-12-09 19:13 ` Bryan Wu
2014-12-10 1:12 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54879E08.7030108@intel.com \
--to=rafael.j.wysocki@intel.com \
--cc=cooloney@gmail.com \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=grant.likely@linaro.org \
--cc=jean-michel.hautbois@vodalys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).