* [PATCH -next] leds: fix aat1290 build errors
@ 2015-06-26 19:00 Randy Dunlap
2015-06-29 14:44 ` Jacek Anaszewski
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2015-06-26 19:00 UTC (permalink / raw)
To: LKML, linux-leds; +Cc: Jacek Anaszewski, Bryan Wu, Richard Purdie
From: Randy Dunlap <rdunlap@infradead.org>
Fix build errors when LEDS_AAT1290=y and V4L2_FLASH_LED_CLASS=m
by restricting LEDS_AAT1290 to =m if V4L2_FLASH_LED_CLASS=m.
drivers/built-in.o: In function `aat1290_led_remove':
leds-aat1290.c:(.text+0xe5d77): undefined reference to `v4l2_flash_release'
drivers/built-in.o: In function `aat1290_led_probe':
leds-aat1290.c:(.text+0xe6494): undefined reference to `v4l2_flash_init'
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Jacek Anaszewski <j.anaszewski@samsung.com>
Cc: Bryan Wu <cooloney@gmail.com>
Cc: Richard Purdie <rpurdie@rpsys.net>
---
drivers/leds/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20150626.orig/drivers/leds/Kconfig
+++ linux-next-20150626/drivers/leds/Kconfig
@@ -42,6 +42,7 @@ config LEDS_88PM860X
config LEDS_AAT1290
tristate "LED support for the AAT1290"
depends on LEDS_CLASS_FLASH
+ depends on V4L2_FLASH_LED_CLASS || !V4L2_FLASH_LED_CLASS
depends on GPIOLIB
depends on OF
depends on PINCTRL
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] leds: fix aat1290 build errors
2015-06-26 19:00 [PATCH -next] leds: fix aat1290 build errors Randy Dunlap
@ 2015-06-29 14:44 ` Jacek Anaszewski
2015-06-29 17:08 ` Bryan Wu
0 siblings, 1 reply; 3+ messages in thread
From: Jacek Anaszewski @ 2015-06-29 14:44 UTC (permalink / raw)
To: Randy Dunlap; +Cc: LKML, linux-leds, Bryan Wu, Richard Purdie
Hi Randy,
Thanks for the patch.
On 06/26/2015 09:00 PM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix build errors when LEDS_AAT1290=y and V4L2_FLASH_LED_CLASS=m
> by restricting LEDS_AAT1290 to =m if V4L2_FLASH_LED_CLASS=m.
>
> drivers/built-in.o: In function `aat1290_led_remove':
> leds-aat1290.c:(.text+0xe5d77): undefined reference to `v4l2_flash_release'
> drivers/built-in.o: In function `aat1290_led_probe':
> leds-aat1290.c:(.text+0xe6494): undefined reference to `v4l2_flash_init'
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Jacek Anaszewski <j.anaszewski@samsung.com>
> Cc: Bryan Wu <cooloney@gmail.com>
> Cc: Richard Purdie <rpurdie@rpsys.net>
> ---
> drivers/leds/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20150626.orig/drivers/leds/Kconfig
> +++ linux-next-20150626/drivers/leds/Kconfig
> @@ -42,6 +42,7 @@ config LEDS_88PM860X
> config LEDS_AAT1290
> tristate "LED support for the AAT1290"
> depends on LEDS_CLASS_FLASH
> + depends on V4L2_FLASH_LED_CLASS || !V4L2_FLASH_LED_CLASS
> depends on GPIOLIB
> depends on OF
> depends on PINCTRL
>
Acked-by: Jacek Anaszewski <j.anaszewski@samsung.com>
--
Best Regards,
Jacek Anaszewski
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] leds: fix aat1290 build errors
2015-06-29 14:44 ` Jacek Anaszewski
@ 2015-06-29 17:08 ` Bryan Wu
0 siblings, 0 replies; 3+ messages in thread
From: Bryan Wu @ 2015-06-29 17:08 UTC (permalink / raw)
To: Jacek Anaszewski; +Cc: Randy Dunlap, LKML, Linux LED Subsystem, Richard Purdie
On Mon, Jun 29, 2015 at 7:44 AM, Jacek Anaszewski
<j.anaszewski@samsung.com> wrote:
> Hi Randy,
>
> Thanks for the patch.
>
>
> On 06/26/2015 09:00 PM, Randy Dunlap wrote:
>>
>> From: Randy Dunlap <rdunlap@infradead.org>
>>
>> Fix build errors when LEDS_AAT1290=y and V4L2_FLASH_LED_CLASS=m
>> by restricting LEDS_AAT1290 to =m if V4L2_FLASH_LED_CLASS=m.
>>
>> drivers/built-in.o: In function `aat1290_led_remove':
>> leds-aat1290.c:(.text+0xe5d77): undefined reference to
>> `v4l2_flash_release'
>> drivers/built-in.o: In function `aat1290_led_probe':
>> leds-aat1290.c:(.text+0xe6494): undefined reference to `v4l2_flash_init'
>>
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Jacek Anaszewski <j.anaszewski@samsung.com>
>> Cc: Bryan Wu <cooloney@gmail.com>
>> Cc: Richard Purdie <rpurdie@rpsys.net>
>> ---
>> drivers/leds/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> --- linux-next-20150626.orig/drivers/leds/Kconfig
>> +++ linux-next-20150626/drivers/leds/Kconfig
>> @@ -42,6 +42,7 @@ config LEDS_88PM860X
>> config LEDS_AAT1290
>> tristate "LED support for the AAT1290"
>> depends on LEDS_CLASS_FLASH
>> + depends on V4L2_FLASH_LED_CLASS || !V4L2_FLASH_LED_CLASS
>> depends on GPIOLIB
>> depends on OF
>> depends on PINCTRL
>>
>
> Acked-by: Jacek Anaszewski <j.anaszewski@samsung.com>
>
Good fix. thanks.
I merged into my tree.
-Bryan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-06-29 17:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-26 19:00 [PATCH -next] leds: fix aat1290 build errors Randy Dunlap
2015-06-29 14:44 ` Jacek Anaszewski
2015-06-29 17:08 ` Bryan Wu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).