From: Jacek Anaszewski <j.anaszewski@samsung.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-leds@vger.kernel.org, Bryan Wu <cooloney@gmail.com>,
Richard Purdie <rpurdie@rpsys.net>
Subject: Re: [PATCH -next] leds: fix aat1290 build errors
Date: Mon, 29 Jun 2015 16:44:18 +0200 [thread overview]
Message-ID: <559159C2.40305@samsung.com> (raw)
In-Reply-To: <558DA144.6050203@infradead.org>
Hi Randy,
Thanks for the patch.
On 06/26/2015 09:00 PM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix build errors when LEDS_AAT1290=y and V4L2_FLASH_LED_CLASS=m
> by restricting LEDS_AAT1290 to =m if V4L2_FLASH_LED_CLASS=m.
>
> drivers/built-in.o: In function `aat1290_led_remove':
> leds-aat1290.c:(.text+0xe5d77): undefined reference to `v4l2_flash_release'
> drivers/built-in.o: In function `aat1290_led_probe':
> leds-aat1290.c:(.text+0xe6494): undefined reference to `v4l2_flash_init'
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Jacek Anaszewski <j.anaszewski@samsung.com>
> Cc: Bryan Wu <cooloney@gmail.com>
> Cc: Richard Purdie <rpurdie@rpsys.net>
> ---
> drivers/leds/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20150626.orig/drivers/leds/Kconfig
> +++ linux-next-20150626/drivers/leds/Kconfig
> @@ -42,6 +42,7 @@ config LEDS_88PM860X
> config LEDS_AAT1290
> tristate "LED support for the AAT1290"
> depends on LEDS_CLASS_FLASH
> + depends on V4L2_FLASH_LED_CLASS || !V4L2_FLASH_LED_CLASS
> depends on GPIOLIB
> depends on OF
> depends on PINCTRL
>
Acked-by: Jacek Anaszewski <j.anaszewski@samsung.com>
--
Best Regards,
Jacek Anaszewski
next prev parent reply other threads:[~2015-06-29 14:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-26 19:00 [PATCH -next] leds: fix aat1290 build errors Randy Dunlap
2015-06-29 14:44 ` Jacek Anaszewski [this message]
2015-06-29 17:08 ` Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559159C2.40305@samsung.com \
--to=j.anaszewski@samsung.com \
--cc=cooloney@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).