From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jacek Anaszewski Subject: Re: [PATCH] leds: leds-ot200: Use devm_led_classdev_register Date: Mon, 07 Sep 2015 09:49:01 +0200 Message-ID: <55ED416D.2000408@samsung.com> References: <1441463007-15638-1-git-send-email-falakreyaz@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mailout2.w1.samsung.com ([210.118.77.12]:50050 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751427AbbIGHtD (ORCPT ); Mon, 7 Sep 2015 03:49:03 -0400 In-reply-to: <1441463007-15638-1-git-send-email-falakreyaz@gmail.com> Sender: linux-leds-owner@vger.kernel.org List-Id: linux-leds@vger.kernel.org To: Muhammad Falak R Wani Cc: Bryan Wu , Richard Purdie , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org On 09/05/2015 04:23 PM, Muhammad Falak R Wani wrote: > Use resource-managed function devm_led_classdev_register > instead of led_classdev_register to make the error path simpler. > The goto is replaced with direct return, unneeded label err is > dropped. Also, remove redundant ot200_led_remove. > > Signed-off-by: Muhammad Falak R Wani > --- > drivers/leds/leds-ot200.c | 21 ++------------------- > 1 file changed, 2 insertions(+), 19 deletions(-) Merged, thanks. -- Best Regards, Jacek Anaszewski