* [PATCH] leds: leds-ot200: Use devm_led_classdev_register
@ 2015-09-05 14:23 Muhammad Falak R Wani
2015-09-07 7:49 ` Jacek Anaszewski
0 siblings, 1 reply; 2+ messages in thread
From: Muhammad Falak R Wani @ 2015-09-05 14:23 UTC (permalink / raw)
To: Bryan Wu, Richard Purdie, Jacek Anaszewski, linux-leds
Cc: linux-kernel, Muhammad Falak R Wani
Use resource-managed function devm_led_classdev_register
instead of led_classdev_register to make the error path simpler.
The goto is replaced with direct return, unneeded label err is
dropped. Also, remove redundant ot200_led_remove.
Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
---
drivers/leds/leds-ot200.c | 21 ++-------------------
1 file changed, 2 insertions(+), 19 deletions(-)
diff --git a/drivers/leds/leds-ot200.c b/drivers/leds/leds-ot200.c
index 39870de..12af112 100644
--- a/drivers/leds/leds-ot200.c
+++ b/drivers/leds/leds-ot200.c
@@ -124,9 +124,9 @@ static int ot200_led_probe(struct platform_device *pdev)
leds[i].cdev.name = leds[i].name;
leds[i].cdev.brightness_set = ot200_led_brightness_set;
- ret = led_classdev_register(&pdev->dev, &leds[i].cdev);
+ ret = devm_led_classdev_register(&pdev->dev, &leds[i].cdev);
if (ret < 0)
- goto err;
+ return ret;
}
leds_front = 0; /* turn off all front leds */
@@ -135,27 +135,10 @@ static int ot200_led_probe(struct platform_device *pdev)
outb(leds_back, 0x5a);
return 0;
-
-err:
- for (i = i - 1; i >= 0; i--)
- led_classdev_unregister(&leds[i].cdev);
-
- return ret;
-}
-
-static int ot200_led_remove(struct platform_device *pdev)
-{
- int i;
-
- for (i = 0; i < ARRAY_SIZE(leds); i++)
- led_classdev_unregister(&leds[i].cdev);
-
- return 0;
}
static struct platform_driver ot200_led_driver = {
.probe = ot200_led_probe,
- .remove = ot200_led_remove,
.driver = {
.name = "leds-ot200",
},
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] leds: leds-ot200: Use devm_led_classdev_register
2015-09-05 14:23 [PATCH] leds: leds-ot200: Use devm_led_classdev_register Muhammad Falak R Wani
@ 2015-09-07 7:49 ` Jacek Anaszewski
0 siblings, 0 replies; 2+ messages in thread
From: Jacek Anaszewski @ 2015-09-07 7:49 UTC (permalink / raw)
To: Muhammad Falak R Wani; +Cc: Bryan Wu, Richard Purdie, linux-leds, linux-kernel
On 09/05/2015 04:23 PM, Muhammad Falak R Wani wrote:
> Use resource-managed function devm_led_classdev_register
> instead of led_classdev_register to make the error path simpler.
> The goto is replaced with direct return, unneeded label err is
> dropped. Also, remove redundant ot200_led_remove.
>
> Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
> ---
> drivers/leds/leds-ot200.c | 21 ++-------------------
> 1 file changed, 2 insertions(+), 19 deletions(-)
Merged, thanks.
--
Best Regards,
Jacek Anaszewski
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-09-07 7:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-05 14:23 [PATCH] leds: leds-ot200: Use devm_led_classdev_register Muhammad Falak R Wani
2015-09-07 7:49 ` Jacek Anaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).