From: Jacek Anaszewski <j.anaszewski@samsung.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Jingoo Han <jingoohan1@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
linux-leds@vger.kernel.org, linux-fbdev@vger.kernel.org,
Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH 1/3] leds: Add of_led_get() and led_put()
Date: Mon, 07 Sep 2015 16:10:14 +0200 [thread overview]
Message-ID: <55ED9AC6.3020505@samsung.com> (raw)
In-Reply-To: <55ED8E99.9060004@ti.com>
On 09/07/2015 03:18 PM, Tomi Valkeinen wrote:
> Hi,
>
> On 25/08/15 16:25, Jacek Anaszewski wrote:
>> Hi Tomi,
>>
>> Thanks for the patch. Generally, I'd prefer to add files
>> drivers/leds/of.c and include/linux/of_leds.h and put related functions
>> there. Those functions' names should begin with "of_". Please provide
>
> So I presume leds/of.c should be linked together with led-class.c.
> Afaics, that means I need to either rename the resulting led-class.ko or
> led-class.c, so that I can do it in the Makefile. Any preferences?
Let's rename led-class.ko to led-class-objs.ko.
> Alternatively I could create a led-of.ko, but that doesn't feel right.
--
Best Regards,
Jacek Anaszewski
next prev parent reply other threads:[~2015-09-07 14:10 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-25 11:33 [PATCH 0/3] backlight: led-backlight driver Tomi Valkeinen
2015-08-25 11:34 ` [PATCH 1/3] leds: Add of_led_get() and led_put() Tomi Valkeinen
2015-08-25 12:18 ` Andrew Lunn
2015-08-25 12:53 ` Tomi Valkeinen
2015-09-08 11:23 ` Tomi Valkeinen
2015-08-25 13:25 ` Jacek Anaszewski
2015-09-07 12:35 ` Tomi Valkeinen
2015-09-07 14:11 ` Jacek Anaszewski
2015-09-08 7:10 ` Tomi Valkeinen
2015-09-08 9:21 ` Jacek Anaszewski
2015-09-08 10:41 ` Tomi Valkeinen
2015-09-08 10:57 ` Jacek Anaszewski
2015-09-07 13:18 ` Tomi Valkeinen
2015-09-07 14:10 ` Jacek Anaszewski [this message]
2015-08-25 11:34 ` [PATCH 2/3] backlight: add led-backlight driver Tomi Valkeinen
2015-08-25 12:39 ` Andrew Lunn
2015-08-25 13:00 ` Tomi Valkeinen
2015-08-25 11:34 ` [PATCH 3/3] devicetree: Add led-backlight binding Tomi Valkeinen
2015-08-25 13:39 ` Jacek Anaszewski
2015-08-25 15:41 ` Tomi Valkeinen
2015-08-26 7:07 ` Jacek Anaszewski
2015-08-26 9:11 ` Tomi Valkeinen
2015-08-26 9:56 ` Jacek Anaszewski
2015-08-31 23:12 ` Rob Herring
2015-09-04 15:03 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55ED9AC6.3020505@samsung.com \
--to=j.anaszewski@samsung.com \
--cc=andrew@lunn.ch \
--cc=jingoohan1@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).