* [PATCH] leds: leds-locomo.c: Use devm_led_classdev_register
@ 2015-10-16 21:33 Fida Mohammad
2015-10-19 8:16 ` Jacek Anaszewski
0 siblings, 1 reply; 2+ messages in thread
From: Fida Mohammad @ 2015-10-16 21:33 UTC (permalink / raw)
To: Bryan Wu, Richard Purdie, Jacek Anaszewski, linux-leds,
linux-kernel
Cc: Fida Mohammad
Use resource managed function devm_led_classdev_register to make
initialisation path simpler.
Also removed redundant led_classdev_unregister function.
Signed-off-by: Fida Mohammad <fmthoker@gmail.com>
---
drivers/leds/leds-locomo.c | 15 ++-------------
1 file changed, 2 insertions(+), 13 deletions(-)
diff --git a/drivers/leds/leds-locomo.c b/drivers/leds/leds-locomo.c
index 80ba048..24c4b53 100644
--- a/drivers/leds/leds-locomo.c
+++ b/drivers/leds/leds-locomo.c
@@ -59,23 +59,13 @@ static int locomoled_probe(struct locomo_dev *ldev)
{
int ret;
- ret = led_classdev_register(&ldev->dev, &locomo_led0);
+ ret = devm_led_classdev_register(&ldev->dev, &locomo_led0);
if (ret < 0)
return ret;
- ret = led_classdev_register(&ldev->dev, &locomo_led1);
- if (ret < 0)
- led_classdev_unregister(&locomo_led0);
-
- return ret;
+ return devm_led_classdev_register(&ldev->dev, &locomo_led1);
}
-static int locomoled_remove(struct locomo_dev *dev)
-{
- led_classdev_unregister(&locomo_led0);
- led_classdev_unregister(&locomo_led1);
- return 0;
-}
static struct locomo_driver locomoled_driver = {
.drv = {
@@ -83,7 +73,6 @@ static struct locomo_driver locomoled_driver = {
},
.devid = LOCOMO_DEVID_LED,
.probe = locomoled_probe,
- .remove = locomoled_remove,
};
static int __init locomoled_init(void)
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] leds: leds-locomo.c: Use devm_led_classdev_register
2015-10-16 21:33 [PATCH] leds: leds-locomo.c: Use devm_led_classdev_register Fida Mohammad
@ 2015-10-19 8:16 ` Jacek Anaszewski
0 siblings, 0 replies; 2+ messages in thread
From: Jacek Anaszewski @ 2015-10-19 8:16 UTC (permalink / raw)
To: Fida Mohammad; +Cc: Bryan Wu, Richard Purdie, linux-leds, linux-kernel
Hi Fida,
On 10/16/2015 11:33 PM, Fida Mohammad wrote:
> Use resource managed function devm_led_classdev_register to make
> initialisation path simpler.
> Also removed redundant led_classdev_unregister function.
>
> Signed-off-by: Fida Mohammad <fmthoker@gmail.com>
> ---
> drivers/leds/leds-locomo.c | 15 ++-------------
> 1 file changed, 2 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/leds/leds-locomo.c b/drivers/leds/leds-locomo.c
> index 80ba048..24c4b53 100644
> --- a/drivers/leds/leds-locomo.c
> +++ b/drivers/leds/leds-locomo.c
> @@ -59,23 +59,13 @@ static int locomoled_probe(struct locomo_dev *ldev)
> {
> int ret;
>
> - ret = led_classdev_register(&ldev->dev, &locomo_led0);
> + ret = devm_led_classdev_register(&ldev->dev, &locomo_led0);
> if (ret < 0)
> return ret;
>
> - ret = led_classdev_register(&ldev->dev, &locomo_led1);
> - if (ret < 0)
> - led_classdev_unregister(&locomo_led0);
> -
> - return ret;
> + return devm_led_classdev_register(&ldev->dev, &locomo_led1);
> }
>
> -static int locomoled_remove(struct locomo_dev *dev)
> -{
> - led_classdev_unregister(&locomo_led0);
> - led_classdev_unregister(&locomo_led1);
> - return 0;
> -}
>
> static struct locomo_driver locomoled_driver = {
> .drv = {
> @@ -83,7 +73,6 @@ static struct locomo_driver locomoled_driver = {
> },
> .devid = LOCOMO_DEVID_LED,
> .probe = locomoled_probe,
> - .remove = locomoled_remove,
> };
>
> static int __init locomoled_init(void)
>
Applied, thanks.
--
Best Regards,
Jacek Anaszewski
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-19 8:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-16 21:33 [PATCH] leds: leds-locomo.c: Use devm_led_classdev_register Fida Mohammad
2015-10-19 8:16 ` Jacek Anaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).