* [PATCH] leds: leds-net48xx: Use devm_led_classdev_register
@ 2015-10-16 23:32 Muhammad Falak R Wani
2015-10-19 8:16 ` Jacek Anaszewski
0 siblings, 1 reply; 2+ messages in thread
From: Muhammad Falak R Wani @ 2015-10-16 23:32 UTC (permalink / raw)
To: Chris Boot, Bryan Wu, Richard Purdie, Jacek Anaszewski,
linux-leds, linux-kernel
Cc: Muhammad Falak R Wani
Use devm_led_classdev_register instead of led_classdev_register,
removing the redundant net48xx_led_remove function.
Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
---
drivers/leds/leds-net48xx.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/leds/leds-net48xx.c b/drivers/leds/leds-net48xx.c
index ec3a2e8..0d214c2 100644
--- a/drivers/leds/leds-net48xx.c
+++ b/drivers/leds/leds-net48xx.c
@@ -39,18 +39,11 @@ static struct led_classdev net48xx_error_led = {
static int net48xx_led_probe(struct platform_device *pdev)
{
- return led_classdev_register(&pdev->dev, &net48xx_error_led);
-}
-
-static int net48xx_led_remove(struct platform_device *pdev)
-{
- led_classdev_unregister(&net48xx_error_led);
- return 0;
+ return devm_led_classdev_register(&pdev->dev, &net48xx_error_led);
}
static struct platform_driver net48xx_led_driver = {
.probe = net48xx_led_probe,
- .remove = net48xx_led_remove,
.driver = {
.name = DRVNAME,
},
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] leds: leds-net48xx: Use devm_led_classdev_register
2015-10-16 23:32 [PATCH] leds: leds-net48xx: Use devm_led_classdev_register Muhammad Falak R Wani
@ 2015-10-19 8:16 ` Jacek Anaszewski
0 siblings, 0 replies; 2+ messages in thread
From: Jacek Anaszewski @ 2015-10-19 8:16 UTC (permalink / raw)
To: Muhammad Falak R Wani
Cc: Chris Boot, Bryan Wu, Richard Purdie, linux-leds, linux-kernel
Hi Muhammad,
On 10/17/2015 01:32 AM, Muhammad Falak R Wani wrote:
> Use devm_led_classdev_register instead of led_classdev_register,
> removing the redundant net48xx_led_remove function.
>
> Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
> ---
> drivers/leds/leds-net48xx.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/drivers/leds/leds-net48xx.c b/drivers/leds/leds-net48xx.c
> index ec3a2e8..0d214c2 100644
> --- a/drivers/leds/leds-net48xx.c
> +++ b/drivers/leds/leds-net48xx.c
> @@ -39,18 +39,11 @@ static struct led_classdev net48xx_error_led = {
>
> static int net48xx_led_probe(struct platform_device *pdev)
> {
> - return led_classdev_register(&pdev->dev, &net48xx_error_led);
> -}
> -
> -static int net48xx_led_remove(struct platform_device *pdev)
> -{
> - led_classdev_unregister(&net48xx_error_led);
> - return 0;
> + return devm_led_classdev_register(&pdev->dev, &net48xx_error_led);
> }
>
> static struct platform_driver net48xx_led_driver = {
> .probe = net48xx_led_probe,
> - .remove = net48xx_led_remove,
> .driver = {
> .name = DRVNAME,
> },
>
Applied, thanks.
--
Best Regards,
Jacek Anaszewski
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-19 8:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-16 23:32 [PATCH] leds: leds-net48xx: Use devm_led_classdev_register Muhammad Falak R Wani
2015-10-19 8:16 ` Jacek Anaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).