From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jacek Anaszewski Subject: Re: [PATCH] leds: bcm6328: Handle default-state of LEDs correctly Date: Wed, 28 Oct 2015 11:56:01 +0100 Message-ID: <5630A9C1.5060907@samsung.com> References: <562BB799.7000708@simon.arlott.org.uk> <562DE832.6070903@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-reply-to: Sender: linux-kernel-owner@vger.kernel.org To: Simon Arlott Cc: Richard Purdie , linux-leds@vger.kernel.org, Linux Kernel Mailing List , =?UTF-8?B?w4FsdmFybyBGZXJuw6FuZGV6IFJvamFz?= , Jonas Gorski List-Id: linux-leds@vger.kernel.org Hi Simon, On 10/26/2015 01:36 PM, Simon Arlott wrote: > On Mon, October 26, 2015 08:45, Jacek Anaszewski wrote: >> Hi Simon, >> >> Thanks for the patch. There are conflicts when applying >> it to the LED tree: >> >> git://git.kernel.org/pub/scm/linux/kernel/git/j.anaszewski/linux-leds.git >> >> Please use it as a code base for your LED development. > > This has already been fixed in the devel branch by d19e6b6a0062c86a75365f0715fd079245f6aab9, > although I think bcm6328_led() should adjust its use of the spinlock > to only cover reading the register and call bcm6328_led_set() instead > of copying the code from it. > It is also on the for-next branch. Feel free to submit the patch, if you see the room for improvement. -- Best Regards, Jacek Anaszewski