From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jacek Anaszewski Subject: Re: [PATCH 1/2] leds-bcm6328: Reuse bcm6328_led_set() instead of copying its functionality Date: Mon, 16 Nov 2015 15:38:42 +0100 Message-ID: <5649EA72.20504@samsung.com> References: <562BB799.7000708@simon.arlott.org.uk> <562DE832.6070903@samsung.com> <5630A9C1.5060907@samsung.com> <56327821.8020508@simon.arlott.org.uk> <563A2731.40204@samsung.com> <563A2850.5000506@gmail.com> <563B3240.9010804@samsung.com> <56488968.3070103@simon.arlott.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <56488968.3070103@simon.arlott.org.uk> Sender: linux-kernel-owner@vger.kernel.org To: Simon Arlott Cc: =?UTF-8?B?w4FsdmFybyBGZXJuw6FuZGV6IFJvamFz?= , Jonas Gorski , Richard Purdie , linux-leds@vger.kernel.org, Linux Kernel Mailing List List-Id: linux-leds@vger.kernel.org Hi Simon, On 11/15/2015 02:32 PM, Simon Arlott wrote: > When ensuring a consistent initial LED state in bcm6328_led (as they may > be blinking instead of on/off), the LED register is set using an inverted > copy of bcm6328_led_set(). To avoid further errors relating to active low > handling, call this function directly instead. > > Signed-off-by: Simon Arlott > --- > I've decided not to move the locking as it should really cover the > setting of led->cdev.brightness too (not that it matters as the device > is not yet registered). > > drivers/leds/leds-bcm6328.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/leds/leds-bcm6328.c b/drivers/leds/leds-bcm6328.c > index c7ea5c6..95d0cf9 100644 > --- a/drivers/leds/leds-bcm6328.c > +++ b/drivers/leds/leds-bcm6328.c > @@ -314,14 +314,10 @@ static int bcm6328_led(struct device *dev, struct device_node *nc, u32 reg, > } else { > led->cdev.brightness = LED_OFF; > } > - > - if ((led->active_low && led->cdev.brightness == LED_FULL) || > - (!led->active_low && led->cdev.brightness == LED_OFF)) > - bcm6328_led_mode(led, BCM6328_LED_MODE_ON); > - else > - bcm6328_led_mode(led, BCM6328_LED_MODE_OFF); > spin_unlock_irqrestore(lock, flags); > > + bcm6328_led_set(&led->cdev, led->cdev.brightness); > + You're not protecting bcm6328_led_set with spin_lock here. Please describe why this is not needed in the commit message. > led->cdev.brightness_set = bcm6328_led_set; > led->cdev.blink_set = bcm6328_blink_set; > > -- Best Regards, Jacek Anaszewski