From: "Álvaro Fernández Rojas" <noltari-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Jacek Anaszewski
<j.anaszewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Simon Arlott <simon-A6De1vDTPLDsq35pWSNszA@public.gmane.org>
Cc: linux-leds-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Linux Kernel Mailing List
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: leds-bcm6328: add more init configuration options
Date: Mon, 16 Nov 2015 22:35:55 +0100 [thread overview]
Message-ID: <564A4C3B.6090806@gmail.com> (raw)
In-Reply-To: <5649F040.6090002-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Hi Simon and Jacek,
This is done on purpose because not every BCM63268 device has serial
LEDs and we should be able to enable/disable those options in order to
avoid depending on the bootloader setting the registers correctly.
Regards,
Álvaro.
El 16/11/2015 a las 16:03, Jacek Anaszewski escribió:
> Hi Simon,
>
> On 11/15/2015 06:27 PM, Simon Arlott wrote:
>> commit 1d3ff22d633d35048c35c3deeead7ab116cebc32
>> Author: Álvaro Fernández Rojas <noltari-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> Date: Thu Oct 8 12:35:55 2015 +0200
>>
>> Documentation: leds: update DT bindings for leds-bcm6328
>>
>> This patch adds latest DT bindings for leds-bcm6328 init register
>> configuration.
>>
>> commit 9f82c778ce17789a038351a411ff65cd41033c7a
>> Author: Álvaro Fernández Rojas <noltari-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> Date: Thu Oct 8 12:35:54 2015 +0200
>>
>> leds-bcm6328: add more init configuration options
>>
>> This patch adds more init register configuration options:
>> - Serial LEDs multiplexing.
>> - Serial LEDs clock signal low/high polarity.
>> - Serial LEDs data signal low/high polarity.
>> - Serial LEDs shift direction inverted/normal.
>>
>> This was not a backwards-compatible change, because the driver is now
>> turning off all of the serial LED options by default when previously
>> it only turned off brcm,serial-leds and left the other options
>> unchanged.
>>
>> There are currently no in-tree users of this binding, so any existing
>> users will be broken by this change.
>>
>
> Please submit a patch fixing the issue in such cases, so that we could
> discuss possible solutions to the problem.
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2015-11-16 21:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-15 17:27 leds-bcm6328: add more init configuration options Simon Arlott
2015-11-16 15:03 ` Jacek Anaszewski
[not found] ` <5649F040.6090002-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-11-16 21:35 ` Álvaro Fernández Rojas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564A4C3B.6090806@gmail.com \
--to=noltari-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=j.anaszewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-leds-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=simon-A6De1vDTPLDsq35pWSNszA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).