* [PATCH] leds: sunfire: Use platform_register/unregister_drivers()
@ 2015-12-02 16:27 Thierry Reding
2015-12-03 10:43 ` Jacek Anaszewski
0 siblings, 1 reply; 2+ messages in thread
From: Thierry Reding @ 2015-12-02 16:27 UTC (permalink / raw)
To: Jacek Anaszewski; +Cc: linux-leds, linux-kernel
From: Thierry Reding <treding@nvidia.com>
These new helpers simplify implementing multi-driver modules and
properly handle failure to register one driver by unregistering all
previously registered drivers.
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
drivers/leds/leds-sunfire.c | 23 +++++++----------------
1 file changed, 7 insertions(+), 16 deletions(-)
diff --git a/drivers/leds/leds-sunfire.c b/drivers/leds/leds-sunfire.c
index c2553c54f2cf..7c09db8bd4e8 100644
--- a/drivers/leds/leds-sunfire.c
+++ b/drivers/leds/leds-sunfire.c
@@ -234,28 +234,19 @@ static struct platform_driver sunfire_fhc_led_driver = {
},
};
+static struct platform_driver * const drivers[] = {
+ &sunfire_clockboard_led_driver,
+ &sunfire_fhc_led_driver,
+};
+
static int __init sunfire_leds_init(void)
{
- int err = platform_driver_register(&sunfire_clockboard_led_driver);
-
- if (err) {
- pr_err("Could not register clock board LED driver\n");
- return err;
- }
-
- err = platform_driver_register(&sunfire_fhc_led_driver);
- if (err) {
- pr_err("Could not register FHC LED driver\n");
- platform_driver_unregister(&sunfire_clockboard_led_driver);
- }
-
- return err;
+ return platform_register_drivers(drivers, ARRAY_SIZE(drivers));
}
static void __exit sunfire_leds_exit(void)
{
- platform_driver_unregister(&sunfire_clockboard_led_driver);
- platform_driver_unregister(&sunfire_fhc_led_driver);
+ platform_unregister_drivers(drivers, ARRAY_SIZE(drivers));
}
module_init(sunfire_leds_init);
--
2.5.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] leds: sunfire: Use platform_register/unregister_drivers()
2015-12-02 16:27 [PATCH] leds: sunfire: Use platform_register/unregister_drivers() Thierry Reding
@ 2015-12-03 10:43 ` Jacek Anaszewski
0 siblings, 0 replies; 2+ messages in thread
From: Jacek Anaszewski @ 2015-12-03 10:43 UTC (permalink / raw)
To: Thierry Reding; +Cc: linux-leds, linux-kernel
On 12/02/2015 05:27 PM, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> These new helpers simplify implementing multi-driver modules and
> properly handle failure to register one driver by unregistering all
> previously registered drivers.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> drivers/leds/leds-sunfire.c | 23 +++++++----------------
> 1 file changed, 7 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/leds/leds-sunfire.c b/drivers/leds/leds-sunfire.c
> index c2553c54f2cf..7c09db8bd4e8 100644
> --- a/drivers/leds/leds-sunfire.c
> +++ b/drivers/leds/leds-sunfire.c
> @@ -234,28 +234,19 @@ static struct platform_driver sunfire_fhc_led_driver = {
> },
> };
>
> +static struct platform_driver * const drivers[] = {
> + &sunfire_clockboard_led_driver,
> + &sunfire_fhc_led_driver,
> +};
> +
> static int __init sunfire_leds_init(void)
> {
> - int err = platform_driver_register(&sunfire_clockboard_led_driver);
> -
> - if (err) {
> - pr_err("Could not register clock board LED driver\n");
> - return err;
> - }
> -
> - err = platform_driver_register(&sunfire_fhc_led_driver);
> - if (err) {
> - pr_err("Could not register FHC LED driver\n");
> - platform_driver_unregister(&sunfire_clockboard_led_driver);
> - }
> -
> - return err;
> + return platform_register_drivers(drivers, ARRAY_SIZE(drivers));
> }
>
> static void __exit sunfire_leds_exit(void)
> {
> - platform_driver_unregister(&sunfire_clockboard_led_driver);
> - platform_driver_unregister(&sunfire_fhc_led_driver);
> + platform_unregister_drivers(drivers, ARRAY_SIZE(drivers));
> }
>
> module_init(sunfire_leds_init);
>
Applied, thanks.
--
Best Regards,
Jacek Anaszewski
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-12-03 10:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-02 16:27 [PATCH] leds: sunfire: Use platform_register/unregister_drivers() Thierry Reding
2015-12-03 10:43 ` Jacek Anaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).