From: Jacek Anaszewski <j.anaszewski@samsung.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org, Johan Hovold <johan@kernel.org>,
Alexandre Courbot <acourbot@nvidia.com>,
Michael Welling <mwelling@ieee.org>,
Markus Pargmann <mpa@pengutronix.de>,
Riku Voipio <riku.voipio@iki.fi>,
Richard Purdie <rpurdie@rpsys.net>,
linux-leds@vger.kernel.org
Subject: Re: [PATCH 158/182] leds: pca9532: use gpiochip data pointer
Date: Wed, 09 Dec 2015 15:29:23 +0100 [thread overview]
Message-ID: <56683AC3.6070300@samsung.com> (raw)
In-Reply-To: <1449668770-5933-1-git-send-email-linus.walleij@linaro.org>
On 12/09/2015 02:46 PM, Linus Walleij wrote:
> This makes the driver use the data pointer added to the gpio_chip
> to store a pointer to the state container instead of relying on
> container_of().
>
> Cc: Riku Voipio <riku.voipio@iki.fi>
> Cc: Richard Purdie <rpurdie@rpsys.net>
> Cc: Jacek Anaszewski <j.anaszewski@samsung.com>
> Cc: linux-leds@vger.kernel.org
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> LEDS people: please ACK this so I can merge it in the GPIO tree.
> ---
> drivers/leds/leds-pca9532.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/leds/leds-pca9532.c b/drivers/leds/leds-pca9532.c
> index a975b32ee8c8..1b228adfd1a7 100644
> --- a/drivers/leds/leds-pca9532.c
> +++ b/drivers/leds/leds-pca9532.c
> @@ -245,7 +245,7 @@ static void pca9532_led_work(struct work_struct *work)
> #ifdef CONFIG_LEDS_PCA9532_GPIO
> static int pca9532_gpio_request_pin(struct gpio_chip *gc, unsigned offset)
> {
> - struct pca9532_data *data = container_of(gc, struct pca9532_data, gpio);
> + struct pca9532_data *data = gpiochip_get_data(gc);
> struct pca9532_led *led = &data->leds[offset];
>
> if (led->type == PCA9532_TYPE_GPIO)
> @@ -256,7 +256,7 @@ static int pca9532_gpio_request_pin(struct gpio_chip *gc, unsigned offset)
>
> static void pca9532_gpio_set_value(struct gpio_chip *gc, unsigned offset, int val)
> {
> - struct pca9532_data *data = container_of(gc, struct pca9532_data, gpio);
> + struct pca9532_data *data = gpiochip_get_data(gc);
> struct pca9532_led *led = &data->leds[offset];
>
> if (val)
> @@ -269,7 +269,7 @@ static void pca9532_gpio_set_value(struct gpio_chip *gc, unsigned offset, int va
>
> static int pca9532_gpio_get_value(struct gpio_chip *gc, unsigned offset)
> {
> - struct pca9532_data *data = container_of(gc, struct pca9532_data, gpio);
> + struct pca9532_data *data = gpiochip_get_data(gc);
> unsigned char reg;
>
> reg = i2c_smbus_read_byte_data(data->client, PCA9532_REG_INPUT(offset));
> @@ -416,7 +416,7 @@ static int pca9532_configure(struct i2c_client *client,
> data->gpio.parent = &client->dev;
> data->gpio.owner = THIS_MODULE;
>
> - err = gpiochip_add(&data->gpio);
> + err = gpiochip_add_data(&data->gpio, data);
> if (err) {
> /* Use data->gpio.dev as a flag for freeing gpiochip */
> data->gpio.parent = NULL;
>
This applies only with 3-way merge due to work queue removal related
changes that already sit on LED git. Nothing clever can be done to fix
that since those changes depend on LED core changes and this patch
depends on GPIO changes. We'll need to add relevant remarks in the pull
requests.
Acked-by: Jacek Anaszewski <j.anaszewski@samsung.com>
--
Best Regards,
Jacek Anaszewski
next prev parent reply other threads:[~2015-12-09 14:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 13:46 [PATCH 158/182] leds: pca9532: use gpiochip data pointer Linus Walleij
2015-12-09 14:29 ` Jacek Anaszewski [this message]
2015-12-11 18:39 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56683AC3.6070300@samsung.com \
--to=j.anaszewski@samsung.com \
--cc=acourbot@nvidia.com \
--cc=johan@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mpa@pengutronix.de \
--cc=mwelling@ieee.org \
--cc=riku.voipio@iki.fi \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox