Re: [PATCH 5/8] ARM: l2x0: move DT parsing for cache props

Russell King - ARM Linux
2014-09-02T12:43:26Z

On Tue, Sep 02, 2014 at 02:02:31PM +0200, Linus Walleij wrote:
> The current diagnostic prints in the l2x0 driver will print
> warnings like this if the AUX register i modified by the
> mask and set words passed to the l2x0_init() function:
>
> L2C: platform modifies aux control register: 0x02020fff -> 0x02730fff
> L2C: DT/platform modifies aux control register: 0x02020fff -> 0x02730fff

Notice that there are two here.

The first means that the platform passed values which resulted in an
actual modification to the control register. This happens in
l2x0_of_init() to identify values of aux_mask/aux_val which result
in manipulation of the control register by hard-coded platform values.

The second means that the platform _or_ the DT resulted in an actual
modification of the control register. This happens in __l2c_init(),
after the DT has been parsed, or after the non-DT code paths to identify
any remaining modifications.

I don't see any point to this patch.

--
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.