Re: [PATCH 2/8 v2] leds: add device tree bindings for register bit LEDs

Geert Uytterhoeven
2014-09-02T14:22:59Z

Hi Linus,

On Tue, Sep 2, 2014 at 2:02 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
> +LED sub-node properties:
> +
> +Required properties:
> +- compatible : must be "register-bit-led"
> +- offset : register offset to the register controlling this LED
> +- mask : bit mask for the bit controlling this LED in the register

Why don't you use a "reg" property with "#address-cells = <2>" and
"#size-cells = <1>", so you can store offset and mask there?

> +syscon: syscon@10000000 {
> + compatible = "arm,realview-pb1176-syscon", "syscon";
> + reg = <0x10000000 0x1000>;
> +
> + led@08.0 {
> + compatible = "register-bit-led";
> + offset = <0x08>;
> + mask = <0x01>;
> + label = "versatile:0";
> + linux,default-trigger = "heartbeat";
> + default-state = "on";
> + };

ePAPR v1.1 says:

"The unit-address must match the first address specified in the reg property
of the node. If the node has no reg property, the @ and unit-address must
be omitted ..."

So you cannot have the "@8.0" without a "reg" property.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds