From: Milo Kim <milo.kim@ti.com>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Jacek Anaszewski <j.anaszewski@samsung.com>, linux-leds@vger.kernel.org
Subject: Re: Problem with resetting LED in led_classdev_unregister in case of USB LED device removal
Date: Mon, 18 Jan 2016 09:20:43 +0900 [thread overview]
Message-ID: <569C2FDB.8090005@ti.com> (raw)
In-Reply-To: <569AB77D.3020909@gmail.com>
On 01/17/2016 06:34 AM, Heiner Kallweit wrote:
> In led_classdev_unregister the LED gets switched off.
> This is fine when the driver module is removed but causes issues
> when the physical LED device is removed (e.g. USB LED devices).
>
> In case of the thingm driver (hid/hid-thingm.c) it complains with
> ENODEV because the physical LED device is no longer available.
I'd like to understand this situation clearly.
rmmod hid_thingm
-> detach the USB LED device
-> -ENODEV is reported.
Is it correct? I think -ENODEV seems reasonable because HID device is
gone. Could you tell us what the problem is?
> When I switched this driver to use the generic workqueue in the
> LED core then this error was also propagated to set_brightness_delayed
> and it complains with "Setting an LED's brightness failed (-19)".
>
> Recent commit d1aa577f5e19 [turn off the LED and wait for completion
> on unregistering LED class device] tackled a first potential issue
> in led_classdev_unregister but it seems like the case of removal
> of the physical LED device hasn't been considered yet.
What happens if resetting only this commit?
> At a first glance I see no way for the LED core to tell between
> the two unregister cases (driver module removal vs. physical LED
> device removal), but maybe I miss something.
>
> If we can't tell between the two cases them I'm not sure what's the
> best solution: Not touching the brightness is general in
> led_classdev_unregister, live with the situation as it is or add
> a special handling for ENODEV.
We may handle this by using internal flag in LED subsystem, but I'd like
to understand what the problem is and what expected behavior is.
Best regards,
Milo
next prev parent reply other threads:[~2016-01-18 0:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-16 21:34 Problem with resetting LED in led_classdev_unregister in case of USB LED device removal Heiner Kallweit
2016-01-18 0:20 ` Milo Kim [this message]
2016-01-18 6:37 ` Heiner Kallweit
2016-01-18 8:46 ` Jacek Anaszewski
2016-01-18 20:52 ` Heiner Kallweit
2016-01-19 0:11 ` Milo Kim
2016-01-19 6:46 ` Heiner Kallweit
2016-01-19 9:10 ` Jacek Anaszewski
2016-01-19 20:23 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569C2FDB.8090005@ti.com \
--to=milo.kim@ti.com \
--cc=hkallweit1@gmail.com \
--cc=j.anaszewski@samsung.com \
--cc=linux-leds@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).