* [PATCH] leds: use config symbol LEDS_CLASS_RGB consistently
@ 2016-03-21 10:57 Heiner Kallweit
2016-03-21 15:45 ` Jacek Anaszewski
0 siblings, 1 reply; 3+ messages in thread
From: Heiner Kallweit @ 2016-03-21 10:57 UTC (permalink / raw)
To: Jacek Anaszewski; +Cc: linux-leds@vger.kernel.org
Config symbol LEDS_RGB was renamed to LEDS_CLASS_RGB.
This makes sense, but the change wasn't done consistently.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/leds/Kconfig | 4 ++--
drivers/leds/Makefile | 2 +-
drivers/leds/leds.h | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
index 4d819ba..f213c06 100644
--- a/drivers/leds/Kconfig
+++ b/drivers/leds/Kconfig
@@ -624,9 +624,9 @@ config LEDS_VERSATILE
This option enabled support for the LEDs on the ARM Versatile
and RealView boards. Say Y to enabled these.
-if LEDS_RGB
+if LEDS_CLASS_RGB
comment "RGB LED drivers"
-endif # LEDS_RGB
+endif # LEDS_CLASS_RGB
comment "LED Triggers"
source "drivers/leds/trigger/Kconfig"
diff --git a/drivers/leds/Makefile b/drivers/leds/Makefile
index 9419dbf..e36ef69 100644
--- a/drivers/leds/Makefile
+++ b/drivers/leds/Makefile
@@ -2,7 +2,7 @@
# LED Core
obj-$(CONFIG_NEW_LEDS) += led-core-objs.o
led-core-objs-y := led-core.o
-led-core-objs-$(CONFIG_LEDS_RGB) += led-rgb-core.o
+led-core-objs-$(CONFIG_LEDS_CLASS_RGB) += led-rgb-core.o
obj-$(CONFIG_LEDS_CLASS) += led-class.o
obj-$(CONFIG_LEDS_CLASS_FLASH) += led-class-flash.o
obj-$(CONFIG_LEDS_TRIGGERS) += led-triggers.o
diff --git a/drivers/leds/leds.h b/drivers/leds/leds.h
index b853f54..9c5f3fe 100644
--- a/drivers/leds/leds.h
+++ b/drivers/leds/leds.h
@@ -35,7 +35,7 @@ void led_set_brightness_nopm(struct led_classdev *led_cdev,
enum led_brightness value);
void led_set_brightness_nosleep(struct led_classdev *led_cdev,
enum led_brightness value);
-#if IS_ENABLED(CONFIG_LEDS_RGB)
+#if IS_ENABLED(CONFIG_LEDS_CLASS_RGB)
enum led_brightness led_confine_brightness(struct led_classdev *led_cdev,
enum led_brightness value);
#else
--
2.7.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] leds: use config symbol LEDS_CLASS_RGB consistently
2016-03-21 10:57 [PATCH] leds: use config symbol LEDS_CLASS_RGB consistently Heiner Kallweit
@ 2016-03-21 15:45 ` Jacek Anaszewski
2016-03-21 17:24 ` Heiner Kallweit
0 siblings, 1 reply; 3+ messages in thread
From: Jacek Anaszewski @ 2016-03-21 15:45 UTC (permalink / raw)
To: Heiner Kallweit; +Cc: linux-leds@vger.kernel.org
Hi Heiner,
Please note that you don't need to submit incremental patches
for the code that is not in mainline yet. You can send just
a new version and I'll replace the old one with it.
Thanks,
Jacek Anaszewski
On 03/21/2016 11:57 AM, Heiner Kallweit wrote:
> Config symbol LEDS_RGB was renamed to LEDS_CLASS_RGB.
> This makes sense, but the change wasn't done consistently.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> drivers/leds/Kconfig | 4 ++--
> drivers/leds/Makefile | 2 +-
> drivers/leds/leds.h | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> index 4d819ba..f213c06 100644
> --- a/drivers/leds/Kconfig
> +++ b/drivers/leds/Kconfig
> @@ -624,9 +624,9 @@ config LEDS_VERSATILE
> This option enabled support for the LEDs on the ARM Versatile
> and RealView boards. Say Y to enabled these.
>
> -if LEDS_RGB
> +if LEDS_CLASS_RGB
> comment "RGB LED drivers"
> -endif # LEDS_RGB
> +endif # LEDS_CLASS_RGB
>
> comment "LED Triggers"
> source "drivers/leds/trigger/Kconfig"
> diff --git a/drivers/leds/Makefile b/drivers/leds/Makefile
> index 9419dbf..e36ef69 100644
> --- a/drivers/leds/Makefile
> +++ b/drivers/leds/Makefile
> @@ -2,7 +2,7 @@
> # LED Core
> obj-$(CONFIG_NEW_LEDS) += led-core-objs.o
> led-core-objs-y := led-core.o
> -led-core-objs-$(CONFIG_LEDS_RGB) += led-rgb-core.o
> +led-core-objs-$(CONFIG_LEDS_CLASS_RGB) += led-rgb-core.o
> obj-$(CONFIG_LEDS_CLASS) += led-class.o
> obj-$(CONFIG_LEDS_CLASS_FLASH) += led-class-flash.o
> obj-$(CONFIG_LEDS_TRIGGERS) += led-triggers.o
> diff --git a/drivers/leds/leds.h b/drivers/leds/leds.h
> index b853f54..9c5f3fe 100644
> --- a/drivers/leds/leds.h
> +++ b/drivers/leds/leds.h
> @@ -35,7 +35,7 @@ void led_set_brightness_nopm(struct led_classdev *led_cdev,
> enum led_brightness value);
> void led_set_brightness_nosleep(struct led_classdev *led_cdev,
> enum led_brightness value);
> -#if IS_ENABLED(CONFIG_LEDS_RGB)
> +#if IS_ENABLED(CONFIG_LEDS_CLASS_RGB)
> enum led_brightness led_confine_brightness(struct led_classdev *led_cdev,
> enum led_brightness value);
> #else
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] leds: use config symbol LEDS_CLASS_RGB consistently
2016-03-21 15:45 ` Jacek Anaszewski
@ 2016-03-21 17:24 ` Heiner Kallweit
0 siblings, 0 replies; 3+ messages in thread
From: Heiner Kallweit @ 2016-03-21 17:24 UTC (permalink / raw)
To: Jacek Anaszewski; +Cc: linux-leds@vger.kernel.org
Am 21.03.2016 um 16:45 schrieb Jacek Anaszewski:
> Hi Heiner,
>
> Please note that you don't need to submit incremental patches
> for the code that is not in mainline yet. You can send just
> a new version and I'll replace the old one with it.
OK, I see. Then I'll send a v8 of the patch.
Heiner
>
> Thanks,
> Jacek Anaszewski
>
> On 03/21/2016 11:57 AM, Heiner Kallweit wrote:
>> Config symbol LEDS_RGB was renamed to LEDS_CLASS_RGB.
>> This makes sense, but the change wasn't done consistently.
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>> ---
>> drivers/leds/Kconfig | 4 ++--
>> drivers/leds/Makefile | 2 +-
>> drivers/leds/leds.h | 2 +-
>> 3 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
>> index 4d819ba..f213c06 100644
>> --- a/drivers/leds/Kconfig
>> +++ b/drivers/leds/Kconfig
>> @@ -624,9 +624,9 @@ config LEDS_VERSATILE
>> This option enabled support for the LEDs on the ARM Versatile
>> and RealView boards. Say Y to enabled these.
>>
>> -if LEDS_RGB
>> +if LEDS_CLASS_RGB
>> comment "RGB LED drivers"
>> -endif # LEDS_RGB
>> +endif # LEDS_CLASS_RGB
>>
>> comment "LED Triggers"
>> source "drivers/leds/trigger/Kconfig"
>> diff --git a/drivers/leds/Makefile b/drivers/leds/Makefile
>> index 9419dbf..e36ef69 100644
>> --- a/drivers/leds/Makefile
>> +++ b/drivers/leds/Makefile
>> @@ -2,7 +2,7 @@
>> # LED Core
>> obj-$(CONFIG_NEW_LEDS) += led-core-objs.o
>> led-core-objs-y := led-core.o
>> -led-core-objs-$(CONFIG_LEDS_RGB) += led-rgb-core.o
>> +led-core-objs-$(CONFIG_LEDS_CLASS_RGB) += led-rgb-core.o
>> obj-$(CONFIG_LEDS_CLASS) += led-class.o
>> obj-$(CONFIG_LEDS_CLASS_FLASH) += led-class-flash.o
>> obj-$(CONFIG_LEDS_TRIGGERS) += led-triggers.o
>> diff --git a/drivers/leds/leds.h b/drivers/leds/leds.h
>> index b853f54..9c5f3fe 100644
>> --- a/drivers/leds/leds.h
>> +++ b/drivers/leds/leds.h
>> @@ -35,7 +35,7 @@ void led_set_brightness_nopm(struct led_classdev *led_cdev,
>> enum led_brightness value);
>> void led_set_brightness_nosleep(struct led_classdev *led_cdev,
>> enum led_brightness value);
>> -#if IS_ENABLED(CONFIG_LEDS_RGB)
>> +#if IS_ENABLED(CONFIG_LEDS_CLASS_RGB)
>> enum led_brightness led_confine_brightness(struct led_classdev *led_cdev,
>> enum led_brightness value);
>> #else
>>
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-03-21 17:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-21 10:57 [PATCH] leds: use config symbol LEDS_CLASS_RGB consistently Heiner Kallweit
2016-03-21 15:45 ` Jacek Anaszewski
2016-03-21 17:24 ` Heiner Kallweit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).