From: Heiner Kallweit <hkallweit1@gmail.com>
To: Jacek Anaszewski <j.anaszewski@samsung.com>
Cc: "linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>
Subject: Re: [PATCH] leds: use config symbol LEDS_CLASS_RGB consistently
Date: Mon, 21 Mar 2016 18:24:08 +0100 [thread overview]
Message-ID: <56F02E38.8030606@gmail.com> (raw)
In-Reply-To: <56F01700.30407@samsung.com>
Am 21.03.2016 um 16:45 schrieb Jacek Anaszewski:
> Hi Heiner,
>
> Please note that you don't need to submit incremental patches
> for the code that is not in mainline yet. You can send just
> a new version and I'll replace the old one with it.
OK, I see. Then I'll send a v8 of the patch.
Heiner
>
> Thanks,
> Jacek Anaszewski
>
> On 03/21/2016 11:57 AM, Heiner Kallweit wrote:
>> Config symbol LEDS_RGB was renamed to LEDS_CLASS_RGB.
>> This makes sense, but the change wasn't done consistently.
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>> ---
>> drivers/leds/Kconfig | 4 ++--
>> drivers/leds/Makefile | 2 +-
>> drivers/leds/leds.h | 2 +-
>> 3 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
>> index 4d819ba..f213c06 100644
>> --- a/drivers/leds/Kconfig
>> +++ b/drivers/leds/Kconfig
>> @@ -624,9 +624,9 @@ config LEDS_VERSATILE
>> This option enabled support for the LEDs on the ARM Versatile
>> and RealView boards. Say Y to enabled these.
>>
>> -if LEDS_RGB
>> +if LEDS_CLASS_RGB
>> comment "RGB LED drivers"
>> -endif # LEDS_RGB
>> +endif # LEDS_CLASS_RGB
>>
>> comment "LED Triggers"
>> source "drivers/leds/trigger/Kconfig"
>> diff --git a/drivers/leds/Makefile b/drivers/leds/Makefile
>> index 9419dbf..e36ef69 100644
>> --- a/drivers/leds/Makefile
>> +++ b/drivers/leds/Makefile
>> @@ -2,7 +2,7 @@
>> # LED Core
>> obj-$(CONFIG_NEW_LEDS) += led-core-objs.o
>> led-core-objs-y := led-core.o
>> -led-core-objs-$(CONFIG_LEDS_RGB) += led-rgb-core.o
>> +led-core-objs-$(CONFIG_LEDS_CLASS_RGB) += led-rgb-core.o
>> obj-$(CONFIG_LEDS_CLASS) += led-class.o
>> obj-$(CONFIG_LEDS_CLASS_FLASH) += led-class-flash.o
>> obj-$(CONFIG_LEDS_TRIGGERS) += led-triggers.o
>> diff --git a/drivers/leds/leds.h b/drivers/leds/leds.h
>> index b853f54..9c5f3fe 100644
>> --- a/drivers/leds/leds.h
>> +++ b/drivers/leds/leds.h
>> @@ -35,7 +35,7 @@ void led_set_brightness_nopm(struct led_classdev *led_cdev,
>> enum led_brightness value);
>> void led_set_brightness_nosleep(struct led_classdev *led_cdev,
>> enum led_brightness value);
>> -#if IS_ENABLED(CONFIG_LEDS_RGB)
>> +#if IS_ENABLED(CONFIG_LEDS_CLASS_RGB)
>> enum led_brightness led_confine_brightness(struct led_classdev *led_cdev,
>> enum led_brightness value);
>> #else
>>
>
>
>
prev parent reply other threads:[~2016-03-21 17:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-21 10:57 [PATCH] leds: use config symbol LEDS_CLASS_RGB consistently Heiner Kallweit
2016-03-21 15:45 ` Jacek Anaszewski
2016-03-21 17:24 ` Heiner Kallweit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F02E38.8030606@gmail.com \
--to=hkallweit1@gmail.com \
--cc=j.anaszewski@samsung.com \
--cc=linux-leds@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).