From: Jacek Anaszewski <j.anaszewski@samsung.com>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
rpurdie@rpsys.net, ezequiel@vanguardiasur.com.ar, pavel@ucw.cz
Subject: Re: [PATCH] leds: ledtrig-ide-disk: Move ide_blink_delay to ledtrig_ide_activity()
Date: Tue, 19 Apr 2016 09:09:12 +0200 [thread overview]
Message-ID: <5715D998.7030402@samsung.com> (raw)
In-Reply-To: <20160418165715.4668ffa0@bbrezillon>
Hi Boris,
Thanks for the review, patch applied.
Best regards,
Jacek Anaszewski
On 04/18/2016 04:57 PM, Boris Brezillon wrote:
> On Mon, 18 Apr 2016 16:40:46 +0200
> Jacek Anaszewski <j.anaszewski@samsung.com> wrote:
>
>> Parameters delay_on and delay_off of led_trigger_blink_oneshot()
>> are pointers, to enable blink interval adjustment by LED class drivers
>> of the controllers that implement hardware blinking.
>>
>> Move ide_blink_delay variable to ledtrig_ide_activity() in order to
>> prevent the situation when adjustment committed by one LED class
>> driver influences blink interval of the software fallback blink feature,
>> that is applied to the drivers that don't implement blink_set op.
>>
>> Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
>
> Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>
prev parent reply other threads:[~2016-04-19 7:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-18 14:40 [PATCH] leds: ledtrig-ide-disk: Move ide_blink_delay to ledtrig_ide_activity() Jacek Anaszewski
2016-04-18 14:57 ` Boris Brezillon
2016-04-19 7:09 ` Jacek Anaszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5715D998.7030402@samsung.com \
--to=j.anaszewski@samsung.com \
--cc=boris.brezillon@free-electrons.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).