Re: [PATCH v3 1/1] leds: LED driver for TI LP3952 6-Channel Color LED

[Tony Makkiel <tony.makkiel@daqri.com>]

On 10/06/16 15:36, Jacek Anaszewski wrote:
> On 06/10/2016 02:56 PM, Tony Makkiel wrote:
>>
>>
>>
>>>>>>> +
>>>>>>> +#ifdef CONFIG_ACPI
>>>>>>> +static const struct acpi_device_id lp3952_acpi_match[] = {
>>>>>>> +    {LP3952_NAME, 0},
>>>>>>> +    {}
>>>>>>> +};
>>>>>>
>>>>>> Could you please share how did you apply ACPI overlay?
>>>>>
>>>>> I am using the initrd ACPI method of Octavian's patch.
>>>>>
>>>>> https://lkml.org/lkml/2016/3/31/333
>>>>
>>>> Thanks. Would it be possible to define entries per each LED
>>>> connected to the LED controller, similarly as it is in case
>>>> of Device Tree bindings?:
>>>>
>>>> Documentation/devicetree/bindings/leds/common.txt
>>>>
>>>
>>> I am not sure. I did a quick skim through ACPI Spec 5.0.
>>> But couldn't find anything.
>>
>> Found it!, although not relevant for this driver. Please
>> see last page of
>> http://www.uefi.org/sites/default/files/resources/_DSD-device-properties-UUID.pdf
> 
> Great. The "Package" entries seem to use names compatible with the
> Device Tree properties documented in
> Documentation/devicetree/bindings/leds/common.txt.
> 
> Probably you could also provide LED name in the "Name" entry and obtain
> them in the driver directly from ACPI, similarly as it is accomplished
> in case of Device Tree.
> 
> led_name array from lp3952_register_led_classdev() could be removed
> then.

I don't think it is possible yet, maybe once there is an updated iasl compiler.
The current version does not even recognize _DSD.
>