From: Jacek Anaszewski <j.anaszewski@samsung.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: Tony Makkiel <tony.makkiel@daqri.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Richard Purdie <rpurdie@rpsys.net>,
"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>
Subject: Re: [PATCH] leds: lp3952: Store leds[LP3952_LED_ALL] in struct lp3952_led_array
Date: Mon, 18 Jul 2016 09:29:43 +0200 [thread overview]
Message-ID: <578C8567.1070802@samsung.com> (raw)
In-Reply-To: <CAFRkauAKLnXakKH1qBKyGdTn7-0-z7Gp_7zj7ii6RBK1uXavAA@mail.gmail.com>
On 07/18/2016 08:53 AM, Axel Lin wrote:
>
>
> 2016-07-18 14:48 GMT+08:00 Jacek Anaszewski <j.anaszewski@samsung.com
> <mailto:j.anaszewski@samsung.com>>:
>
> Hi Axel,
>
> Thanks for catching this. I missed also redundant devm_kfree here.
> Would it be OK for you if I merged your cleanup with the original
> patch and added your Reviewed-by to the commit message instead?
>
>
> That's fine, you can add Reviewed-by: Axel Lin <axel.lin@ingics.com
> <mailto:axel.lin@ingics.com>>.
>
> This driver hasn't been pushed to the mainline yet, so it would be
> nice not to introduce its original version with some shortcomings
> that need to be immediately fixed.
Fixed up the original patch and updated for-next branch of
linux-leds.git.
--
Best regards,
Jacek Anaszewski
prev parent reply other threads:[~2016-07-18 7:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-17 2:18 [PATCH] leds: lp3952: Store leds[LP3952_LED_ALL] in struct lp3952_led_array Axel Lin
2016-07-18 6:48 ` Jacek Anaszewski
[not found] ` <CAFRkauAKLnXakKH1qBKyGdTn7-0-z7Gp_7zj7ii6RBK1uXavAA@mail.gmail.com>
2016-07-18 7:29 ` Jacek Anaszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=578C8567.1070802@samsung.com \
--to=j.anaszewski@samsung.com \
--cc=axel.lin@ingics.com \
--cc=linux-leds@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rpurdie@rpsys.net \
--cc=tony.makkiel@daqri.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).