From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4119E8FDD0 for ; Wed, 4 Oct 2023 06:37:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241422AbjJDGhw (ORCPT ); Wed, 4 Oct 2023 02:37:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232734AbjJDGht (ORCPT ); Wed, 4 Oct 2023 02:37:49 -0400 Received: from mxout70.expurgate.net (mxout70.expurgate.net [91.198.224.70]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C047DD9; Tue, 3 Oct 2023 23:37:43 -0700 (PDT) Received: from [127.0.0.1] (helo=localhost) by relay.expurgate.net with smtp (Exim 4.92) (envelope-from ) id 1qnvVj-00GrEg-CB; Wed, 04 Oct 2023 08:37:31 +0200 Received: from [195.243.126.94] (helo=securemail.tdt.de) by relay.expurgate.net with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qnvVi-006jS9-94; Wed, 04 Oct 2023 08:37:30 +0200 Received: from securemail.tdt.de (localhost [127.0.0.1]) by securemail.tdt.de (Postfix) with ESMTP id D864E240049; Wed, 4 Oct 2023 08:37:29 +0200 (CEST) Received: from mail.dev.tdt.de (unknown [10.2.4.42]) by securemail.tdt.de (Postfix) with ESMTP id 39A7E240040; Wed, 4 Oct 2023 08:37:29 +0200 (CEST) Received: from mail.dev.tdt.de (localhost [IPv6:::1]) by mail.dev.tdt.de (Postfix) with ESMTP id A38DB32F62; Wed, 4 Oct 2023 08:37:28 +0200 (CEST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 04 Oct 2023 08:37:28 +0200 From: Florian Eckert To: Jiri Slaby Cc: Lee Jones , Eckert.Florian@googlemail.com, gregkh@linuxfoundation.org, pavel@ucw.cz, kabel@kernel.org, u.kleine-koenig@pengutronix.de, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-leds@vger.kernel.org, kernel test robot Subject: Re: [PATCH v2 3/4] trigger: ledtrig-tty: move variable definition to the top In-Reply-To: References: <20230928132632.200263-1-fe@dev.tdt.de> <20230928132632.200263-4-fe@dev.tdt.de> <20231002140559.GB8453@google.com> Message-ID: <59cc4073a94edbdec5d77f8457ed4f73@dev.tdt.de> X-Sender: fe@dev.tdt.de User-Agent: Roundcube Webmail/1.3.17 X-purgate-type: clean X-purgate: clean X-purgate-ID: 151534::1696401451-B1C31B19-0543AF23/0/0 Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On 2023-10-03 07:00, Jiri Slaby wrote: > On 02. 10. 23, 16:05, Lee Jones wrote: >> On Thu, 28 Sep 2023, Florian Eckert wrote: >> >>> The Intel build robot has complained about this. Hence move the >>> commit >>> of the variable definition to the beginning of the function. >> Please copy the robot's error message into the commit message. For a v3 patch-set I will add the error message from build robot. Build robot output of my v1 change: https://lore.kernel.org/linux-leds/20230926093607.59536-1-fe@dev.tdt.de/T/#m777371c5de8fadc505a833139b8ae69ac7fa8dab I decided to move the variable definition with a separate commit to the top of the function, to make the build robot happy. After that I made my changes for v2 to the ledtrig-tty to add the feature. > Ah, lkp, then also the Closes: line as it suggests. Sorry I do not understand your statement >>> Reported-by: kernel test robot >>> Signed-off-by: Florian Eckert >>> --- >>> drivers/leds/trigger/ledtrig-tty.c | 3 +-- >>> 1 file changed, 1 insertion(+), 2 deletions(-) >>> >>> diff --git a/drivers/leds/trigger/ledtrig-tty.c >>> b/drivers/leds/trigger/ledtrig-tty.c >>> index 8ae0d2d284af..1c6fadf0b856 100644 >>> --- a/drivers/leds/trigger/ledtrig-tty.c >>> +++ b/drivers/leds/trigger/ledtrig-tty.c >>> @@ -82,6 +82,7 @@ static void ledtrig_tty_work(struct work_struct >>> *work) >>> { >>> struct ledtrig_tty_data *trigger_data = >>> container_of(work, struct ledtrig_tty_data, dwork.work); >>> + unsigned long interval = LEDTRIG_TTY_INTERVAL; >>> struct serial_icounter_struct icount; >>> int ret; >>> @@ -124,8 +125,6 @@ static void ledtrig_tty_work(struct work_struct >>> *work) >>> if (icount.rx != trigger_data->rx || >>> icount.tx != trigger_data->tx) { >>> - unsigned long interval = LEDTRIG_TTY_INTERVAL; >>> - >>> led_blink_set_oneshot(trigger_data->led_cdev, &interval, >>> &interval, 0); >>> -- 2.30.2 >>> >>