From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F19FE1C3C08 for ; Fri, 9 Jan 2026 08:14:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767946448; cv=none; b=bfrOFDVkGYYfyfjNGicgiNnSCIBo1kHyuG5H+JkKRWgwrZZ6dYEp4PFM6iMhgl7D3b3AZEHZz5HqkwWKl4la6bUF8Tm+9QJUghRlsMmXPHgSg0Nct3nUzfHYXv88zCzbqEbqbogh+uOuWZaqP2OWoHLW41EqQcVz09J33Kl0AUU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767946448; c=relaxed/simple; bh=TegNChNmHEzD8+9WeNnVdBonXBPxxrbHlIIxhxeFES4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=J1g2+cJ+UGba8xO5F9HDrOoebJqtUc4gKXeRfppeLdQ40HBNYG9AtAbq7OR8BcJMUVAZtJ5KBmspFUUYXoU8mwKxU9gb1CpWrT+xE06GMadzZce+OyhBlavAP+jNFbKrdqXKEcr01be6TO+V5k8FBvVFDsQpwdM3jvWRgYSmgpA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fA7qqshL; arc=none smtp.client-ip=209.85.218.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fA7qqshL" Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-b79d6a70fc8so748343166b.0 for ; Fri, 09 Jan 2026 00:14:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767946445; x=1768551245; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VpBRuHMiMCleFgRr0io9MPn59FZX7HGviJTaLToKJC0=; b=fA7qqshLxoTIJi4tgDR/RtBQ7TGUnPKLFhwL2gXn2LxCZlxAuA6g2IB+G0rf3UbOK1 V6eXlAiBP/gXBfLHJ9Dlxpx6nTFORghlrN45QVDYbHj/oEA+7Lc0gOBBJkLju0DA8h9k 4DCVlr84LxnQ/sTx29ARDD9DbMm9mfgyTRrv6OIymXIGLM2yevPKggXT6Aux7mep6N/z e++YkkApa1Ad3n4/bdlsHSWRAmXP7+4ZljR00kU7F5CjG9NNhLVjaol4qVGY7EC7l69B /waXNeDGrSp6+IW4F+0jJK5y2QIh83Fte1Abmq8zo2LzYig2Oe83AN5bnjClOiV+oOqr +XEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767946445; x=1768551245; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VpBRuHMiMCleFgRr0io9MPn59FZX7HGviJTaLToKJC0=; b=vzP3xcvm9ppH8w9j7leFfNAcr6yNWHC4rW5LKcJUcVreXD3HuJPp1U+zU/mrpHSjyn ceXzl9uezPtKjP9ehwHSbKmuY9rcpZxH3736sC+R8+zgcPUKYN3NSJ0hF6llrj24pL7Q Jzelk6WTV5mKSx+NzE5Nxz1aq6Or++99CkKZ07buylek6spHnrFE5/BgJ1AxixoBc6iX yoTdHs4p/UGfL4z5pzyh55ulH1/GCaLkWe58MNipdLXzE5Us72Co4qGWeS6kHvUngo/W 6f/lNEMrZsc2pilS0d2u23Q+AGGPLVkfH0TWz7JawHH67Z+o0XYvu8O0ratTc+YAfnhA JcYg== X-Forwarded-Encrypted: i=1; AJvYcCVoUTG/tKWWFODM3v2ADYUUHxxlaBaXhS6KQbxLXrrUoKTdiTJ6bodqM2lrknD0W/uX3wnzpLK39Z+J@vger.kernel.org X-Gm-Message-State: AOJu0YwXQd6+D+UNl+nHiIhYG0Bs9l0VqdwbhZt6zDEFxhWJ4rCQo+5b N0CUYX2DN6WFRwTINrkkxdZ8jikpNGIepDj6mLlN/2TPmW58P+72hyAV X-Gm-Gg: AY/fxX4SA5O2an0W4AiCZjLNDlHX2jKEwnAh1uXzPPOZ5xZvftpgdXAgOkszWtzUQiz ERdwxQIJ2UT8lF8FxrX0WyPRCSi9imsbHfwARfkQH4YF/uAfX7mKnv+g3RYxG5hn578rOf4yaqr rIu6Fc0aTiEQOAP4dfvodTjYa8ybRAbelmAFNRA2PZa8tkZdZiHH6vHytrsLs4X5ciFUhtQO16T afrDE3sdGnctmYFPFFLFFsDIpJo+HX6gB+wf9CszPqCkeUvkKC6oo3qNssEAJBQnJWxUGhHeEi5 Cw6UKr5jiAKnm8vp/geYzXtnEz0ORhGIqs1BeBdXBY+UDPtK+i7IApsynHwCQ+CMPUIUdyTclVb 9aM3Sm+n0uW6psSB4ZccopNlh22xvLoJe59KvbhOJIqB6WA6IoMk2D2iA8rgV6onTVj5fRXqE6Q UcWWOnahRo8+NsTJFhIRQnNmR2v2xErzZ2MXKvZkNDzkrY0jFtTpWlW2fVqJeS9qyfPzir0PHhU NwsPw4= X-Google-Smtp-Source: AGHT+IEbfnpAwTBpMLXsSD7GLLq4RdVLr81UJhXWfoMR4g3wMxGRElDJAG31EIjk//ER3TZlJZdKiQ== X-Received: by 2002:a2e:b8d0:0:b0:382:ff8c:c9c3 with SMTP id 38308e7fff4ca-382ff8ccac1mr27076741fa.3.1767940183581; Thu, 08 Jan 2026 22:29:43 -0800 (PST) Received: from ?IPV6:2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703? ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-382eb7cc214sm21543771fa.22.2026.01.08.22.29.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Jan 2026 22:29:42 -0800 (PST) Message-ID: <63bc889a-b97e-43c3-9f46-9ca444873b70@gmail.com> Date: Fri, 9 Jan 2026 08:29:41 +0200 Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RESEND v6 00/17] Support ROHM BD72720 PMIC To: Lee Jones Cc: Matti Vaittinen , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sebastian Reichel , Liam Girdwood , Mark Brown , Michael Turquette , Stephen Boyd , Linus Walleij , Bartosz Golaszewski , Alexandre Belloni , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org, Andreas Kemnade References: <20260108172735.GK302752@google.com> Content-Language: en-US, en-AU, en-GB, en-BW From: Matti Vaittinen In-Reply-To: <20260108172735.GK302752@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 08/01/2026 19:27, Lee Jones wrote: > On Mon, 15 Dec 2025, Matti Vaittinen wrote: > >> Resending the v6 >> >> Series is same as v6 _except_ being rebased on v6.19-rc1 - and adding rb >> tags which were replied to v6. >> >> The ROHM BD72720 is a new power management IC for portable, battery >> powered devices. It integrates 10 BUCKs and 11 LDOs, RTC, charger, LEDs, >> GPIOs and a clock gate. To me the BD72720 seems like a successor to the >> BD71828 and BD71815 PMICs. >> >> This series depends on >> 5bff79dad20a ("power: supply: Add bd718(15/28/78) charger driver") >> which is in power-supply tree, for-next. Thus, the series is based on >> it. >> >> The testing since v4 has suffered some hardware-issues after I >> accidentally enabled charging while the PMIC's battery pin was connected >> to the I/O domain. Some heat was generated, not terribly lot smoke >> though... >> >> After the incident I've had occasional I2C failures. I, however, suspect >> the root cause is HW damage in I/O lines. >> >> Revision history: >> v6 resend: >> - Rebased on v6.19-rc1 and collected rb-tags from v6. >> >> v5 => v6: >> - MFD fixes as suggested by Lee >> - Styling mostly >> - New patch to Fix comment style for MFD driver >> More accurate changelog in individual patches >> >> v4 => v5: >> - dt-binding fixes as discussed in v4 reviews. >> - Drop rohm,vdr-battery.yaml and add vdr properties to battery.yaml >> - Drop 'rohm,' -vendor-prefix from vdr properties >> - Link to v4: >> https://lore.kernel.org/all/cover.1763022807.git.mazziesaccount@gmail.com/ >> More accurate changelog in individual patches >> >> v3 => v4: >> - dt-binding fixes to the BD72720 MFD example and regulator bindings >> More accurate changelog in individual patches >> >> v2 => v3: >> - rebased to power-supply/for-next as dependencies are merged to there >> - plenty of dt-binding changes as suggested by reviewers >> - add new patch to better document existing 'trickle-charging' property >> More accurate changelog in individual patches >> >> RFCv1 => v2: >> - Drop RFC status >> - Use stacked regmaps to hide secondary map from the sub-drivers >> - Quite a few styling fixes and improvements as suggested by >> reviewers. More accurate changelog in individual patches. >> - Link to v1: >> https://lore.kernel.org/all/cover.1759824376.git.mazziesaccount@gmail.com/ >> >> --- >> >> Matti Vaittinen (17): >> dt-bindings: regulator: ROHM BD72720 >> dt-bindings: battery: Clarify trickle-charge >> dt-bindings: battery: Add trickle-charge upper limit >> dt-bindings: battery: Voltage drop properties >> dt-bindings: mfd: ROHM BD72720 >> dt-bindings: leds: bd72720: Add BD72720 >> mfd: rohm-bd71828: Use regmap_reg_range() >> mfd: rohm-bd71828: Use standard file header format >> mfd: rohm-bd71828: Support ROHM BD72720 >> regulator: bd71828: rename IC specific entities >> regulator: bd71828: Support ROHM BD72720 >> gpio: Support ROHM BD72720 gpios >> clk: clk-bd718x7: Support BD72720 clk gate >> rtc: bd70528: Support BD72720 rtc >> power: supply: bd71828: Support wider register addresses >> power: supply: bd71828-power: Support ROHM BD72720 >> MAINTAINERS: Add ROHM BD72720 PMIC >> >> .../bindings/leds/rohm,bd71828-leds.yaml | 7 +- >> .../bindings/mfd/rohm,bd72720-pmic.yaml | 339 ++++++ >> .../bindings/power/supply/battery.yaml | 33 +- >> .../regulator/rohm,bd72720-regulator.yaml | 148 +++ >> MAINTAINERS | 2 + >> drivers/clk/Kconfig | 4 +- >> drivers/clk/clk-bd718x7.c | 10 +- >> drivers/gpio/Kconfig | 9 + >> drivers/gpio/Makefile | 1 + >> drivers/gpio/gpio-bd72720.c | 281 +++++ >> drivers/mfd/Kconfig | 18 +- >> drivers/mfd/rohm-bd71828.c | 555 ++++++++- >> drivers/power/supply/bd71828-power.c | 160 ++- >> drivers/regulator/Kconfig | 8 +- >> drivers/regulator/bd71828-regulator.c | 1025 ++++++++++++++++- >> drivers/rtc/Kconfig | 3 +- >> drivers/rtc/rtc-bd70528.c | 21 +- >> include/linux/mfd/rohm-bd72720.h | 634 ++++++++++ >> include/linux/mfd/rohm-generic.h | 1 + >> 19 files changed, 3127 insertions(+), 132 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/mfd/rohm,bd72720-pmic.yaml >> create mode 100644 Documentation/devicetree/bindings/regulator/rohm,bd72720-regulator.yaml >> create mode 100644 drivers/gpio/gpio-bd72720.c >> create mode 100644 include/linux/mfd/rohm-bd72720.h > > The MFD parts LGTM. Thanks Lee! > What Acks are you waiting on? What's the merge strategy? I think everything else has been acked by maintainers, except the power-supply parts. I think those have only been looked at by Andreas and Linus W. Haven't heard anything from Sebastian :( I would love to see the patches 1 - 14 and 17 to be merged (via MFD?). I could then re-spin the 15 and 16 to limited audience as I hope Sebastian had time to take a look at them. However, I don't think any of the other patches in the series depend on the last . Yours, -- Matti. --- Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland ~~ When things go utterly wrong vim users can always type :help! ~~