From: Arnd Bergmann <arnd@arndb.de>
To: Bryan Wu <cooloney@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Richard Purdie <rpurdie@rpsys.net>,
linux-leds@vger.kernel.org,
Philipp Zabel <philipp.zabel@gmail.com>,
Paul Parsons <lost.distance@yahoo.com>,
linux-arm-kernel@lists.infradead.org, akpm@linux-foundation.org
Subject: [PATCH, RESEND] leds: ipaq needs LEDS_CLASS
Date: Wed, 18 Feb 2015 22:10:53 +0100 [thread overview]
Message-ID: <6859961.SRiBVu7Ycu@wuerfel> (raw)
All other drivers have a dependency on this already, but this one
does not, which can lead to a link error when LEDS_CLASS is not set.
drivers/built-in.o: In function `micro_leds_remove':
:(.text+0x13d1bc): undefined reference to `led_classdev_unregister'
drivers/built-in.o: In function `micro_leds_probe':
:(.text+0x13d3d0): undefined reference to `led_classdev_register'
This patch adds the missing dependency.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
----
Originally sent on 2015-01-28, but has not appeared in linux-next
diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
index 95029dfd311a..927bb4491e1c 100644
--- a/drivers/leds/Kconfig
+++ b/drivers/leds/Kconfig
@@ -144,6 +144,7 @@ config LEDS_SUNFIRE
config LEDS_IPAQ_MICRO
tristate "LED Support for the Compaq iPAQ h3xxx"
+ depends on LEDS_CLASS
depends on MFD_IPAQ_MICRO
help
Choose this option if you want to use the notification LED on
reply other threads:[~2015-02-18 21:11 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6859961.SRiBVu7Ycu@wuerfel \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=cooloney@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-leds@vger.kernel.org \
--cc=lost.distance@yahoo.com \
--cc=philipp.zabel@gmail.com \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox