From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Pavel Machek <pavel@ucw.cz>, Dan Murphy <dmurphy@ti.com>,
linux-leds@vger.kernel.org
Subject: Re: [PATCH v2 1/2] leds: trigger: gpio: GPIO 0 is valid
Date: Fri, 30 Aug 2019 23:11:07 +0200 [thread overview]
Message-ID: <68b262ff-ef98-0fd6-0773-5eb02774b61a@gmail.com> (raw)
In-Reply-To: <20190830150820.63450-1-andriy.shevchenko@linux.intel.com>
Hi Andy,
Thank you for the v2.
On 8/30/19 5:08 PM, Andy Shevchenko wrote:
> Allow all valid GPIOs to be used in the driver.
>
> Fixes: 17354bfe8527 ("leds: Add gpio-led trigger")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> - set initial GPIO value to -ENOENT (Jacek)
> drivers/leds/trigger/ledtrig-gpio.c | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/leds/trigger/ledtrig-gpio.c b/drivers/leds/trigger/ledtrig-gpio.c
> index 33cc99a1a16a..dc64679b1a92 100644
> --- a/drivers/leds/trigger/ledtrig-gpio.c
> +++ b/drivers/leds/trigger/ledtrig-gpio.c
> @@ -131,10 +131,10 @@ static ssize_t gpio_trig_gpio_store(struct device *dev,
> if (gpio_data->gpio == gpio)
> return n;
>
> - if (!gpio) {
> - if (gpio_data->gpio != 0)
> + if (!gpio_is_valid(gpio)) {
> + if (gpio_is_valid(gpio_data->gpio))
> free_irq(gpio_to_irq(gpio_data->gpio), led);
> - gpio_data->gpio = 0;
> + gpio_data->gpio = gpio;
> return n;
> }
>
> @@ -144,7 +144,7 @@ static ssize_t gpio_trig_gpio_store(struct device *dev,
> if (ret) {
> dev_err(dev, "request_irq failed with error %d\n", ret);
> } else {
> - if (gpio_data->gpio != 0)
> + if (gpio_is_valid(gpio_data->gpio))
> free_irq(gpio_to_irq(gpio_data->gpio), led);
> gpio_data->gpio = gpio;
> /* After changing the GPIO, we need to update the LED. */
> @@ -172,6 +172,8 @@ static int gpio_trig_activate(struct led_classdev *led)
> return -ENOMEM;
>
> gpio_data->led = led;
> + gpio_data->gpio = -ENOENT;
> +
> led_set_trigger_data(led, gpio_data);
>
> return 0;
> @@ -181,7 +183,7 @@ static void gpio_trig_deactivate(struct led_classdev *led)
> {
> struct gpio_trig_data *gpio_data = led_get_trigger_data(led);
>
> - if (gpio_data->gpio != 0)
> + if (gpio_is_valid(gpio_data->gpio))
> free_irq(gpio_to_irq(gpio_data->gpio), led);
> kfree(gpio_data);
> }
>
Both 1/2 and 2/2 applied.
--
Best regards,
Jacek Anaszewski
prev parent reply other threads:[~2019-08-30 21:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 15:08 [PATCH v2 1/2] leds: trigger: gpio: GPIO 0 is valid Andy Shevchenko
2019-08-30 15:08 ` [PATCH v2 2/2] leds: trigger: gpio: Convert to use kstrtox() Andy Shevchenko
2019-09-01 10:23 ` Pavel Machek
2019-09-01 11:36 ` Jacek Anaszewski
2019-09-01 11:41 ` Jacek Anaszewski
2019-09-02 10:08 ` Andy Shevchenko
2019-08-30 21:11 ` Jacek Anaszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68b262ff-ef98-0fd6-0773-5eb02774b61a@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dmurphy@ti.com \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox