* [PATCH] leds: upboard: fix module alias
@ 2025-10-16 13:28 Thomas Richard
2025-10-16 19:11 ` Krzysztof Kozlowski
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Richard @ 2025-10-16 13:28 UTC (permalink / raw)
To: Lee Jones, Pavel Machek
Cc: Thomas Petazzoni, linux-leds, linux-kernel, DanieleCleri,
GaryWang, Thomas Richard
Fix module alias for auto-loading.
Fixes: 0ef2929a0181 ("leds: Add AAEON UP board LED driver")
Signed-off-by: Thomas Richard <thomas.richard@bootlin.com>
---
drivers/leds/leds-upboard.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/leds/leds-upboard.c b/drivers/leds/leds-upboard.c
index b350eb294280fd68535c47843417f4282f97b423..12989b2f195309cc930095ecc5f855065e88d9aa 100644
--- a/drivers/leds/leds-upboard.c
+++ b/drivers/leds/leds-upboard.c
@@ -123,4 +123,4 @@ MODULE_AUTHOR("Gary Wang <garywang@aaeon.com.tw>");
MODULE_AUTHOR("Thomas Richard <thomas.richard@bootlin.com>");
MODULE_DESCRIPTION("UP Board LED driver");
MODULE_LICENSE("GPL");
-MODULE_ALIAS("platform:upboard-led");
+MODULE_ALIAS("platform:upboard-leds");
---
base-commit: 3a8660878839faadb4f1a6dd72c3179c1df56787
change-id: 20251016-leds-upboard-fix-module-alias-194508af3111
Best regards,
--
Thomas Richard <thomas.richard@bootlin.com>
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] leds: upboard: fix module alias
2025-10-16 13:28 [PATCH] leds: upboard: fix module alias Thomas Richard
@ 2025-10-16 19:11 ` Krzysztof Kozlowski
2025-10-17 9:00 ` Thomas Richard
0 siblings, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2025-10-16 19:11 UTC (permalink / raw)
To: Thomas Richard, Lee Jones, Pavel Machek
Cc: Thomas Petazzoni, linux-leds, linux-kernel, DanieleCleri,
GaryWang
On 16/10/2025 15:28, Thomas Richard wrote:
> Fix module alias for auto-loading.
Fix what exactly? It was a completely correct alias. Please describe
here bug (so WHY you are doing this) not what you are doing.
>
> Fixes: 0ef2929a0181 ("leds: Add AAEON UP board LED driver")
> Signed-off-by: Thomas Richard <thomas.richard@bootlin.com>
> ---
> drivers/leds/leds-upboard.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/leds/leds-upboard.c b/drivers/leds/leds-upboard.c
> index b350eb294280fd68535c47843417f4282f97b423..12989b2f195309cc930095ecc5f855065e88d9aa 100644
> --- a/drivers/leds/leds-upboard.c
> +++ b/drivers/leds/leds-upboard.c
> @@ -123,4 +123,4 @@ MODULE_AUTHOR("Gary Wang <garywang@aaeon.com.tw>");
> MODULE_AUTHOR("Thomas Richard <thomas.richard@bootlin.com>");
> MODULE_DESCRIPTION("UP Board LED driver");
> MODULE_LICENSE("GPL");
> -MODULE_ALIAS("platform:upboard-led");
> +MODULE_ALIAS("platform:upboard-leds");
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] leds: upboard: fix module alias
2025-10-16 19:11 ` Krzysztof Kozlowski
@ 2025-10-17 9:00 ` Thomas Richard
2025-10-17 9:03 ` Krzysztof Kozlowski
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Richard @ 2025-10-17 9:00 UTC (permalink / raw)
To: Krzysztof Kozlowski, Lee Jones, Pavel Machek
Cc: Thomas Petazzoni, linux-leds, linux-kernel, DanieleCleri,
GaryWang
On 10/16/25 9:11 PM, Krzysztof Kozlowski wrote:
> On 16/10/2025 15:28, Thomas Richard wrote:
>> Fix module alias for auto-loading.
>
> Fix what exactly? It was a completely correct alias. Please describe
> here bug (so WHY you are doing this) not what you are doing.
The module alias does not match the cell name defined in the MFD driver,
so if the driver is built as a module, it is not automatically loaded.
Best Regards,
Thomas
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] leds: upboard: fix module alias
2025-10-17 9:00 ` Thomas Richard
@ 2025-10-17 9:03 ` Krzysztof Kozlowski
0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2025-10-17 9:03 UTC (permalink / raw)
To: Thomas Richard, Lee Jones, Pavel Machek
Cc: Thomas Petazzoni, linux-leds, linux-kernel, DanieleCleri,
GaryWang
On 17/10/2025 11:00, Thomas Richard wrote:
> On 10/16/25 9:11 PM, Krzysztof Kozlowski wrote:
>> On 16/10/2025 15:28, Thomas Richard wrote:
>>> Fix module alias for auto-loading.
>>
>> Fix what exactly? It was a completely correct alias. Please describe
>> here bug (so WHY you are doing this) not what you are doing.
>
> The module alias does not match the cell name defined in the MFD driver,
Then this should be clearly explained.
Again: your commit msg should describe the bug, the reasons why you are
doing it, not just "fix" without telling what is wrong.
> so if the driver is built as a module, it is not automatically loaded.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-10-17 9:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-16 13:28 [PATCH] leds: upboard: fix module alias Thomas Richard
2025-10-16 19:11 ` Krzysztof Kozlowski
2025-10-17 9:00 ` Thomas Richard
2025-10-17 9:03 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).