From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 554C3C46CA1 for ; Fri, 15 Sep 2023 20:46:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237269AbjIOUqL (ORCPT ); Fri, 15 Sep 2023 16:46:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237522AbjIOUqC (ORCPT ); Fri, 15 Sep 2023 16:46:02 -0400 Received: from omta034.useast.a.cloudfilter.net (omta034.useast.a.cloudfilter.net [44.202.169.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02DFFE50 for ; Fri, 15 Sep 2023 13:45:54 -0700 (PDT) Received: from eig-obgw-5003a.ext.cloudfilter.net ([10.0.29.159]) by cmsmtp with ESMTP id hFEOqdGKdez0ChFgxqBvzA; Fri, 15 Sep 2023 20:45:31 +0000 Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with ESMTPS id hFhJqavrdPsxChFhJqv1Ud; Fri, 15 Sep 2023 20:45:53 +0000 X-Authority-Analysis: v=2.4 cv=BuqOfKb5 c=1 sm=1 tr=0 ts=6504c281 a=1YbLdUo/zbTtOZ3uB5T3HA==:117 a=WzbPXH4gqzPVN0x6HrNMNA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10 a=zNV7Rl7Rt7sA:10 a=wYkD_t78qR0A:10 a=NEAV23lmAAAA:8 a=VwQbUJbxAAAA:8 a=cm27Pg_UAAAA:8 a=HvF037n1xESchLcPDVoA:9 a=QEXdDO2ut3YA:10 a=AjGcO6oz07-iQ99wixmX:22 a=xmb-EsYY8bH0VWELuYED:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=35M4n8eVgj1j6bFq45ZL42nsUi2E5HxS/MYJDKegMWk=; b=y3O5hke9SpkHqTxEBk1V76/17O X8/UilmKI7sb2dwF5M8No0h9sMvY3IW5RNi8bGY6+ev32oMX7Ddi9PEspSjAqbSkO8bU7NEV+IXPd EDtea8/EWgCUpeurU98q6l4YWd6Bd1UJXnzSfXjsCUfXFXKQEkZIRBa+L1LnFfldzQmO3NM/RcAPg cXnRPbnCJ/8SmRQaXvEksOJfJuDIQ1qHNqrJe6llk7IP1e5NyRDLusLIfCYghcepd09YoOa30ylSN IJ/VCIijRc3CWFsaPWgE7nq0yRSG4jDhJu00W653rd4MdV94+C/r+0yJOVt9YnB3TkzUjTeWZmsdz bJFxZ0iA==; Received: from 187-162-21-192.static.axtel.net ([187.162.21.192]:34914 helo=[192.168.15.8]) by gator4166.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1qhFhI-002aET-1U; Fri, 15 Sep 2023 15:45:52 -0500 Message-ID: <6c387921-0f30-094e-204b-33ae0daa1f55@embeddedor.com> Date: Fri, 15 Sep 2023 14:46:47 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] leds: el15203000: Annotate struct el15203000 with __counted_by Content-Language: en-US To: Kees Cook , Pavel Machek Cc: Lee Jones , linux-leds@vger.kernel.org, Nathan Chancellor , Nick Desaulniers , Tom Rix , linux-kernel@vger.kernel.org, llvm@lists.linux.dev, linux-hardening@vger.kernel.org References: <20230915200955.never.871-kees@kernel.org> From: "Gustavo A. R. Silva" In-Reply-To: <20230915200955.never.871-kees@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 187.162.21.192 X-Source-L: No X-Exim-ID: 1qhFhI-002aET-1U X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 187-162-21-192.static.axtel.net ([192.168.15.8]) [187.162.21.192]:34914 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 209 X-Org: HG=hgshared;ORG=hostgator; X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfLJ9Kr/BDXjY+SFb3GyD6avL0MRwJCiyJULIo2wbul3cyXn2sgHWeDSviWRXRO+Wlqb9q5bNjEYFiX9TYkLfUTYGWrqgHGgcP4j7XOsTOIY14LDMz07X NmiQIFlOnJ8KRPZ7rM1yXRNWrQzEFhkstPaiR7lTi6Ft8Yg9AzIPPwkKEJyMigWp5x7nvSZRuFI7X2MZSKTBjm/vhR6dPZL0MmmDADWfDAx1dKyIEn0CCle4 Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On 9/15/23 14:09, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct el15203000. > > [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci > > Cc: Pavel Machek > Cc: Lee Jones > Cc: linux-leds@vger.kernel.org > Signed-off-by: Kees Cook Reviewed-by: Gustavo A. R. Silva Thanks -- Gustavo > --- > drivers/leds/leds-el15203000.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/leds/leds-el15203000.c b/drivers/leds/leds-el15203000.c > index 7e7b617bcd56..d40194a3029f 100644 > --- a/drivers/leds/leds-el15203000.c > +++ b/drivers/leds/leds-el15203000.c > @@ -80,7 +80,7 @@ struct el15203000 { > struct spi_device *spi; > unsigned long delay; > size_t count; > - struct el15203000_led leds[]; > + struct el15203000_led leds[] __counted_by(count); > }; > > #define to_el15203000_led(d) container_of(d, struct el15203000_led, ldev)