From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 054C2C001B2 for ; Fri, 16 Dec 2022 12:03:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230287AbiLPMDU (ORCPT ); Fri, 16 Dec 2022 07:03:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230400AbiLPMDN (ORCPT ); Fri, 16 Dec 2022 07:03:13 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B653BD59 for ; Fri, 16 Dec 2022 04:02:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671192143; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n0onGUwho42Lk/2Xvrk5LwW7Uvmn5kP1MKjLYRvtQAc=; b=YfkboM0nrji9h+OdnuVYJnxrgDmATNw5RBc2d1pEN5qn8+RjBsohTiYmRi5GMv7MdEBDyR kAMdDe1us3K2/KLKk+utnfXR6BE14VS+CS0PAd7eJOBuTvz5NJavuo1uI4A0rp4p/ey2Xq NRRjke+SFbecEGmhgeOt0SSpCksJuWo= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-531-UQFoewloO22TMu3klRfoOg-1; Fri, 16 Dec 2022 07:02:22 -0500 X-MC-Unique: UQFoewloO22TMu3klRfoOg-1 Received: by mail-ed1-f71.google.com with SMTP id y10-20020a056402358a00b0046fc5125069so1707342edc.23 for ; Fri, 16 Dec 2022 04:02:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=n0onGUwho42Lk/2Xvrk5LwW7Uvmn5kP1MKjLYRvtQAc=; b=amIcRJgLTcqZzWnAzRVFPPC4V3LHReiopamtl3PajSjxUQGF9r6XyY1tnuCsoKKDW0 YsKnvSKIrToyLMXuml80kSIb42sGfAG8QzetBZWUVwubg7UXNvsDBMzU6mICcssi7Mkq jdezduUGODVlPEcjJh2C8LbQzPWDJD+nJtic/QQNqmnVfUGyL/oBKWExrM0IiHBYEQKd g/ALRzkuNsgVyJmLnzP234acvh0aP2iuC+UmHfk64FhW/qrFj+kuV8E6sPUJ0qbVXmhH 8TIaXF/eKUDw8VgwiZJv1tMPXmPHUkc4aLpj3bvqTqFVPjttvxh3PsuGk/WBwj1QDa84 PM8Q== X-Gm-Message-State: ANoB5pnVTyb2LSbVu06HAJVqbR5Yrak8QL1qOetvC4Dqnu7rNNkB3JyV o4mwYnaRIxeqRaen3v8FfnuyHWhNTlqkXs14okNQmqCXyWvWemOi0uQQKvh+wpTWEbdbaGS/oR+ 5hb/yTCIQ+1qsLILpHHad1Q== X-Received: by 2002:a05:6402:3987:b0:467:e9a5:77c4 with SMTP id fk7-20020a056402398700b00467e9a577c4mr27286758edb.14.1671192141123; Fri, 16 Dec 2022 04:02:21 -0800 (PST) X-Google-Smtp-Source: AA0mqf4xS5GY2N7ApHCruZzxYhR/KCijYVIin7KMr5Sjan0LxTro5Ol3BiPdKrXUHFjiH/21a3awSg== X-Received: by 2002:a05:6402:3987:b0:467:e9a5:77c4 with SMTP id fk7-20020a056402398700b00467e9a577c4mr27286737edb.14.1671192140853; Fri, 16 Dec 2022 04:02:20 -0800 (PST) Received: from ?IPV6:2001:1c00:c1e:bf00:d69d:5353:dba5:ee81? (2001-1c00-0c1e-bf00-d69d-5353-dba5-ee81.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:d69d:5353:dba5:ee81]) by smtp.gmail.com with ESMTPSA id cy28-20020a0564021c9c00b00463597d2c25sm784672edb.74.2022.12.16.04.02.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Dec 2022 04:02:20 -0800 (PST) Message-ID: <6c5867ed-a78e-8919-b34f-560c0773727e@redhat.com> Date: Fri, 16 Dec 2022 13:02:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v3 00/11] leds: lookup-table support + int3472/media privacy LED support Content-Language: en-US, nl To: Mark Gross , Andy Shevchenko , Pavel Machek , Lee Jones , Linus Walleij , Daniel Scally , Laurent Pinchart , Mauro Carvalho Chehab , Sakari Ailus Cc: platform-driver-x86@vger.kernel.org, linux-leds@vger.kernel.org, linux-gpio@vger.kernel.org, Kate Hsuan , Mark Pearson , Andy Yeh , Yao Hao , linux-media@vger.kernel.org References: <20221216113013.126881-1-hdegoede@redhat.com> From: Hans de Goede In-Reply-To: <20221216113013.126881-1-hdegoede@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Hi, On 12/16/22 12:30, Hans de Goede wrote: > Hi All, > > Here is my 3th attempt at adjusting the INT3472 code's handling of > the privacy LED on x86 laptops with MIPI camera(s) so that it will also > work on devices which have a privacy-LED GPIO but not a clk-enable GPIO > (so that we cannot just tie the LED state to the clk-enable state). > > Due to popular request by multiple people this new version now models > the privacy LED as a LED class device. This requires being able to > "tie" the LED class device to a specific camera sensor (some devices > have multiple sensors + privacy-LEDs). > > Patches 1-5 are LED subsystem patches for this. 1 is a bug fix, 2-4 > is a bit of refactoring in preparation for patch 5 which adds > generic (non devicetree specific) led_get() and devm_led_get() function > (which will also work with devicetree) and lookup table support to > allow platform code to add LED class-device <-> consumer-dev,function > lookups for non devicetree platforms. > > Patch 6 adds generic privacy-LED support to the v4l2-core/v4l2-subdev.c > code automatically enabling the privacy-LED when s_stream(subdev, 1) > is called. So that we don't need to privacy-LED code to all the > camera sensor drivers separately (as requested by Sakari). > > These are all new patches in version 3. Patches 7-11 are patches > to the platform specific INT3472 code to register privacy-LED class > devices + lookup table entries for privacy-LEDs described in > the special INT3472 ACPI nodes found on x86 devices with MIPI > cameras (+ prep work + some other INT3472 fixes). > > Assuming the LED and media maintainers are happy with the approach > suggested here (if you are please give your Ack / Reviewed-by) we > need to talk about how to merge this since patches 6 and 7-11 > depend on the LED subsystem changes. I think it would be best if > the LED subsystem can provide an immutable branch with patches 1-5 > (on top of 6.2-rc1 once it is out) and then the media folks and I > can merge that branch and then apply the other patches on top. > > This series has been tested on: > > - Lenovo ThinkPad X1 Yoga gen 7, IPU6, front: ov2740 with privacy LED > - Dell Latitude 9420, IPU 6, front: ov01a1s with privacy LED > - Mirosoft Surface Go, IPU3, front: ov5693 with privacy LED > back: ov8865 with privacy LED (pled not yet supported) > > Regards, > > Hans p.s. I have matching out of tree IPU6 driver changes here: https://github.com/jwrdegoede/ipu6-drivers/commits/master once this series has landed these changes will allow using the out of tree IPU6 driver with an unmodified upstream kernel. Regards, Hans