From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jacek Anaszewski Subject: Re: [PATCH v4 1/4] Documentation: devicetree: Add document bindings for leds-mt6323 Date: Sun, 26 Feb 2017 18:35:11 +0100 Message-ID: <709ff2c2-38f3-a3dd-f686-de3db873997d@gmail.com> References: <1487962041-6548-1-git-send-email-sean.wang@mediatek.com> <1487962041-6548-2-git-send-email-sean.wang@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1487962041-6548-2-git-send-email-sean.wang@mediatek.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: sean.wang@mediatek.com, rpurdie@rpsys.net, lee.jones@linaro.org, matthias.bgg@gmail.com, pavel@ucw.cz, robh+dt@kernel.org, mark.rutland@arm.com Cc: devicetree@vger.kernel.org, keyhaede@gmail.com, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-leds@vger.kernel.org Hi Sean, Thanks for the update. I have one comment below. On 02/24/2017 07:47 PM, sean.wang@mediatek.com wrote: > From: Sean Wang > > This patch adds documentation for devicetree bindings > for LED support on MT6323 PMIC > > Signed-off-by: Sean Wang > --- > .../devicetree/bindings/leds/leds-mt6323.txt | 64 ++++++++++++++++++++++ > 1 file changed, 64 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/leds-mt6323.txt > > diff --git a/Documentation/devicetree/bindings/leds/leds-mt6323.txt b/Documentation/devicetree/bindings/leds/leds-mt6323.txt > new file mode 100644 > index 0000000..950b8c6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/leds-mt6323.txt > @@ -0,0 +1,64 @@ > +Device Tree Bindings for LED support on MT6323 PMIC > + > +MT6323 LED controller is subfunction provided by > +MT6323 PMIC, so the LED controllers are defined as > +the subnode of the function node provided by MT6323 > +PMIC controller that is being defined as one kind of > +Muti-Function Device (MFD) using shared bus called > +PMIC wrapper for each subfunction to access remote > +MT6323 PMIC hardware. > + > +For MT6323 MFD bindings see: > +Documentation/devicetree/bindings/mfd/mt6397.txt > +For MediaTek PMIC wrapper bindings see: > +Documentation/devicetree/bindings/soc/mediatek/pwrap.txt > + > +There's sub-node for the LED controller that describes > +the initial behavior for each LED physically and currently > +only four LED sub-nodes can be supported. > + > +Required properties: > +- compatible : Must be "mediatek,mt6323-led" > +- reg : LED channel number (0..3) > + > +Optional properties: > +- label : (optional) > + see Documentation/devicetree/bindings/leds/common.txt > +- linux,default-trigger : (optional) > + see Documentation/devicetree/bindings/leds/common.txt > +- default-state: (optional) The initial state of the LED > + see Documentation/devicetree/bindings/leds/common.txt > + > +Example: > + > +&pwrap { > + pmic: mt6323 { > + compatible = "mediatek,mt6323"; > + interrupt-parent = <&pio>; > + interrupts = <150 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-controller; > + #interrupt-cells = <2>; > + > + mt6323led: mt6323led{ > + compatible = "mediatek,mt6323-led"; You require here also: #address-cells = <1>; #size-cells = <0>; Without these entries you should notice a warning from dtc compiler. > + > + led0: isink0 { > + reg = <0>; > + label = "LED0" > + linux,default-trigger = "timer"; > + default-state = "on"; > + }; > + led1: isink1 { > + reg = <1>; > + label = "LED1"; > + default-state = "on"; > + }; > + led2: isink2 { > + reg = <2>; > + label = "LED2"; > + linux,default-trigger = "timer"; > + default-state = "off"; > + }; > + }; > + }; > +}; > -- Best regards, Jacek Anaszewski