From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Pavel Machek <pavel@ucw.cz>,
linux-leds@vger.kernel.org,
kernel list <linux-kernel@vger.kernel.org>
Subject: Re: Splitting led drivers to subdirectories?
Date: Tue, 12 Sep 2017 21:11:07 +0200 [thread overview]
Message-ID: <72bc03c4-90d8-0f82-42b5-172022fb6a8b@gmail.com> (raw)
In-Reply-To: <20170912125408.GA4074@amd>
Hi,
On 09/12/2017 02:54 PM, Pavel Machek wrote:
> Hi!
>
> Is it time to start splitting drivers into subdirectories?
>
> I'd quite like to see drivers/leds/i2c/ and drivers/leds/flash/ . That
> way it is easier to look at related drivers for inspiration...
These categorization would be inconsistent - i2c is a bus, and
flash is a LED function. Moreover, not all devices are driven through
buses, some of them via gpio, MMIO or even as2cwire like in case of
leds-aat1290. Do we want to split the drivers like that? It would
generate only unnecessary noise IMHO.
We could go for splitting drivers to LED and LED flash class,
but the former is just a subset of the latter, so it would be
also not accurate.
Effectively I propose to apply the "leave well alone" rule here :-)
--
Best regards,
Jacek Anaszewski
prev parent reply other threads:[~2017-09-12 19:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-12 12:54 Splitting led drivers to subdirectories? Pavel Machek
2017-09-12 19:11 ` Jacek Anaszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72bc03c4-90d8-0f82-42b5-172022fb6a8b@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).