* [PATCH] leds: tca6507: Remove unnecessary reg check
@ 2017-10-08 18:55 Christos Gkekas
2017-10-09 6:59 ` Pavel Machek
2017-10-09 18:43 ` Jacek Anaszewski
0 siblings, 2 replies; 3+ messages in thread
From: Christos Gkekas @ 2017-10-08 18:55 UTC (permalink / raw)
To: Richard Purdie, Jacek Anaszewski, Pavel Machek, linux-leds,
linux-kernel
Cc: Christos Gkekas
Variable reg is unsigned so checking whether it is less than zero is not
necessary.
Signed-off-by: Christos Gkekas <chris.gekas@gmail.com>
---
drivers/leds/leds-tca6507.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/leds/leds-tca6507.c b/drivers/leds/leds-tca6507.c
index 45222a7..c12c16f 100644
--- a/drivers/leds/leds-tca6507.c
+++ b/drivers/leds/leds-tca6507.c
@@ -715,7 +715,7 @@ tca6507_led_dt_init(struct i2c_client *client)
if (of_property_match_string(child, "compatible", "gpio") >= 0)
led.flags |= TCA6507_MAKE_GPIO;
ret = of_property_read_u32(child, "reg", ®);
- if (ret != 0 || reg < 0 || reg >= NUM_LEDS)
+ if (ret != 0 || reg >= NUM_LEDS)
continue;
tca_leds[reg] = led;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] leds: tca6507: Remove unnecessary reg check
2017-10-08 18:55 [PATCH] leds: tca6507: Remove unnecessary reg check Christos Gkekas
@ 2017-10-09 6:59 ` Pavel Machek
2017-10-09 18:43 ` Jacek Anaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Pavel Machek @ 2017-10-09 6:59 UTC (permalink / raw)
To: Christos Gkekas
Cc: Richard Purdie, Jacek Anaszewski, linux-leds, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 388 bytes --]
On Sun 2017-10-08 19:55:05, Christos Gkekas wrote:
> Variable reg is unsigned so checking whether it is less than zero is not
> necessary.
>
> Signed-off-by: Christos Gkekas <chris.gekas@gmail.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] leds: tca6507: Remove unnecessary reg check
2017-10-08 18:55 [PATCH] leds: tca6507: Remove unnecessary reg check Christos Gkekas
2017-10-09 6:59 ` Pavel Machek
@ 2017-10-09 18:43 ` Jacek Anaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Jacek Anaszewski @ 2017-10-09 18:43 UTC (permalink / raw)
To: Christos Gkekas, Richard Purdie, Pavel Machek, linux-leds,
linux-kernel
Hi Christos,
Thanks for the patch.
On 10/08/2017 08:55 PM, Christos Gkekas wrote:
> Variable reg is unsigned so checking whether it is less than zero is not
> necessary.
>
> Signed-off-by: Christos Gkekas <chris.gekas@gmail.com>
> ---
> drivers/leds/leds-tca6507.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/leds/leds-tca6507.c b/drivers/leds/leds-tca6507.c
> index 45222a7..c12c16f 100644
> --- a/drivers/leds/leds-tca6507.c
> +++ b/drivers/leds/leds-tca6507.c
> @@ -715,7 +715,7 @@ tca6507_led_dt_init(struct i2c_client *client)
> if (of_property_match_string(child, "compatible", "gpio") >= 0)
> led.flags |= TCA6507_MAKE_GPIO;
> ret = of_property_read_u32(child, "reg", ®);
> - if (ret != 0 || reg < 0 || reg >= NUM_LEDS)
> + if (ret != 0 || reg >= NUM_LEDS)
> continue;
>
> tca_leds[reg] = led;
>
Applied.
--
Best regards,
Jacek Anaszewski
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-09 18:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-08 18:55 [PATCH] leds: tca6507: Remove unnecessary reg check Christos Gkekas
2017-10-09 6:59 ` Pavel Machek
2017-10-09 18:43 ` Jacek Anaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).