From: Heiner Kallweit <hkallweit1@gmail.com>
To: Lee Jones <lee@kernel.org>,
linux-kernel@vger.kernel.org, Pavel Machek <pavel@ucw.cz>,
linux-leds@vger.kernel.org
Subject: Re: [PATCH 1/1] leds: core: Omit set_brightness error message for a LED supporting hw trigger only
Date: Mon, 24 Jun 2024 22:21:18 +0200 [thread overview]
Message-ID: <778ec5c9-9ec2-4496-a458-b323d8904b0d@gmail.com> (raw)
In-Reply-To: <20240620090932.GD3029315@google.com>
On 20.06.2024 11:09, Lee Jones wrote:
> On Thu, 13 Jun 2024, Lee Jones wrote:
>
>> If both set_brightness functions return -ENOTSUPP, then the LED doesn't
>> support setting a fixed brightness value, and the error message isn't
>> helpful. This can be the case e.g. for LEDs supporting a specific hw
>> trigger only.
>>
>> Pinched the subject line and commit message from Heiner:
>> Link: https://lore.kernel.org/all/44177e37-9512-4044-8991-bb23b184bf37@gmail.com/
>>
>> Reworked the function to provide Heiner's required semantics whilst
>> simultaneously increasing readability and flow.
>>
>> Cc: Pavel Machek <pavel@ucw.cz>
>> Cc: linux-leds@vger.kernel.org
>> Suggested-by: Heiner Kallweit <hkallweit1@gmail.com>
>
> Heiner, you good with this solution?
>
> A Tested-by or Reviewed-by would be good if you have the time.
>
>> Signed-off-by: Lee Jones <lee@kernel.org>
Reviewed-by: Heiner Kallweit <hkallweit1@gmail.com>
next prev parent reply other threads:[~2024-06-24 20:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 7:57 [PATCH 1/1] leds: core: Omit set_brightness error message for a LED supporting hw trigger only Lee Jones
2024-06-20 9:09 ` Lee Jones
2024-06-24 20:21 ` Heiner Kallweit [this message]
2024-06-26 15:56 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=778ec5c9-9ec2-4496-a458-b323d8904b0d@gmail.com \
--to=hkallweit1@gmail.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).