From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Murphy Subject: Re: [PATCH v5 1/6] regulator: lm363x: Make the gpio register enable flexible Date: Wed, 5 Jun 2019 07:02:45 -0500 Message-ID: <7ba7a633-1a39-adcc-e942-12c0eb7c3b16@ti.com> References: <20190604174345.14841-1-dmurphy@ti.com> <20190604174345.14841-2-dmurphy@ti.com> <20190605100132.GL2456@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190605100132.GL2456@sirena.org.uk> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Mark Brown Cc: jacek.anaszewski@gmail.com, pavel@ucw.cz, lgirdwood@gmail.com, lee.jones@linaro.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-leds@vger.kernel.org Mark On 6/5/19 5:01 AM, Mark Brown wrote: > On Tue, Jun 04, 2019 at 12:43:40PM -0500, Dan Murphy wrote: >> The use of and enablement of the GPIO can be used across devices. >> Use the enable_reg in the regulator descriptor for the register to >> write. >> >> Signed-off-by: Dan Murphy >> Signed-off-by: Jacek Anaszewski >> --- >> >> v5 - No changes to the patch changes requested in this patch were done in >> patch 4 of this series - https://lore.kernel.org/patchwork/patch/1077408/ > I was expecting this patch to just be completely dropped? It looks like > the end result is very similar, we're still using enable_reg to get the > register and I don't see new validation added in patch 4. I can squash patch 1 into 4. Also not sure what you mean by new validation. Please comment on patch 4 to what you are looking for Dan