From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: linux-leds@vger.kernel.org
Subject: Re: Cleanups in "next" tree
Date: Tue, 7 Apr 2020 22:23:24 +0200 [thread overview]
Message-ID: <7be0ce37-235d-9069-ea6e-1d353cc14729@gmail.com> (raw)
In-Reply-To: <20200407072854.GA18673@amd.ucw.cz>
On 4/7/20 9:28 AM, Pavel Machek wrote:
> Hi!
>
>>> I'm sorry I failed to meet your high expectations... But I don't
>>> believe I done anything completely outside of usual kernel procedures.
>>
>> I believe code review is quite usual kernel procedure.
>
> I don't disagree with that.
>
>>> Could you list the patches and objections you have?
>>
>> I already expressed my concerns regarding Turris Omnia patch.
>
> Ok.
>
>> My comments regarding remaining patches:
>>
>> - "Make label "white:power" to be consistent with"
>>
>> I disagree here. "system" was OK.
>
> It was too vague... I know the hardware and it is a LED above power
> button used as a power indicator.
>
>> - "Warn about old defines that probably should not be used."
>>
>> Obsolete is only LED_FULL, so the comment is in wrong line
>
> No, all of them are bad. Maybe LED_OFF could be used going forward,
> but... it is simply easier to write 0. The type is not really an en
> enumeration, it is brightness, with variable maximum value.
In this case brightness should be turned into an int and the change
should be applied throughout the whole kernel. Otherwise it is
questionable - why all enums are made obsolete if the type of struct
led_classdev's brightness property is still enum led_brightness?
Do we have some replacement? - one could ask.
>
>> - "Group LED functions according to functionality, and add some"
>>
>> You're adding here some random comments referencing obsolete
>> naming. I think that it is enough to say what is current standard.
>
> Ok, I'll drop that part. But I really want to get that documented
> _somewhere_, because obsolete naming is currently in use, and we won't
> be able to change it :-(.
You've pushed it out anyway...
>> Also, I had a patch [0] describing standard LED functions in my LED
>> naming patch set, but it was not merged. It could be worth getting
>> back to it at this occasion.
>
> I'll take a look.
>
> Best regards,
> Pavel
>
--
Best regards,
Jacek Anaszewski
prev parent reply other threads:[~2020-04-07 20:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-22 11:59 Cleanups in "next" tree Pavel Machek
2020-03-22 13:35 ` Jacek Anaszewski
2020-03-22 15:05 ` Dan Murphy
2020-04-02 22:57 ` Pavel Machek
2020-04-03 12:49 ` Dan Murphy
2020-04-03 18:45 ` Jacek Anaszewski
2020-04-03 19:07 ` Dan Murphy
2020-04-07 7:28 ` Pavel Machek
2020-04-07 20:23 ` Jacek Anaszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7be0ce37-235d-9069-ea6e-1d353cc14729@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).