= On 2018-06-21 00:35, Rob Herring wrote:

On Tue, Jun 19, 2018 at 04:43:38PM +0530, Kiran Gunda = wrote:
Update the bindings with the new properties used for PMI8998.

Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
---
= ;.../bindings/leds/backlight/qcom-wled.txt      &n= bsp;   | 84 ++++++++++++++++++++--
1 file change= d, 77 insertions(+), 7 deletions(-)

diff --git a/Documentation= /devicetree/bindings/leds/backlight/qcom-wled.txt b/Documentation/devicetre= e/bindings/leds/backlight/qcom-wled.txt
index 14f28f2..503ce87 100644=
--- a/Documentation/devicetree/bindings/leds/backlight/qcom-wled.txt=
+++ b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.txt=
@@ -48,11 +48,15 @@ platforms. The PMIC is connected to the host pro= cessor via SPMI bus.
- qcom,current-limit
  &nb= sp;  Usage:        optional      Value type:   <u32>
= -    Definition:   mA; per-string current limit -            &n= bsp; value: For pm8941: from 0 to 25 with 5 mA step
- &nbs= p;            &= nbsp; Default 20 mA.
-        = ;         For pmi8998: from 0 = to 30 with 5 mA step
-        &nbs= p;        Default 25 mA.
+ &n= bsp;  Definition:   mA; per-string current limit; value= from 0 to 25 with
+         =      1 mA step. Default 20 mA.
+   = ;           This pro= perty is supported only for pm8941.
+
+- qcom,current-limit-mic= roamp
+    Usage:       = optional
+    Value type:   <u32>= ;
+    Definition:   uA; per-string current = limit; value from 0 to 30000 with
+      &nb= sp;       2500 uA step. Default 25000 uA= =2E

This doesn't really seem worth adding just to add '-microamp'.
= Thanks for reviewing it!. I added this because the step value for PM8941(WL= ED3) and PMI8998(WLED4)

are different. for WLED3 the step is 5mA and for WLED4= the step is 2.5mA. To mantain

the backward compatibility i have added the new proper= ty with out modifying the existing

one (qcom,current-limit).

- qcom,current-boost-limit
  &nb= sp;  Usage:        optional @@ -79,12 +83,61 @@ platforms. The PMIC is connected to the host proces= sor via SPMI bus.
        &nb= sp;      27, 29, 32, 35. default: 29V
&= nbsp;           &nbs= p;  This property is supported only for PM8941.

+- q= com,ovp-millivolt

Is this the same as qcom,ovp? If so, same comment.

Yes. It is same. WLED3 has the OVP values 2= 7V, 29V, 32V, 35V, where as

WELD4 has 18.1V, 19.6V, 29.6V, 31.1V.

+    Usage:     &nb= sp;  optional
+    Value type:   &= lt;u32>
+    Definition:   mV; Over-volta= ge protection limit;
+        &nbs= p;     For pmi8998: one of 18100, 19600, 29600, 31= 100
+           &nb= sp;  Default: 29600 mV
+      &nbs= p;       If this property is not specifi= ed for PM8941, it
+         &= nbsp;    falls back to "qcom,ovp" property.
+
- qcom,num-strings
     Usage: &nbs= p;      optional
   &nbs= p; Value type:   <u32>
    &= nbsp;Definition:   #; number of led strings attached;
- &nb= sp;            = value from 1 to 3. default: 2
-       &= nbsp;      This property is supported only fo= r PM8941.
+          &nb= sp;   value: For PM8941 from 1 to 3. default: 2
+ &nbs= p;            &= nbsp;  For PMI8998 from 1 to 4. default: 4
+
+- inter= rupts
+    Usage:       = optional
+    Value type:   <prop e= ncoded array>
+    Definition:   Interrup= ts associated with WLED. This should be
+     &nb= sp;        "short" and "ovp" interr= upts. Interrupts can be
+        &= nbsp;     specified as per the encoding listed und= er
+           &nbs= p;  Documentation/devicetree/bindings/spmi/
+   &= nbsp;          qcom,spmi-= pmic-arb.txt.
+
+- interrupt-names
+    Us= age:        optional
+   = ; Value type:   <string>
+    Def= inition:   Interrupt names associated with the interrupts.
= +             &= nbsp;Must be "short" and "ovp". The short circuit detection
+ &= nbsp;           is n= ot supported for PM8941.
+
+- qcom,enabled-strings
+ &nbs= p;  Usage:        optional
+    Value tyoe:   <u32 array>
+ &n= bsp;  Definition:   Array of the WLED strings numbered = from 0 to 3. Each
+         &= nbsp;    string of leds are operated individually. Spec= ify the
+           = ;   list of strings used by the device. Any combination of +            &n= bsp; led strings can be used.
+      &n= bsp;       for pm8941: Default values ar= e [00 01].
+          &n= bsp;   for pmi8998: Default values are [00 01 02 03].
u32 or u8 because dts syntax for 8-bit array is [].

It is u32. I will correct dts syntax in next series as= <0x00 0x01 0x02 0x03>,

which is mentioned in the example.

+
+- qcom,external-pfet
+    Usage: =       optional
+    Valu= e type:   <bool>
+    Definition: &nbs= p; Specify if external PFET control for short circuit
+ &n= bsp;           prote= ction is used. This property is supported only
+    &n= bsp;         for PMI8998.
+
+- qcom,auto-string-detection
+    Usage: &n= bsp;      optional
+    = Value type:   <bool>
+    Definition: =   Enables auto-detection of the WLED string configuration.
= +             &= nbsp;This feature is not supported for PM8941.
+

E= xample:

@@ -99,4 +152,21 @@ pm8941-wled@d800 {
     qcom,switching= -freq =3D <1600>;
     qcom,ovp =3D &l= t;29>;
     qcom,num-strings =3D <2>= ;;
+    qcom,enabled-strings =3D <0x00 0x01>; +};
+
+pmi8998-wled@d= 800 {
led-controller {

And needs a unit-address.
= Ok. Will modify as per your suggestion in the next series.

+ &n= bsp;  compatible =3D "qcom,pmi8998-wled";
+   &nb= sp;reg =3D <0xd800 0xd900>;
+    label =3D "back= light";
+
+    interrupts =3D <3 0xd8 2 IRQ_T= YPE_EDGE_RISING>,
+        &nbs= p;    <3 0xd8 1 IRQ_TYPE_EDGE_RISING>;
+ &n= bsp;  interrupt-names =3D "short", "ovp";
+   &nb= sp;qcom,current-limit-microamp =3D <25000>;
+    = ;qcom,current-boost-limit =3D <805>;
+    qcom,s= witching-freq =3D <1600>;
+    qcom,ovp-millivol= t =3D <29600>;
+    qcom,num-strings =3D <4&g= t;;
+    qcom,enabled-strings =3D <0x00 0x01 0x02 0= x03>;
};
--
The Qualcomm Innovation Center, Inc= =2E is a member of the Code Aurora Forum,
a Linux Foundation Co= llaborative Project

--=_242f2ed161315ae9400ab60c18010112-- --===============0032601356== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0032601356==--