From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: pavel@ucw.cz, lee@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Matti Vaittinen <mazziesaccount@gmail.com>
Subject: Re: [PATCH v4 1/2] dt-bindings: leds: Add ROHM BD2606MVV LED driver
Date: Fri, 14 Apr 2023 23:17:56 +0200 [thread overview]
Message-ID: <7fe8d6f5-ab0f-c6d5-2551-7beb3dfb16d7@linaro.org> (raw)
In-Reply-To: <20230414175412.37a15572@aktux>
On 14/04/2023 17:54, Andreas Kemnade wrote:
> On Fri, 14 Apr 2023 17:28:49 +0200
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
>
>> On 14/04/2023 07:53, Andreas Kemnade wrote:
>>> Document ROHM BD2606MVV LED driver devicetree bindings.
>>
>> Subject: no improvements and no comments from your side. Why?
>>
> old subject (v2):
>
> dt-bindings: leds: ROHM BD2606MVV LED driver
>
> Your comment:
> Subject: maybe drop "driver" (suggests it is for Linux drivers, although
> maybe it matches the actual hardware here?) and add missing verb, e.g.
> "Add ROHM ..."
>
> New Subject (v3/4):
> dt-bindings: leds: Add ROHM BD2606MVV LED driver
>
> What is still missing?
There is still "driver". Comment was: drop "driver". Where is it dropped?
If you do not agree, sure, just respond with something.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-04-14 21:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-14 5:53 [PATCH v4 0/2] leds: Add a driver for the BD2606MVV Andreas Kemnade
2023-04-14 5:53 ` [PATCH v4 1/2] dt-bindings: leds: Add ROHM BD2606MVV LED driver Andreas Kemnade
2023-04-14 15:28 ` Krzysztof Kozlowski
2023-04-14 15:54 ` Andreas Kemnade
2023-04-14 15:56 ` Andreas Kemnade
2023-04-14 21:17 ` Krzysztof Kozlowski [this message]
2023-04-16 21:25 ` Andreas Kemnade
2023-04-14 5:53 ` [PATCH v4 2/2] leds: bd2606mvv: Driver for the Rohm 6 Channel i2c " Andreas Kemnade
2023-04-14 12:18 ` Pavel Machek
2023-04-14 22:05 ` Andreas Kemnade
2023-04-15 8:01 ` Pavel Machek
2023-04-17 12:32 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7fe8d6f5-ab0f-c6d5-2551-7beb3dfb16d7@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andreas@kemnade.info \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).